mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/2] ALSA: firewire: Don't loop forever after a bus reset
@ 2026-11-20  5:38 Suyuan Wang via B4 Relay
  2026-11-20  5:38 ` [PATCH 1/2] ALSA: firewire-lib: Rearm the FCP transaction " Suyuan Wang via B4 Relay
  2026-11-20  5:38 ` [PATCH 2/2] ALSA: fireworks: Rearm the " Suyuan Wang via B4 Relay
  0 siblings, 2 replies; 3+ messages in thread
From: Suyuan Wang via B4 Relay @ 2026-11-20  5:38 UTC (permalink / raw)
  To: clemens, o-takashi, tiwai; +Cc: stefanr, linux-sound, perex, linux-kernel

fcp_avc_transaction() and snd_efw_transaction_run() resend their
command after a bus reset but never move the transaction back to
STATE_PENDING. The response to the resent command is then ignored and
the wait returns immediately, so both loops keep resending the command
after each ERROR_DELAY_MS pause, without a retry limit, until sending
fails.

Each patch sets the state back to STATE_PENDING before resending.

Found with a static analysis tool and checked by hand. Compile tested
only (x86_64, W=1); I don't have FireWire audio hardware.

---
Suyuan Wang (2):
      ALSA: firewire-lib: Rearm the FCP transaction after a bus reset
      ALSA: fireworks: Rearm the transaction after a bus reset

 sound/firewire/fcp.c                             | 2 ++
 sound/firewire/fireworks/fireworks_transaction.c | 2 ++
 2 files changed, 4 insertions(+)



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-20  5:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-20  5:38 [PATCH 0/2] ALSA: firewire: Don't loop forever after a bus reset Suyuan Wang via B4 Relay
2026-11-20  5:38 ` [PATCH 1/2] ALSA: firewire-lib: Rearm the FCP transaction " Suyuan Wang via B4 Relay
2026-11-20  5:38 ` [PATCH 2/2] ALSA: fireworks: Rearm the " Suyuan Wang via B4 Relay

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®