* [PATCH v2] rust: bindgen: Preserve sched_statistics alignment
@ 2026-11-20 17:19 Peder Bergan via B4 Relay
0 siblings, 0 replies; only message in thread
From: Peder Bergan via B4 Relay @ 2026-11-20 17:19 UTC (permalink / raw)
To: Miguel Ojeda
Cc: Boqun Feng, Gary Guo, Björn Roy Baron, Benno Lossin,
Andreas Hindborg, Alice Ryhl, Trevor Gross, Danilo Krummrich,
Daniel Almeida, Tamir Duberstein, Alexandre Courbot,
Onur Özkan, Carlos Llamas, Greg Kroah-Hartman,
Arve Hjønnevåg, Todd Kjos, Christian Brauner,
Jules Mercier, rust-for-linux, linux-kernel, stable
From: Peder Bergan <peder.bergan@gmail.com>
With CONFIG_SCHEDSTATS disabled, struct sched_statistics is empty but
still cache-line aligned. Bindgen omits the alignment of the empty
type. Bindgen 0.73.2 also stopped forcing padding before over-aligned
fields, so fields following stats can be misplaced in the generated
task_struct. On the reported arm64 build, Rust Binder reads the wrong
pointer via CurrentTask::mm() and rejects mmap() with -EINVAL.
Make sched_statistics opaque so bindgen uses the C size and alignment.
Rust has no callers that access the fields of this type.
Reported-by: Jules Mercier <jules@les-mercier.fr>
Closes: https://github.com/Rust-for-Linux/linux/issues/1269
Link: https://github.com/rust-lang/rust-bindgen/issues/3549
Tested-by: Jules Mercier <jules@les-mercier.fr>
Cc: stable@vger.kernel.org # 6.12.x
Signed-off-by: Peder Bergan <peder.bergan@gmail.com>
---
Changes in v2
- Explain how the bindgen 0.73.2 padding change exposes the missing alignment.
- Link the bindgen bug and request stable backports starting with 6.12.x.
- Credit Jules Mercier's report and OnePlus 6T test, and expand the Binder Cc list.
I kept the opaque rule unconditional as discussed. On bindgen 0.73.1,
I found an offset mismatch at task_struct.se before sched_statistics.
I also checked an arm64 6.12.y build with bindgen 0.73.2 and schedstats
disabled. With the rule applied in the 6.12.y context, the Rust
task_struct.pid offset moved from 1208 to 1216, matching C.
v1 on lore.kernel.org
https://lore.kernel.org/rust-for-linux/20261119-fix-schedstats-bindgen-layout-v1-1-0599dd230ffd@gmail.com/
OpenAI Codex assisted with the bindgen change, validation and drafting.
---
rust/bindgen_parameters | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/rust/bindgen_parameters b/rust/bindgen_parameters
index 5bab3cf063360..65c308d4b603b 100644
--- a/rust/bindgen_parameters
+++ b/rust/bindgen_parameters
@@ -26,6 +26,12 @@
# warning. We don't need to peek into it anyway.
--opaque-type spinlock
+# Bindgen omits the alignment of empty structs. Bindgen 0.73.2 also stopped
+# forcing padding before over-aligned fields, so following fields can be
+# misplaced. Making sched_statistics opaque preserves its C alignment.
+# https://github.com/rust-lang/rust-bindgen/issues/3549
+--opaque-type sched_statistics
+
# enums that appear in indirect function calls should specify a cfi type
--newtype-enum fwctl_rpc_scope
--with-attribute-custom-enum=fwctl_rpc_scope='#[cfi_encoding="15fwctl_rpc_scope"]'
---
base-commit: aebb7274476403040d582c61478df8f4a7bf9cd3
change-id: 20261119-fix-schedstats-bindgen-layout-0935b6434707
Best regards,
--
Peder Bergan <peder.bergan@gmail.com>
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-11-20 17:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-20 17:19 [PATCH v2] rust: bindgen: Preserve sched_statistics alignment Peder Bergan via B4 Relay
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®