From: Christian Brauner <brauner@kernel.org>
To: ackerleytng@google.com, Alexey Kardashevskiy <aik@amd.com>,
"Aneesh Kumar K.V" <aneesh.kumar@kernel.org>,
David Hildenbrand <david@kernel.org>,
David Woodhouse <dwmw2@infradead.org>,
Fred Griffoul <fgriffo@amazon.co.uk>,
Jacob Pan <jacob.pan@linux.microsoft.com>,
Jianxiong Gao <jxgao@google.com>,
John Starks <John.Starks@microsoft.com>,
Michael Roth <michael.roth@amd.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Samiullah Khawaja <skhawaja@google.com>,
Sean Christopherson <seanjc@google.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Tarun Sahu <tarunsahu@google.com>,
Vishal Annapurve <vannapurve@google.com>,
Xu Yilun <yilun.xu@linux.intel.com>,
Fuad Tabba <fuad.tabba@linux.dev>
Cc: kvm@vger.kernel.org, linux-doc@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH RFC v3 03/88] mm: shmem: Implement guest_memfd provider operations for tmpfs
Date: Fri, 20 Nov 2026 09:52:04 +0100 [thread overview]
Message-ID: <20261120-provokant-zyklisch-schutt-55d8eddf2ce4@brauner> (raw)
In-Reply-To: <20261106-gmem-alternative-providers-v3-3-8484dde66a7e@google.com>
On Fri, Nov 06, 2026 at 04:36:37PM -0800, Ackerley Tng via B4 Relay wrote:
> I put guest_memfd_provider_operations as a pointer in struct
> file_operations. Being in file_operations generalizes well to other kinds
> of providers, like devices, which don't have their own super_operations.
> @@ -1960,6 +1961,9 @@ struct file_operations {
> int (*uring_cmd_iopoll)(struct io_uring_cmd *, struct io_comp_batch *,
> unsigned int poll_flags);
> int (*mmap_prepare)(struct vm_area_desc *);
> +#ifdef CONFIG_KVM_GUEST_MEMFD
> + const struct guest_memfd_provider_operations *gmem_provider_ops;
> +#endif
> } __randomize_layout;
Sorry, no! struct file_operations is not the place to hang KVM specific
callbacks off of. We didn't let KHO/LUO hang an ops table off of struct
file either and nobody else is getting one in file_operations.
LUO registers handlers that recognize their files by f_op instead,
memfd_luo just uses shmem_file(). And KVM already does the same for
VFIO: kvm_vfio_file_is_valid() -> vfio_file_is_valid(). Do the same for
providers and leave struct file_operations alone.
> Setting it in shmem_dir_operations allows directory file descriptors
> opened on a tmpfs mount to provide memory to guest_memfd.
That is weird. A directory fd is not an allocator handle. The folios
aren't backed by any inode in that tmpfs instance but they're charged
against its max_blocks. Which means statfs() shows space as used that no
file in the filesystem accounts for and that you can't get back by
removing files.
And also with CONFIG_KVM_GUEST_MEMFD every tmpfs directory on the system
gets its own file_operations just for this?
> +#ifdef CONFIG_KVM_GUEST_MEMFD
> + inode->i_fop = &shmem_dir_operations;
> +#else
> inode->i_fop = &simple_offset_dir_operations;
> +#endif
Afaict what you actually want from tmpfs is a mempolicyj a size limit
and noswap? guest_memfd already has a mempolicy. Teach guest_memfd the
rest instead of turning tmpfs mounts into a memory pool?
next prev parent reply other threads:[~2026-11-20 8:52 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 0:36 [PATCH RFC v3 00/88] guest_memfd alternative providers Ackerley Tng via B4 Relay
2026-11-07 0:36 ` [PATCH RFC v3 01/88] KVM: guest_memfd: Split folio allocation and insertion in kvm_gmem_get_folio Ackerley Tng via B4 Relay
2026-11-07 0:36 ` [PATCH RFC v3 02/88] KVM: guest_memfd: Route folio allocation through native provider operations Ackerley Tng via B4 Relay
2026-11-07 0:36 ` [PATCH RFC v3 03/88] mm: shmem: Implement guest_memfd provider operations for tmpfs Ackerley Tng via B4 Relay
2026-11-20 8:52 ` Christian Brauner [this message]
2026-11-20 14:34 ` Sean Christopherson
2026-11-07 0:36 ` [PATCH RFC v3 04/88] KVM: guest_memfd: Support provider folio invalidation Ackerley Tng via B4 Relay
2026-11-07 0:36 ` [PATCH RFC v3 05/88] KVM: guest_memfd: Support using resource provider Ackerley Tng via B4 Relay
2026-11-07 0:36 ` [PATCH RFC v3 06/88] KVM: selftests: Add helper to create guest_memfd with a resource file Ackerley Tng via B4 Relay
2026-11-07 0:36 ` [PATCH RFC v3 07/88] KVM: selftests: Test negative validation of resource_fd argument Ackerley Tng via B4 Relay
2026-11-07 0:36 ` [PATCH RFC v3 08/88] KVM: selftests: Test rejection of unsupported filesystem for resource_fd Ackerley Tng via B4 Relay
2026-11-07 0:36 ` [PATCH RFC v3 09/88] KVM: selftests: Test rejection of memfd " Ackerley Tng via B4 Relay
2026-11-07 0:36 ` [PATCH RFC v3 10/88] KVM: selftests: Test rejection of swap tmpfs mounts Ackerley Tng via B4 Relay
2026-11-07 0:36 ` [PATCH RFC v3 11/88] KVM: selftests: Test rejection of hugepage " Ackerley Tng via B4 Relay
2026-11-07 0:36 ` [PATCH RFC v3 12/88] KVM: selftests: Test rejection of regular file in tmpfs mount Ackerley Tng via B4 Relay
2026-11-07 0:36 ` [PATCH RFC v3 13/88] KVM: selftests: Test guest_memfd with tmpfs resource pool Ackerley Tng via B4 Relay
2026-11-07 0:36 ` [PATCH RFC v3 14/88] KVM: selftests: Test guest_memfd resource pool sharing across instances Ackerley Tng via B4 Relay
2026-11-07 0:36 ` [PATCH RFC v3 15/88] KVM: selftests: Test memory allocation against shared tmpfs resource pool Ackerley Tng via B4 Relay
2026-11-07 0:36 ` [PATCH RFC v3 16/88] KVM: selftests: Test that shared tmpfs resource pool size limit is respected Ackerley Tng via B4 Relay
2026-11-07 0:36 ` [PATCH RFC v3 17/88] KVM: selftests: Test guest execution with tmpfs-backed guest_memfd Ackerley Tng via B4 Relay
2026-11-07 0:36 ` [PATCH RFC v3 18/88] KVM: selftests: Document testing TODOs Ackerley Tng via B4 Relay
2026-11-07 0:36 ` [PATCH RFC v3 19/88] KVM: selftests: Test guest_memfd conversions with tmpfs backing Ackerley Tng via B4 Relay
2026-11-07 0:36 ` [PATCH RFC v3 20/88] samples/kvm: Introduce memory provider module skeleton Ackerley Tng via B4 Relay
2026-11-07 0:36 ` [PATCH RFC v3 21/88] samples/kvm: Support creating memory provider files Ackerley Tng via B4 Relay
2026-11-07 0:36 ` [PATCH RFC v3 22/88] samples/kvm: Support marking page ranges present or absent Ackerley Tng via B4 Relay
2026-11-07 0:36 ` [PATCH RFC v3 23/88] samples/kvm: Support marking page ranges read-only Ackerley Tng via B4 Relay
2026-11-07 0:36 ` [PATCH RFC v3 24/88] samples/kvm: Support querying provider file statistics Ackerley Tng via B4 Relay
2026-11-07 0:36 ` [PATCH RFC v3 25/88] KVM: selftests: Add basic test for sample memory provider Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 26/88] KVM: selftests: Test marking page ranges present and absent Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 27/88] KVM: selftests: Test marking page ranges read-only Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 28/88] KVM: guest_memfd: Support reporting PFN attributes Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 29/88] KVM: guest_memfd: Support getting PFNs for stage 2 from providers Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 30/88] KVM: guest_memfd: Refactor error handling in kvm_gmem_fault_user_mapping Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 31/88] KVM: guest_memfd: Set VM_PFNMAP on VMA in PFN mode Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 32/88] KVM: guest_memfd: Support user fault handling " Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 33/88] KVM: guest_memfd: Skip checking outstanding references " Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 34/88] KVM: guest_memfd: Support converting to shared " Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 35/88] KVM: guest_memfd: Support preallocating memory via fallocate " Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 36/88] KVM: guest_memfd: Clamp hole punch range to inode size Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 37/88] KVM: guest_memfd: Support reclaim during hole punch in PFN mode Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 38/88] KVM: guest_memfd: Support arch reclaim on inode destruction " Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 39/88] KVM: guest_memfd: Support put_pfn_range provider op " Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 40/88] KVM: guest_memfd: Add TODO for memory failure handling " Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 41/88] KVM: guest_memfd: Allow attaching PFN-backed providers Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 42/88] KVM: guest_memfd: Export kvm_gmem_revoke for provider-driven revocation Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 43/88] KVM: selftests: Test flag dependency of PFN_MODE on USE_RESOURCE Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 44/88] samples/kvm: Implement attach and release provider ops in sample provider Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 45/88] samples/kvm: Disallow MP_SET_READONLY after attach Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 46/88] samples/kvm: Implement get_pfn provider operation Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 47/88] samples/kvm: Implement put_pfn_range " Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 48/88] samples/kvm: Support dynamic revocation via kvm_gmem_revoke Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 49/88] samples/kvm: Implement lookup_pfn_range provider operation Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 50/88] KVM: selftests: Test guest_memfd conversions with sample memory provider backing Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 51/88] KVM: guest_memfd: Support reporting PFN cacheability Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 52/88] KVM: guest_memfd: Support mmap provider operation Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 53/88] KVM: guest_memfd: Support check_set_attributes " Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 54/88] KVM: guest_memfd: Support read and write operations and provider callbacks Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 55/88] vfio: Track device file access mode with an enum Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 56/88] vfio: Support VFIO_DEVICE_BIND_FLAG_CTRL_ONLY Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 57/88] vfio: Dispatch guest_memfd provider operations via vfio_device_ops Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 58/88] vfio/pci: Implement attach and release provider ops for guest_memfd Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 59/88] vfio: Dispatch guest_memfd get_pfn provider op via vfio_device_ops Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 60/88] vfio/pci: Implement get_pfn provider op for guest_memfd Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 61/88] vfio: Implement mmap " Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 62/88] vfio: Dispatch guest_memfd check_set_attributes via vfio_device_ops Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 63/88] vfio/pci: Implement check_set_attributes provider op for guest_memfd Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 64/88] vfio: Add vfio_device_gmem_revoke helper " Ackerley Tng via B4 Relay
2026-11-09 5:03 ` Aneesh Kumar K.V
2026-11-07 0:37 ` [PATCH RFC v3 65/88] vfio/pci: Revoke guest_memfd memory on BAR invalidation and reset Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 66/88] vfio: Dispatch guest_memfd lookup_pfn_range via vfio_device_ops Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 67/88] vfio/pci: Implement lookup_pfn_range provider op for guest_memfd Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 68/88] vfio/pci: Use iov_iter for MMIO read and write Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 69/88] vfio: Dispatch guest_memfd read and write provider ops via vfio_device_ops Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 70/88] vfio/pci: Introduce vfio_pci_bar_rw_kbuf for kernel buffer MMIO access Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 71/88] vfio/pci: Implement read and write provider ops for guest_memfd Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 72/88] KVM: selftests: Add initial VFIO test verifying device info Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 73/88] KVM: selftests: Verify VFIO region info for igb device Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 74/88] KVM: selftests: Verify VFIO IRQ " Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 75/88] KVM: selftests: Verify VFIO MMIO read and write " Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 76/88] KVM: selftests: Verify VFIO MMIO mmap access " Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 77/88] KVM: selftests: Verify VFIO device reset " Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 78/88] KVM: selftests: Verify VFIO access directly and via guest_memfd Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 79/88] KVM: selftests: Verify BAR revocation and access gating in low power state Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 80/88] KVM: selftests: Verify host VMA flags for VFIO BAR Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 81/88] KVM: selftests: Verify guest mapping " Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 82/88] KVM: selftests: Verify VFIO dmabuf creation for igb device Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 83/88] KVM: selftests: Verify VFIO ioeventfd " Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 84/88] KVM: selftests: Verify memory conversions for VFIO BARs Ackerley Tng via B4 Relay
2026-11-07 0:37 ` [PATCH RFC v3 85/88] KVM: selftests: Verify shared and private mmap access " Ackerley Tng via B4 Relay
2026-11-07 0:38 ` [PATCH RFC v3 86/88] KVM: selftests: Expect successful conversion on MSI-X BARs in VFIO test Ackerley Tng via B4 Relay
2026-11-07 0:38 ` [PATCH RFC v3 87/88] QUESTION: KVM: guest_memfd: Disallow private mappings of shared-only PFNs Ackerley Tng via B4 Relay
2026-11-09 5:37 ` Aneesh Kumar K.V
2026-11-07 0:38 ` [PATCH RFC v3 88/88] KVM: selftests: Verify shared and private pread and pwrite for VFIO BARs Ackerley Tng via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120-provokant-zyklisch-schutt-55d8eddf2ce4@brauner \
--to=brauner@kernel.org \
--cc=John.Starks@microsoft.com \
--cc=ackerleytng@google.com \
--cc=aik@amd.com \
--cc=aneesh.kumar@kernel.org \
--cc=david@kernel.org \
--cc=dwmw2@infradead.org \
--cc=fgriffo@amazon.co.uk \
--cc=fuad.tabba@linux.dev \
--cc=jacob.pan@linux.microsoft.com \
--cc=jxgao@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=skhawaja@google.com \
--cc=suzuki.poulose@arm.com \
--cc=tarunsahu@google.com \
--cc=vannapurve@google.com \
--cc=yilun.xu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®