mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v3 0/2] arm64: dts: allwinner: orangepi-zero2/zero3: Read the SPI NOR over two lines
@ 2026-11-20  6:30 Arun Iyengar via B4 Relay
  2026-11-20  6:30 ` [PATCH v3 1/2] arm64: dts: allwinner: orangepi-zero2/zero3: Set the SPI NOR supply by label Arun Iyengar via B4 Relay
  2026-11-20  6:30 ` [PATCH v3 2/2] arm64: dts: allwinner: orangepi-zero2/zero3: Read the SPI NOR over two lines Arun Iyengar via B4 Relay
  0 siblings, 2 replies; 3+ messages in thread
From: Arun Iyengar via B4 Relay @ 2026-11-20  6:30 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
	Jernej Skrabec, Samuel Holland
  Cc: Andre Przywara, devicetree, linux-arm-kernel, linux-sunxi,
	linux-kernel, Arun Iyengar

Andre Przywara reviewed v1 and suggested labelling the flash node (patch
1) and setting spi-rx-bus-width in the dtsi shared with the Zero3 (patch 2).

spi-rx-bus-width = <2> needs the binding patch of [1] (acked, not applied
yet) to pass dtbs_check.
Without the driver patch of [1] the driver ignores the setting.

Tested on an Orange Pi Zero2, with [1]: 1-1-2 reads (opcode 0x3b),
two 2 MiB reads identical to an earlier dump.

[1] https://lore.kernel.org/r/20261116-spi-sun6i-h616-dual-read-v2-0-e0c66eb71e20@gmail.com

Developed with Claude (Anthropic), which wrote the patches and commit
messages. I reviewed them.

---
Changes in v3:
- Label renamed to spi_flash (Andre)
- Zero3 flash supply added (Andre): reg_dldo1, see the note in patch 1
- Zero2 &spi_flash moved after &pio (sorted)
- Dropped Suggested-by on patch 2, added Andre's tags
- Link to v2: https://patch.msgid.link/20261119-zero2-spi-nor-dual-read-v2-0-185c87065e39@gmail.com

Changes in v2:
- Label the flash node, no nested &spi0 override (Andre)
- spi-rx-bus-width moved to the shared dtsi, Zero3 included (Andre;
  he read 16 MB on a Zero3 in 1.8 s instead of 3.5 s)
- Dropped the driver dependency (Andre); the binding is still needed for dtbs_check
- Link to v1: https://patch.msgid.link/20261118-zero2-spi-nor-dual-read-v1-1-bcdcbf785be0@gmail.com

---
Arun Iyengar (2):
      arm64: dts: allwinner: orangepi-zero2/zero3: Set the SPI NOR supply by label
      arm64: dts: allwinner: orangepi-zero2/zero3: Read the SPI NOR over two lines

 arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero.dtsi | 3 ++-
 arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dts | 6 ++----
 arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero3.dts | 4 ++++
 3 files changed, 8 insertions(+), 5 deletions(-)
---
base-commit: 90e0d3fd460ec365617982b56bd7ea5179b36197
change-id: 20261115-zero2-spi-nor-dual-read-645a6de25e81
prerequisite-patch-id: 28b145097d0f859e5bd27bcc5028d0915f3ba4bd

Best regards,
--  
Arun Iyengar <aiyengar1990@gmail.com>



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v3 1/2] arm64: dts: allwinner: orangepi-zero2/zero3: Set the SPI NOR supply by label
  2026-11-20  6:30 [PATCH v3 0/2] arm64: dts: allwinner: orangepi-zero2/zero3: Read the SPI NOR over two lines Arun Iyengar via B4 Relay
@ 2026-11-20  6:30 ` Arun Iyengar via B4 Relay
  2026-11-20  6:30 ` [PATCH v3 2/2] arm64: dts: allwinner: orangepi-zero2/zero3: Read the SPI NOR over two lines Arun Iyengar via B4 Relay
  1 sibling, 0 replies; 3+ messages in thread
From: Arun Iyengar via B4 Relay @ 2026-11-20  6:30 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
	Jernej Skrabec, Samuel Holland
  Cc: Andre Przywara, devicetree, linux-arm-kernel, linux-sunxi,
	linux-kernel, Arun Iyengar

From: Arun Iyengar <aiyengar1990@gmail.com>

Label the flash node in the shared dtsi, so each board sets its supply
through the label. The Zero2 keeps reg_aldo1. On the Zero3 the flash VDD
is on the 3.3V rail from the AXP313A DLDO1 pin (schematic v1.2), so it
gets reg_dldo1.

Suggested-by: Andre Przywara <andre.przywara@arm.com>
Signed-off-by: Arun Iyengar <aiyengar1990@gmail.com>
---
Andre: reg_dldo1 instead of reg_aldo1 on the Zero3. Schematic v1.2
sheet 4 labels the 3.3V net "ALDO1", but it comes from AXP313A pin 12
(DLDO1, VCC33-DLDO); pin 15 (ALDO1) is the 1.8V VCC18-ALDO. The flash
VDD (U61 pin 8, net DCDCE) is on that 3.3V net. Not tested, no Zero3
here.
---
 arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero.dtsi | 2 +-
 arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dts | 6 ++----
 arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero3.dts | 4 ++++
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero.dtsi
index 0d3e761f6466..cd1f67ad7c2b 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero.dtsi
@@ -104,7 +104,7 @@ &spi0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&spi0_pins>, <&spi0_cs0_pin>;
 
-	flash@0 {
+	spi_flash: flash@0 {
 		#address-cells = <1>;
 		#size-cells = <1>;
 		compatible = "jedec,spi-nor";
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dts
index 90c25e12e189..2f8a16d1c9aa 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dts
@@ -148,8 +148,6 @@ &pio {
 	vcc-pi-supply = <&reg_aldo1>;
 };
 
-&spi0 {
-	flash@0 {
-		vcc-supply = <&reg_aldo1>;
-	};
+&spi_flash {
+	vcc-supply = <&reg_aldo1>;
 };
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero3.dts b/arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero3.dts
index c51d4d9120de..afa753dead30 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero3.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h618-orangepi-zero3.dts
@@ -103,3 +103,7 @@ &pio {
 	vcc-ph-supply = <&reg_dldo1>;
 	vcc-pi-supply = <&reg_dldo1>;
 };
+
+&spi_flash {
+	vcc-supply = <&reg_dldo1>;
+};

-- 
2.55.0



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v3 2/2] arm64: dts: allwinner: orangepi-zero2/zero3: Read the SPI NOR over two lines
  2026-11-20  6:30 [PATCH v3 0/2] arm64: dts: allwinner: orangepi-zero2/zero3: Read the SPI NOR over two lines Arun Iyengar via B4 Relay
  2026-11-20  6:30 ` [PATCH v3 1/2] arm64: dts: allwinner: orangepi-zero2/zero3: Set the SPI NOR supply by label Arun Iyengar via B4 Relay
@ 2026-11-20  6:30 ` Arun Iyengar via B4 Relay
  1 sibling, 0 replies; 3+ messages in thread
From: Arun Iyengar via B4 Relay @ 2026-11-20  6:30 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
	Jernej Skrabec, Samuel Holland
  Cc: Andre Przywara, devicetree, linux-arm-kernel, linux-sunxi,
	linux-kernel, Arun Iyengar

From: Arun Iyengar <aiyengar1990@gmail.com>

WP# and HOLD# are tied to VCC on the Zero2 (schematic v1.3), so read over
two lines. Andre Przywara pointed out that the Zero3 is the same.

Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Tested-by: Andre Przywara <andre.przywara@arm.com>
Signed-off-by: Arun Iyengar <aiyengar1990@gmail.com>
---
 arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero.dtsi
index cd1f67ad7c2b..de05cbbd2cae 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero.dtsi
@@ -110,6 +110,7 @@ spi_flash: flash@0 {
 		compatible = "jedec,spi-nor";
 		reg = <0>;
 		spi-max-frequency = <40000000>;
+		spi-rx-bus-width = <2>;
 	};
 };
 

-- 
2.55.0



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-20  6:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-20  6:30 [PATCH v3 0/2] arm64: dts: allwinner: orangepi-zero2/zero3: Read the SPI NOR over two lines Arun Iyengar via B4 Relay
2026-11-20  6:30 ` [PATCH v3 1/2] arm64: dts: allwinner: orangepi-zero2/zero3: Set the SPI NOR supply by label Arun Iyengar via B4 Relay
2026-11-20  6:30 ` [PATCH v3 2/2] arm64: dts: allwinner: orangepi-zero2/zero3: Read the SPI NOR over two lines Arun Iyengar via B4 Relay

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®