* [PATCH] io_uring/net: don't charge the folio offset to truesize for managed frags
@ 2026-11-19 23:29 Louis Thiery
2026-11-20 0:11 ` Brian Martin
0 siblings, 1 reply; 2+ messages in thread
From: Louis Thiery @ 2026-11-19 23:29 UTC (permalink / raw)
To: Jens Axboe; +Cc: io-uring, Pavel Begunkov, linux-kernel, Louis Thiery, stable
Registered buffers backed by huge pages are coalesced into one bvec per
folio, so bv_offset is relative to the folio, not to a 4K page.
io_sg_from_iter() adds PAGE_ALIGN(bv_len + bv_offset) to the skb
truesize, which charges the socket for the whole run-up inside the
folio. A 64K send from 1.5MB into a 2MB THP folio adds about 1.6MB of
truesize, and sk_wmem_queued fills long before any real memory is used.
The visible effect is a socket that looks full: with a 2MB send buffer
only 4 of 128 queued 64K sends complete before the sender blocks,
versus 30 of 128 with the same buffer registered as 4K pages, and most
pipelined send_zc requests come back short.
Only the in-page part of the offset matters for how much memory a
fragment ties up, so use offset_in_page(). This matches what
zerocopy_fill_skb_from_iter() charges for the same data.
Fixes: 57bebf807e2a ("io_uring/rsrc: optimise registered huge pages")
Cc: stable@vger.kernel.org
Signed-off-by: Louis Thiery <thiery.louis@gmail.com>
---
io_uring/net.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/io_uring/net.c b/io_uring/net.c
index 533afd335..8afad1b2d 100644
--- a/io_uring/net.c
+++ b/io_uring/net.c
@@ -1501,7 +1501,12 @@ static int io_sg_from_iter(struct sk_buff *skb,
struct bio_vec v = mp_bvec_iter_bvec(from->bvec, bi);
copied += v.bv_len;
- truesize += PAGE_ALIGN(v.bv_len + v.bv_offset);
+ /*
+ * bv_offset is relative to the folio for coalesced huge page
+ * registrations, so only the in-page part of it matters for
+ * how much memory this fragment ties up.
+ */
+ truesize += PAGE_ALIGN(v.bv_len + offset_in_page(v.bv_offset));
__skb_fill_page_desc_noacc(shinfo, frag++, v.bv_page,
v.bv_offset, v.bv_len);
bvec_iter_advance_single(from->bvec, &bi, v.bv_len);
base-commit: 0659e44ce739ecd856164c75a5325b7959a2921d
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] io_uring/net: don't charge the folio offset to truesize for managed frags
2026-11-19 23:29 [PATCH] io_uring/net: don't charge the folio offset to truesize for managed frags Louis Thiery
@ 2026-11-20 0:11 ` Brian Martin
0 siblings, 0 replies; 2+ messages in thread
From: Brian Martin @ 2026-11-20 0:11 UTC (permalink / raw)
To: Louis Thiery, Jens Axboe; +Cc: io-uring, Pavel Begunkov, linux-kernel, stable
On Thu, 19 Nov 2026 23:29:35 +0000, Louis Thiery wrote:
> Only the in-page part of the offset matters for how much memory a
> fragment ties up, so use offset_in_page().
This is the change suggested in my report earlier today:
https://lore.kernel.org/io-uring/CAC+fX10wVVSqGnfCg+aazorsCxB34sUDV-XJiBPd6R3Kuqc-7Q@mail.gmail.com/
I applied this patch to io_uring-7.4 (0659e44ce739) and ran the
reproducer from that report. With it, SEND_ZC from a registered huge-page
buffer is charged the same as SEND_ZC without one on every row, for
hugetlb and THP, including 8192 for a send that crosses a page boundary.
On the stock kernel the same run shows the overcharge.
Jens, if you apply this, could you add:
Reported-by: Brian Martin <brayniac@gmail.com>
Closes: https://lore.kernel.org/io-uring/CAC+fX10wVVSqGnfCg+aazorsCxB34sUDV-XJiBPd6R3Kuqc-7Q@mail.gmail.com/
Tested-by: Brian Martin <brayniac@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-20 0:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-19 23:29 [PATCH] io_uring/net: don't charge the folio offset to truesize for managed frags Louis Thiery
2026-11-20 0:11 ` Brian Martin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®