mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] fs/resctrl: Use open-time credentials for task move permission checks
@ 2026-11-20  9:00 Hungyu Lin
  0 siblings, 0 replies; only message in thread
From: Hungyu Lin @ 2026-11-20  9:00 UTC (permalink / raw)
  To: tony.luck, reinette.chatre
  Cc: x86, Dave.Martin, james.morse, babu.moger, ben.horgan, fustini,
	tglx, fenghua.yu, josef, linux-kernel, dennylin0707

Writing a PID to a resctrl group's "tasks" file moves that task into the
group. Whether the move is allowed depends on the PID written, so
rdtgroup_task_write_permission() checks it at write time, applying the
same cred_ids_allow_move() rule as __cgroup1_procs_write().

It checks current's credentials. That may allow a less privileged
process to trick a more privileged one into writing into a fd that it
opened. Commit 1756d7994ad8 ("cgroup: Use open-time credentials for
process migraton perm checks") closed the same hole in cgroup by using
the credentials saved at open time. rdtgroup_task_write_permission()
still uses current_cred().

Use of->file->f_cred instead, as cgroup1 does.

Fixes: e02737d5b826 ("x86/intel_rdt: Add tasks files")
Cc: stable@vger.kernel.org
Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
v2:
- Rebased onto commit 27369da9c651 ("fs/resctrl: use
  cred_ids_allow_move()") in linux-next.
- Dropped the comment change.

v1: https://lore.kernel.org/all/20261107093253.62518-1-dennylin0707@gmail.com/

 fs/resctrl/rdtgroup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/resctrl/rdtgroup.c b/fs/resctrl/rdtgroup.c
index 6e81b58e4cb8..c9b35fc2b513 100644
--- a/fs/resctrl/rdtgroup.c
+++ b/fs/resctrl/rdtgroup.c
@@ -725,7 +725,7 @@ static int rdtgroup_task_write_permission(struct task_struct *task,
 					  struct kernfs_open_file *of)
 {
 	const struct cred *tcred = get_task_cred(task);
-	const struct cred *cred = current_cred();
+	const struct cred *cred = of->file->f_cred;
 	int ret = 0;
 
 	/*
-- 
2.43.0

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-11-20  9:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-20  9:00 [PATCH v2] fs/resctrl: Use open-time credentials for task move permission checks Hungyu Lin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®