* [PATCH v2 0/2] ASoC: atmel: Mark interrupt registers as volatile
@ 2026-11-20 10:46 phucduc.bui
2026-11-20 10:46 ` [PATCH v2 1/2] ASoC: atmel: mchp-pdmc: Mark IMR " phucduc.bui
2026-11-20 10:46 ` [PATCH v2 2/2] ASoC: atmel: mchp-spdiftx: Mark interrupt registers " phucduc.bui
0 siblings, 2 replies; 3+ messages in thread
From: phucduc.bui @ 2026-11-20 10:46 UTC (permalink / raw)
To: Mark Brown, Claudiu Beznea, Andrei Simion, Nicolas Ferre,
Alexandre Belloni
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Codrin Ciubotariu,
linux-sound, linux-arm-kernel, linux-kernel, bui duc phuc
From: bui duc phuc <phucduc.bui@gmail.com>
Hi all,
This series marks the interrupt mask and status registers as volatile
in the PDMC and SPDIFTX drivers to ensure they are read from hardware.
Link v1:
https://lore.kernel.org/all/20261120100408.8053-1-phucduc.bui@gmail.com/
Change in v2:
- Update the Fixes tag based on Sashiko's review.
Compile-tested only.
Best regards,
Phuc
bui duc phuc (2):
ASoC: atmel: mchp-pdmc: Mark IMR as volatile
ASoC: atmel: mchp-spdiftx: Mark interrupt registers as volatile
sound/soc/atmel/mchp-pdmc.c | 1 +
sound/soc/atmel/mchp-spdiftx.c | 12 ++++++++++++
2 files changed, 13 insertions(+)
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2 1/2] ASoC: atmel: mchp-pdmc: Mark IMR as volatile
2026-11-20 10:46 [PATCH v2 0/2] ASoC: atmel: Mark interrupt registers as volatile phucduc.bui
@ 2026-11-20 10:46 ` phucduc.bui
2026-11-20 10:46 ` [PATCH v2 2/2] ASoC: atmel: mchp-spdiftx: Mark interrupt registers " phucduc.bui
1 sibling, 0 replies; 3+ messages in thread
From: phucduc.bui @ 2026-11-20 10:46 UTC (permalink / raw)
To: Mark Brown, Claudiu Beznea, Andrei Simion, Nicolas Ferre,
Alexandre Belloni
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Codrin Ciubotariu,
linux-sound, linux-arm-kernel, linux-kernel, bui duc phuc
From: bui duc phuc <phucduc.bui@gmail.com>
The interrupt handler reads ISR and IMR to determine which interrupts
are pending. While ISR is marked as volatile, IMR is not, causing
regmap to return its cached value instead of reading the hardware.
Add IMR to the volatile registers.
Fixes: c5682e2ba132 ("ASoC: mchp-pdmc: fix poc noise at capture startup")
Fixes: e8c8e9de4ee3 ("ASoC: mchp-pdmc: use runtime pm for clock power saving")
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
Change in v2:
- Update the Fixes tag based on Sashiko's review.
sound/soc/atmel/mchp-pdmc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/atmel/mchp-pdmc.c b/sound/soc/atmel/mchp-pdmc.c
index 8b55d864f3d5..4b380dc8b6cf 100644
--- a/sound/soc/atmel/mchp-pdmc.c
+++ b/sound/soc/atmel/mchp-pdmc.c
@@ -842,6 +842,7 @@ static bool mchp_pdmc_volatile_reg(struct device *dev, unsigned int reg)
{
switch (reg) {
case MCHP_PDMC_ISR:
+ case MCHP_PDMC_IMR:
case MCHP_PDMC_RHR:
return true;
default:
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH v2 2/2] ASoC: atmel: mchp-spdiftx: Mark interrupt registers as volatile
2026-11-20 10:46 [PATCH v2 0/2] ASoC: atmel: Mark interrupt registers as volatile phucduc.bui
2026-11-20 10:46 ` [PATCH v2 1/2] ASoC: atmel: mchp-pdmc: Mark IMR " phucduc.bui
@ 2026-11-20 10:46 ` phucduc.bui
1 sibling, 0 replies; 3+ messages in thread
From: phucduc.bui @ 2026-11-20 10:46 UTC (permalink / raw)
To: Mark Brown, Claudiu Beznea, Andrei Simion, Nicolas Ferre,
Alexandre Belloni
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Codrin Ciubotariu,
linux-sound, linux-arm-kernel, linux-kernel, bui duc phuc
From: bui duc phuc <phucduc.bui@gmail.com>
The interrupt handler reads ISR and IMR to determine which interrupts
are pending. Neither register is marked as volatile, causing regmap
to return cached values instead of reading the hardware.
Add a volatile_reg callback marking IMR and ISR as volatile.
Fixes: 4bf54ca60f99 ("ASoC: mchp-spdiftx: add runtime pm support")
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
Change in v2:
- Update the Fixes tag based on Sashiko's review.
sound/soc/atmel/mchp-spdiftx.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/sound/soc/atmel/mchp-spdiftx.c b/sound/soc/atmel/mchp-spdiftx.c
index 658ff667439c..0406a11caf7d 100644
--- a/sound/soc/atmel/mchp-spdiftx.c
+++ b/sound/soc/atmel/mchp-spdiftx.c
@@ -165,6 +165,17 @@ static bool mchp_spdiftx_precious_reg(struct device *dev, unsigned int reg)
}
}
+static bool mchp_spdiftx_volatile_reg(struct device *dev, unsigned int reg)
+{
+ switch (reg) {
+ case SPDIFTX_IMR:
+ case SPDIFTX_ISR:
+ return true;
+ default:
+ return false;
+ }
+}
+
static const struct regmap_config mchp_spdiftx_regmap_config = {
.reg_bits = 32,
.reg_stride = 4,
@@ -173,6 +184,7 @@ static const struct regmap_config mchp_spdiftx_regmap_config = {
.readable_reg = mchp_spdiftx_readable_reg,
.writeable_reg = mchp_spdiftx_writeable_reg,
.precious_reg = mchp_spdiftx_precious_reg,
+ .volatile_reg = mchp_spdiftx_volatile_reg,
.cache_type = REGCACHE_FLAT,
};
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-20 10:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-20 10:46 [PATCH v2 0/2] ASoC: atmel: Mark interrupt registers as volatile phucduc.bui
2026-11-20 10:46 ` [PATCH v2 1/2] ASoC: atmel: mchp-pdmc: Mark IMR " phucduc.bui
2026-11-20 10:46 ` [PATCH v2 2/2] ASoC: atmel: mchp-spdiftx: Mark interrupt registers " phucduc.bui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®