* [PATCH] staging: octeon: Align function parameters
@ 2026-11-15 13:54 S Tarun Kumar Lywait
2026-11-20 7:19 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: S Tarun Kumar Lywait @ 2026-11-15 13:54 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, S Tarun Kumar Lywait
Align the function parameters to the open parantheis and change the parameter "pko_command" to "pko_cmd", so that it doesn't exceed Col 100.
Issue reported by checkpatch:
CHECK: Alignment should match open parenthesis
Signed-off-by: S Tarun Kumar Lywait <tarun.k.lywait@gmail.com>
---
drivers/staging/octeon/octeon-stubs.h | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
index 9c1968b7e..cc1204e20 100644
--- a/drivers/staging/octeon/octeon-stubs.h
+++ b/drivers/staging/octeon/octeon-stubs.h
@@ -1387,8 +1387,10 @@ static inline void cvmx_pko_send_packet_prepare(u64 port, u64 queue,
{ }
static inline enum cvmx_pko_status cvmx_pko_send_packet_finish(u64 port,
- u64 queue, union cvmx_pko_command_word0 pko_command,
- union cvmx_buf_ptr packet, enum cvmx_pko_lock use_locking)
+ u64 queue,
+ union cvmx_pko_command_word0 pko_cmd,
+ union cvmx_buf_ptr packet,
+ enum cvmx_pko_lock use_locking)
{
return 0;
}
--
2.47.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: octeon: Align function parameters
2026-11-15 13:54 [PATCH] staging: octeon: Align function parameters S Tarun Kumar Lywait
@ 2026-11-20 7:19 ` Greg KH
2026-11-20 13:35 ` Tarun Kumar Lywait
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2026-11-20 7:19 UTC (permalink / raw)
To: S Tarun Kumar Lywait; +Cc: linux-staging, linux-kernel
On Sun, Nov 15, 2026 at 07:24:13PM +0530, S Tarun Kumar Lywait wrote:
> Align the function parameters to the open parantheis and change the parameter "pko_command" to "pko_cmd", so that it doesn't exceed Col 100.
But this line does :(
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: octeon: Align function parameters
2026-11-20 7:19 ` Greg KH
@ 2026-11-20 13:35 ` Tarun Kumar Lywait
2026-11-20 13:39 ` [PATCH v2] " S Tarun Kumar Lywait
0 siblings, 1 reply; 4+ messages in thread
From: Tarun Kumar Lywait @ 2026-11-20 13:35 UTC (permalink / raw)
To: Greg KH; +Cc: linux-staging, linux-kernel
On Fri, Nov 20, 2026 at 12:49 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Sun, Nov 15, 2026 at 07:24:13PM +0530, S Tarun Kumar Lywait wrote:
> > Align the function parameters to the open parantheis and change the parameter "pko_command" to "pko_cmd", so that it doesn't exceed Col 100.
>
> But this line does :(
>
Hi,
I am sending a v2 patch with the correction you mentioned.
Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] staging: octeon: Align function parameters
2026-11-20 13:35 ` Tarun Kumar Lywait
@ 2026-11-20 13:39 ` S Tarun Kumar Lywait
0 siblings, 0 replies; 4+ messages in thread
From: S Tarun Kumar Lywait @ 2026-11-20 13:39 UTC (permalink / raw)
To: tarun.k.lywait; +Cc: gregkh, linux-kernel, linux-staging
Align the function parameters to the open paranthesis and change the
parameter "pko_command" to "pko_cmd", so that it doesn't exceed Col 100.
Issue reported by checkpatch:
CHECK: Alignment should match open parenthesis
Signed-off-by: S Tarun Kumar Lywait <tarun.k.lywait@gmail.com>
---
drivers/staging/octeon/octeon-stubs.h | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
index 9c1968b7e..cc1204e20 100644
--- a/drivers/staging/octeon/octeon-stubs.h
+++ b/drivers/staging/octeon/octeon-stubs.h
@@ -1387,8 +1387,10 @@ static inline void cvmx_pko_send_packet_prepare(u64 port, u64 queue,
{ }
static inline enum cvmx_pko_status cvmx_pko_send_packet_finish(u64 port,
- u64 queue, union cvmx_pko_command_word0 pko_command,
- union cvmx_buf_ptr packet, enum cvmx_pko_lock use_locking)
+ u64 queue,
+ union cvmx_pko_command_word0 pko_cmd,
+ union cvmx_buf_ptr packet,
+ enum cvmx_pko_lock use_locking)
{
return 0;
}
--
2.47.3
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-11-20 13:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-15 13:54 [PATCH] staging: octeon: Align function parameters S Tarun Kumar Lywait
2026-11-20 7:19 ` Greg KH
2026-11-20 13:35 ` Tarun Kumar Lywait
2026-11-20 13:39 ` [PATCH v2] " S Tarun Kumar Lywait
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®