mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Valentin Schneider <vschneid@redhat.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	K Prateek Nayak <kprateek.nayak@amd.com>
Subject: Re: [PATCH] sched/fair: Don't let task_tick_cache() IPI dyntick CPUs
Date: Fri, 20 Nov 2026 16:40:15 +0100	[thread overview]
Message-ID: <20261120154015.GY2668564@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <xhsmhv75rojdy.mognet@vschneid-thinkpadt14sgen2i.remote.csb>

On Fri, Nov 20, 2026 at 12:02:49PM +0100, Valentin Schneider wrote:
> > +	/*
> > +	 * If there is no root domain; there is no balancing, and none of this
> > +	 * matters.
> > +	 */
> > +	if (!rq->rd)
> > +		return;
> > +
> 
> What if the setup involves a separate root domain where all the CPUs are in
> dynticks mode?
> 
> Methinks the signal we want is:
> 
>   is that task on a NOHZ_FULL CPU with the tick disabled?
> 
> If so then we shouldn't do anything about it. Let the other CPUs in its LLC
> / RD run some balancing. If they're all dynticks, well then there is
> nothing to do is there?
> 
> And that should also apply to the NUMA stuff like you pointed out.

If you have a root domain with more than 1 CPU in it, you get balancing,
deal with it.

      reply	other threads:[~2026-11-20 15:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 20:38 Valentin Schneider
2026-11-20  8:34 ` Peter Zijlstra
2026-11-20 11:02   ` Valentin Schneider
2026-11-20 15:40     ` Peter Zijlstra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120154015.GY2668564@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®