From: Valentin Schneider <vschneid@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
K Prateek Nayak <kprateek.nayak@amd.com>
Subject: Re: [PATCH] sched/fair: Don't let task_tick_cache() IPI dyntick CPUs
Date: Fri, 20 Nov 2026 12:02:49 +0100 [thread overview]
Message-ID: <xhsmhv75rojdy.mognet@vschneid-thinkpadt14sgen2i.remote.csb> (raw)
In-Reply-To: <20261120083440.GL2668564@noisy.programming.kicks-ass.net>
On 20/11/26 09:34, Peter Zijlstra wrote:
> On Thu, Nov 19, 2026 at 09:38:25PM +0100, Valentin Schneider wrote:
>> @@ -1925,6 +1925,13 @@ static void task_tick_cache(struct rq *rq, struct task_struct *p)
>> !grp->pcpu_sched)
>> return;
>>
>> + /*
>> + * We got here from a sched_tick_remote(), meaning @p is making use of
>> + * NOHZ_FULL. Don't disturb it with a task_work() IPI.
>> + */
>> + if (cpu_of(rq) != smp_processor_id())
>> + return;
>> +
>> epoch = rq->cpu_epoch;
>> /* avoid moving backwards */
>> if (time_after_eq(grp->epoch, epoch))
>
>
> Its early, and I definitely need more wake-up juice, but how is
> task_tick_numa() different here?
>
It shouldn't be too different, I just can't get it to trigger on my QEMU
setup; I'm done running stuff on the machine I caught this on so I can
start digging there.
> @@ -15401,15 +15404,20 @@ static void task_tick_fair(struct rq *rq, struct task_struct *curr, int hrtick)
> if (hrtick)
> return;
>
> - if (static_branch_unlikely(&sched_numa_balancing))
> - task_tick_numa(rq, curr);
> + task_tick_core(rq, curr);
>
> + /*
> + * If there is no root domain; there is no balancing, and none of this
> + * matters.
> + */
> + if (!rq->rd)
> + return;
> +
What if the setup involves a separate root domain where all the CPUs are in
dynticks mode?
Methinks the signal we want is:
is that task on a NOHZ_FULL CPU with the tick disabled?
If so then we shouldn't do anything about it. Let the other CPUs in its LLC
/ RD run some balancing. If they're all dynticks, well then there is
nothing to do is there?
And that should also apply to the NUMA stuff like you pointed out.
> + task_tick_numa(rq, curr);
> task_tick_cache(rq, curr);
>
> update_misfit_status(curr, rq);
> check_update_overutilized_status(task_rq(curr));
> -
> - task_tick_core(rq, curr);
> }
>
> /*
next prev parent reply other threads:[~2026-11-20 11:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 20:38 Valentin Schneider
2026-11-20 8:34 ` Peter Zijlstra
2026-11-20 11:02 ` Valentin Schneider [this message]
2026-11-20 15:40 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xhsmhv75rojdy.mognet@vschneid-thinkpadt14sgen2i.remote.csb \
--to=vschneid@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®