mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Madhavan Ganesan <madhavan.ganesan@oss.qualcomm.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Jeff Johnson <jjohnson@kernel.org>,
	 Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	 Bill Wendling <morbo@google.com>,
	Justin Stitt <justinstitt@google.com>,
	 linux-wireless@vger.kernel.org, devicetree@vger.kernel.org,
	ath12k@lists.infradead.org,  linux-kernel@vger.kernel.org,
	llvm@lists.linux.dev
Subject: Re: [PATCH ath-next v3 15/15] wifi: ath12k: add Wi-Fi 8 PCI driver scaffolding for QCN9575
Date: Sat, 21 Nov 2026 13:28:16 +0100	[thread overview]
Message-ID: <20261121-astute-calculating-hippogriff-69ecfc@quoll> (raw)
In-Reply-To: <20261118-wifi8_qcn9575_bringup-v3-15-9875d2a3953f@oss.qualcomm.com>

On Wed, Nov 18, 2026 at 01:45:38PM +0530, Madhavan Ganesan wrote:
> Add QCN9575 PCI window register constants (WINDOW_VALUE_MASK [25:19],
> WINDOW_STATIC_MASK [31:7], CE_WINDOW_MASK [13:7], UMAC_WINDOW_MASK
> [20:14]) and a Wi-Fi 8 reg_base instance (ath12k_wifi8_reg_base) for
> per-device window selection. Implement ath12k_wifi8_pci_probe() to
> configure QCN9575-specific PCI settings: MSI vector layout (3 MHI, 5 CE,
> 8 DP vectors), static window mapping, window register address (0x3278),
> and hardware revision. Call ath12k_wifi8_hw_init() at the end of probe
> to complete hardware initialization. Define the Wi-Fi 8 PCI driver
> struct with the probe callback, and register it with
> ath12k_pci_register_driver() in ath12k_wifi8_pci_init().
> 
> This series only adds Wi-Fi 8 platform scaffolding; QCN9575's CP, DP,
> and MAC datapath support will be posted as a follow-up series.
> QCN9575_DEVICE_ID is intentionally left out of
> ath12k_wifi8_pci_id_table for now, so no physical device can match and
> probe until that follow-up series lands. The id_table entry will be
> added in the final patch of that series, once QCN9575 is actually
> functional.
> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01243-QCAHKSWPL_SILICONZ-1
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3
> 
> Signed-off-by: Madhavan Ganesan <madhavan.ganesan@oss.qualcomm.com>
> ---
>  drivers/net/wireless/ath/ath12k/hal.h       |  2 +
>  drivers/net/wireless/ath/ath12k/wifi7/hal.h |  2 -
>  drivers/net/wireless/ath/ath12k/wifi8/hal.h |  1 +
>  drivers/net/wireless/ath/ath12k/wifi8/pci.c | 89 ++++++++++++++++++++++++++++-
>  4 files changed, 91 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath12k/hal.h b/drivers/net/wireless/ath/ath12k/hal.h
> index 9e88bdf4a93b..b30a8039b2ec 100644
> --- a/drivers/net/wireless/ath/ath12k/hal.h
> +++ b/drivers/net/wireless/ath/ath12k/hal.h
> @@ -11,6 +11,8 @@
>  
>  struct ath12k_base;
>  
> +#define HAL_CE_WFSS_CE_REG_BASE			0x01b80000
> +
>  #define HAL_DESC_REO_NON_QOS_TID	16
>  
>  #define HAL_INVALID_PEERID	0x3fff
> diff --git a/drivers/net/wireless/ath/ath12k/wifi7/hal.h b/drivers/net/wireless/ath/ath12k/wifi7/hal.h
> index 19e02bb16ff2..fe880b0befcb 100644
> --- a/drivers/net/wireless/ath/ath12k/wifi7/hal.h
> +++ b/drivers/net/wireless/ath/ath12k/wifi7/hal.h
> @@ -31,8 +31,6 @@
>  	((hal)->regs->umac_ce1_dest_reg_base)
>  #define HAL_SEQ_WCSS_UMAC_WBM_REG		0x00a34000
>  
> -#define HAL_CE_WFSS_CE_REG_BASE			0x01b80000
> -
>  #define HAL_TCL_SW_CONFIG_BANK_ADDR		0x00a4408c
>  
>  /* SW2TCL(x) R0 ring configuration address */
> diff --git a/drivers/net/wireless/ath/ath12k/wifi8/hal.h b/drivers/net/wireless/ath/ath12k/wifi8/hal.h
> index c99521abdcb3..89fa9a7f3fd9 100644
> --- a/drivers/net/wireless/ath/ath12k/wifi8/hal.h
> +++ b/drivers/net/wireless/ath/ath12k/wifi8/hal.h
> @@ -11,6 +11,7 @@
>  #include "hal_desc.h"
>  
>  /* WCSS Relative address */
> +#define HAL_SEQ_WCSS_UMAC_OFFSET		0xf00000
>  #define HAL_SEQ_WCSS_UMAC_CE0_SRC_REG(hal) \
>  	((hal)->regs->umac_ce0_src_reg_base)
>  #define HAL_SEQ_WCSS_UMAC_CE0_DST_REG(hal) \
> diff --git a/drivers/net/wireless/ath/ath12k/wifi8/pci.c b/drivers/net/wireless/ath/ath12k/wifi8/pci.c
> index 3975081d167b..fd0489f8333f 100644
> --- a/drivers/net/wireless/ath/ath12k/wifi8/pci.c
> +++ b/drivers/net/wireless/ath/ath12k/wifi8/pci.c
> @@ -5,14 +5,101 @@
>  
>  #include <linux/pci.h>
>  
> +#include "../core.h"
> +#include "../hal.h"
> +#include "../hif.h"
> +#include "../mhi.h"
> +#include "../pci.h"
> +#include "hal.h"
> +#include "hw.h"
> +#include "mhi.h"
>  #include "pci.h"
>  
> +#define QCN9575_DEVICE_ID		0x1113
> +#define WINDOW_REG_ADDRESS		0x3278
> +
> +#define WINDOW_VALUE_MASK		GENMASK(25, 19)
> +#define WINDOW_STATIC_MASK		GENMASK(31, 7)
> +#define CE_WINDOW_MASK			GENMASK(13, 7)
> +#define UMAC_WINDOW_MASK		GENMASK(20, 14)
> +
> +static const struct pci_device_id ath12k_wifi8_pci_id_table[] = {
> +	{}

Why do you need an empty table?

> +};
> +
> +MODULE_DEVICE_TABLE(pci, ath12k_wifi8_pci_id_table);

...

> +static struct ath12k_pci_driver ath12k_wifi8_pci_driver = {
> +	.name = "ath12k_wifi8_pci",
> +	.id_table = ath12k_wifi8_pci_id_table,

I actually wonder how does it work with such table - what is its
purpose?

> +	.ops.probe = ath12k_wifi8_pci_probe,
> +	.reg_base = &ath12k_wifi8_reg_base,
> +};

Best regards,
Krzysztof


  reply	other threads:[~2026-11-21 12:28 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  8:15 [PATCH ath-next v3 00/15] wifi: ath12k: add initial Wi-Fi 8 support " Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 01/15] dt-bindings: net: wireless: add ath12k wifi device QCN9575 Madhavan Ganesan
2026-11-21 12:37   ` Krzysztof Kozlowski
2026-11-18  8:15 ` [PATCH ath-next v3 02/15] wifi: ath12k: refactor PCI window selection to per-device layout Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 03/15] wifi: ath12k: add extended QMI WLAN cfg for CE and service pipes Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 04/15] wifi: ath12k: add QMI support for extended firmware binary download Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 05/15] wifi: ath12k: add Wi-Fi 8 directory and base module scaffolding Madhavan Ganesan
2026-11-21 12:29   ` Krzysztof Kozlowski
2026-11-18  8:15 ` [PATCH ath-next v3 06/15] wifi: ath12k: add initial Wi-Fi 8 hw params and init helper for QCN9575 Madhavan Ganesan
2026-11-21 12:31   ` Krzysztof Kozlowski
2026-11-21 12:33   ` Krzysztof Kozlowski
2026-11-18  8:15 ` [PATCH ath-next v3 07/15] wifi: ath12k: add Wi-Fi 8 HAL register table and hal init hook " Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 08/15] wifi: ath12k: add Wi-Fi 8 HAL ops and descriptor definitions " Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 09/15] wifi: ath12k: add unified firmware image support " Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 10/15] wifi: ath12k: add Wi-Fi 8 MHI config " Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 11/15] wifi: ath12k: add Wi-Fi 8 CE config and service pipe map " Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 12/15] wifi: ath12k: add Wi-Fi 8 WMI init " Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 13/15] wifi: ath12k: add Wi-Fi 8 hw ops " Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 14/15] wifi: ath12k: add and hook Wi-Fi 8 mac80211 ops skeleton " Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 15/15] wifi: ath12k: add Wi-Fi 8 PCI driver scaffolding " Madhavan Ganesan
2026-11-21 12:28   ` Krzysztof Kozlowski [this message]
2026-11-21 12:34   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261121-astute-calculating-hippogriff-69ecfc@quoll \
    --to=krzk@kernel.org \
    --cc=ath12k@lists.infradead.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jjohnson@kernel.org \
    --cc=johannes@sipsolutions.net \
    --cc=justinstitt@google.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=madhavan.ganesan@oss.qualcomm.com \
    --cc=morbo@google.com \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®