mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Suyuan Wang via B4 Relay <devnull+shyckless.gmail.com@kernel.org>
To: alessio.belle@imgtec.com, luigi.santivetti@imgtec.com
Cc: donald.robson@imgtec.com, mripard@kernel.org,
	 dri-devel@lists.freedesktop.org,
	maarten.lankhorst@linux.intel.com,  airlied@gmail.com,
	simona@ffwll.ch, tzimmermann@suse.de,
	 linux-kernel@vger.kernel.org, imagination@lists.freedesktop.org
Subject: [PATCH v2 2/2] drm/imagination: Don't truncate the layer count in max_rts
Date: Sat, 21 Nov 2026 15:47:20 +0000	[thread overview]
Message-ID: <20261121-pvr-hwrt-common-v2-2-9f53bdf954de@gmail.com> (raw)
In-Reply-To: <20261121-pvr-hwrt-common-v2-0-9f53bdf954de@gmail.com>

From: Suyuan Wang <stevewong@hust.edu.cn>

hwrt_init_kernel_structure() stores the 32-bit args->layers from
userspace in the 16-bit hwrt->max_rts:

	hwrt->max_rts = args->layers;

hwrt_data_init_fw_structure() then allocates the SRTC and RAA objects
when args->layers > 1, but hwrt_data_fini_fw_structure() only frees them
when hwrt->max_rts > 1. With layers = 0x10000 or 0x10001, max_rts ends
up as 0 or 1, so both firmware objects are leaked when the data set is
destroyed or its creation fails. Any user who can open the render node
can do this with DRM_IOCTL_PVR_CREATE_HWRT_DATASET, and the objects
grow with the layer count.

Make max_rts a u32, like args->layers and the max_rts field of the
firmware's struct rogue_fwif_rta_ctl, so that both checks see the same
value.

Found with a static analysis tool and checked by hand.

Fixes: 6eedddab733b ("drm/imagination: Implement free list and HWRT create and destroy ioctls")
Cc: stable@vger.kernel.org
Co-developed-by: Kaixuan Li <kaixuan.li@ntu.edu.sg>
Signed-off-by: Kaixuan Li <kaixuan.li@ntu.edu.sg>
Signed-off-by: Suyuan Wang <stevewong@hust.edu.cn>
---
 drivers/gpu/drm/imagination/pvr_hwrt.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/imagination/pvr_hwrt.h b/drivers/gpu/drm/imagination/pvr_hwrt.h
index 676070b20c3b..7c215e2bd35a 100644
--- a/drivers/gpu/drm/imagination/pvr_hwrt.h
+++ b/drivers/gpu/drm/imagination/pvr_hwrt.h
@@ -74,7 +74,7 @@ struct pvr_hwrt_dataset {
 	struct pvr_free_list *free_lists[ROGUE_FWIF_NUM_RTDATA_FREELISTS];
 
 	/** @max_rts: Maximum render targets for this HWRT data set. */
-	u16 max_rts;
+	u32 max_rts;
 };
 
 struct pvr_hwrt_dataset *

-- 
2.34.1



      parent reply	other threads:[~2026-11-21 15:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21 15:47 [PATCH v2 0/2] drm/imagination: Fix leaks in HWRT data set handling Suyuan Wang via B4 Relay
2026-11-21 15:47 ` [PATCH v2 1/2] drm/imagination: Destroy the common FW object when HWRT data setup fails Suyuan Wang via B4 Relay
2026-11-21 15:47 ` Suyuan Wang via B4 Relay [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261121-pvr-hwrt-common-v2-2-9f53bdf954de@gmail.com \
    --to=devnull+shyckless.gmail.com@kernel.org \
    --cc=airlied@gmail.com \
    --cc=alessio.belle@imgtec.com \
    --cc=donald.robson@imgtec.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=imagination@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luigi.santivetti@imgtec.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=shyckless@gmail.com \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®