mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Suyuan Wang via B4 Relay <devnull+shyckless.gmail.com@kernel.org>
To: alessio.belle@imgtec.com, luigi.santivetti@imgtec.com
Cc: donald.robson@imgtec.com, mripard@kernel.org,
	 dri-devel@lists.freedesktop.org,
	maarten.lankhorst@linux.intel.com,  airlied@gmail.com,
	simona@ffwll.ch, tzimmermann@suse.de,
	 linux-kernel@vger.kernel.org, imagination@lists.freedesktop.org
Subject: [PATCH v2 0/2] drm/imagination: Fix leaks in HWRT data set handling
Date: Sat, 21 Nov 2026 15:47:18 +0000	[thread overview]
Message-ID: <20261121-pvr-hwrt-common-v2-0-9f53bdf954de@gmail.com> (raw)

Patch 1 is v1 with the Fixes tag corrected: the error path that skips
hwrt_fini_common_fw_structure() came with f1f55ed3ffe4, not with the
commit that added the ioctl (thanks to the Sashiko review).

Patch 2 fixes the other leak that review pointed out: the 32-bit layer
count is truncated into the 16-bit max_rts, so the SRTC and RAA objects
allocated for layers > 1 can be skipped on destroy.

Found with a static analysis tool and checked by hand. Compile tested on
arm64 (W=1, all files that include pvr_hwrt.h); I don't have the
hardware.

Changes in v2:
- 1/2: Fixes tag now points to f1f55ed3ffe4. No code change.
- 2/2: new.

v1: https://lore.kernel.org/all/20261121-pvr-hwrt-common-v1-1-784ce45b782a@gmail.com/
---
Suyuan Wang (2):
      drm/imagination: Destroy the common FW object when HWRT data setup fails
      drm/imagination: Don't truncate the layer count in max_rts

 drivers/gpu/drm/imagination/pvr_hwrt.c | 2 ++
 drivers/gpu/drm/imagination/pvr_hwrt.h | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)



             reply	other threads:[~2026-11-21 15:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21 15:47 Suyuan Wang via B4 Relay [this message]
2026-11-21 15:47 ` [PATCH v2 1/2] drm/imagination: Destroy the common FW object when HWRT data setup fails Suyuan Wang via B4 Relay
2026-11-21 15:47 ` [PATCH v2 2/2] drm/imagination: Don't truncate the layer count in max_rts Suyuan Wang via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261121-pvr-hwrt-common-v2-0-9f53bdf954de@gmail.com \
    --to=devnull+shyckless.gmail.com@kernel.org \
    --cc=airlied@gmail.com \
    --cc=alessio.belle@imgtec.com \
    --cc=donald.robson@imgtec.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=imagination@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luigi.santivetti@imgtec.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=shyckless@gmail.com \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®