* [PATCH 1/2] drm/amd/display: Document the union in dc_probe_status
@ 2026-11-21 4:14 TAKANO Mitsuhiro
2026-11-21 4:14 ` [PATCH 2/2] drm/amd/display: Document max_gamut_remap_coeff TAKANO Mitsuhiro
0 siblings, 1 reply; 2+ messages in thread
From: TAKANO Mitsuhiro @ 2026-11-21 4:14 UTC (permalink / raw)
To: amd-gfx, Harry Wentland, Leo Li, Alex Deucher
Cc: Rodrigo Siqueira, Christian König, David Airlie,
Simona Vetter, Thomas Huth, Weijie Yuan, dri-devel, linux-kernel,
TAKANO Mitsuhiro
The members of the union in dc_probe_status are described one by one as
@u.bandwidth_mbps and so on, but the union itself has no description, so
kernel-doc reports:
dc.h:2225 struct member 'u' not described in
'dc_probe_status'
Describe it, saying that the member holding the result depends on the
probe type.
Written with Hermes Agent, an LLM assistant; the author reviewed it and
ran kernel-doc on the file with and without the change.
Fixes: 52771a3254ea ("drm/amd/display: Wire probe commit path into dc_update_state")
Signed-off-by: TAKANO Mitsuhiro <takano32@gmail.com>
---
drivers/gpu/drm/amd/display/dc/dc.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
index d3c484f45333..debdd69bbe4e 100644
--- a/drivers/gpu/drm/amd/display/dc/dc.h
+++ b/drivers/gpu/drm/amd/display/dc/dc.h
@@ -2207,6 +2207,7 @@ struct dc_probe_latencies {
* @valid: true if a measurement was latched.
* @measuring: true if the hardware counter is currently running.
* @type: type of the probe that produced this result.
+ * @u: probe result; the member holding it depends on @type.
* @u.bandwidth_mbps: peak BW in Mbps (DC_PROBE_PEAK_MEM_BW).
* @u.latency: min/max/avg memory latency in ns (DC_PROBE_MEM_LATENCY),
* stored as struct dc_probe_latencies.
base-commit: d0f871bfb831705d9f55479f5b2b40f636ea7b16
--
2.53.0
^ permalink raw reply [flat|nested] 2+ messages in thread* [PATCH 2/2] drm/amd/display: Document max_gamut_remap_coeff
2026-11-21 4:14 [PATCH 1/2] drm/amd/display: Document the union in dc_probe_status TAKANO Mitsuhiro
@ 2026-11-21 4:14 ` TAKANO Mitsuhiro
0 siblings, 0 replies; 2+ messages in thread
From: TAKANO Mitsuhiro @ 2026-11-21 4:14 UTC (permalink / raw)
To: amd-gfx, Harry Wentland, Leo Li, Alex Deucher
Cc: Rodrigo Siqueira, Christian König, David Airlie,
Simona Vetter, Thomas Huth, Weijie Yuan, dri-devel, linux-kernel,
TAKANO Mitsuhiro
kernel-doc reports:
dc.h:329 struct member 'max_gamut_remap_coeff' not described in
'mpc_color_caps'
The 17 resource files that set dc->caps.color.mpc.gamut_remap to 1 also
set the member to dc_fixpt_from_fraction(S3D12_MAX, DIVIDER); the other
ten leave it at zero, and the comment of mpc_color_caps does not mention
it. Describe it.
Written with Hermes Agent, an LLM assistant; the author reviewed it and
ran kernel-doc on the file with and without the change.
Fixes: 1c5e6cd8291f ("drm/amd/display: adjust floating point format for gamut remap when needed")
Link: https://lore.kernel.org/all/ec4d7cff-d23a-46d1-b245-921f442b9a7b@redhat.com/
Signed-off-by: TAKANO Mitsuhiro <takano32@gmail.com>
---
drivers/gpu/drm/amd/display/dc/dc.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h
index debdd69bbe4e..32bf87fed40d 100644
--- a/drivers/gpu/drm/amd/display/dc/dc.h
+++ b/drivers/gpu/drm/amd/display/dc/dc.h
@@ -314,6 +314,7 @@ struct lut3d_caps {
* @mcm_3d_lut_caps: HW support cap for MCM LUT memory
* @rmcm_3d_lut_caps: HW support cap for RMCM LUT memory
* @preblend: whether color manager supports preblend with MPC
+ * @max_gamut_remap_coeff: largest gamut remap coefficient the MPC supports
*/
struct mpc_color_caps {
uint16_t gamut_remap : 1;
--
2.53.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-21 4:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-21 4:14 [PATCH 1/2] drm/amd/display: Document the union in dc_probe_status TAKANO Mitsuhiro
2026-11-21 4:14 ` [PATCH 2/2] drm/amd/display: Document max_gamut_remap_coeff TAKANO Mitsuhiro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®