* [PATCH v2] drm/ttm: Don't warn on oversized page directory allocations
@ 2026-11-21 9:57 Shuicheng Lin
0 siblings, 0 replies; only message in thread
From: Shuicheng Lin @ 2026-11-21 9:57 UTC (permalink / raw)
To: dri-devel
Cc: Shuicheng Lin, intel-xe, Natalie Vock, Arun Pravin, Matthew Auld,
Matthew Brost, Thomas Hellström, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, linux-kernel
The page directory size in ttm_tt_alloc_page_directory() and
ttm_dma_tt_alloc_page_directory() comes from the user-supplied BO size.
kvmalloc() warns on requests above INT_MAX unless __GFP_NOWARN is set,
so userspace can trigger a WARN (or a panic with panic_on_warn) by
creating a huge BO, e.g. a 1 TiB sysmem BO on xe with DEFER_BACKING:
WARNING: mm/slub.c:7144 at __kvmalloc_node_noprof+0x665/0x810
Call Trace:
ttm_tt_init+0x1e0/0x2b0
xe_ttm_tt_create+0x2cf/0x4b0 [xe]
ttm_tt_create+0x17c/0x310
...
xe_gem_create_ioctl+0x70f/0x12b0 [xe]
The failure is already handled and the ioctl returns -ENOMEM, so pass
__GFP_NOWARN to both allocations.
v2 (Sashiko):
- Also pass __GFP_NOWARN in ttm_sg_tt_alloc_page_directory(), whose
size comes from an imported dma-buf
Fixes: 7661809d493b ("mm: don't allow oversized kvmalloc() calls")
Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>
---
drivers/gpu/drm/ttm/ttm_tt.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c
index b645a1818184..7d6c9247507b 100644
--- a/drivers/gpu/drm/ttm/ttm_tt.c
+++ b/drivers/gpu/drm/ttm/ttm_tt.c
@@ -117,7 +117,8 @@ EXPORT_SYMBOL_FOR_TESTS_ONLY(ttm_tt_create);
*/
static int ttm_tt_alloc_page_directory(struct ttm_tt *ttm)
{
- ttm->pages = kvcalloc(ttm->num_pages, sizeof(void*), GFP_KERNEL);
+ ttm->pages = kvcalloc(ttm->num_pages, sizeof(void *),
+ GFP_KERNEL | __GFP_NOWARN);
if (!ttm->pages)
return -ENOMEM;
@@ -127,7 +128,8 @@ static int ttm_tt_alloc_page_directory(struct ttm_tt *ttm)
static int ttm_dma_tt_alloc_page_directory(struct ttm_tt *ttm)
{
ttm->pages = kvcalloc(ttm->num_pages, sizeof(*ttm->pages) +
- sizeof(*ttm->dma_address), GFP_KERNEL);
+ sizeof(*ttm->dma_address),
+ GFP_KERNEL | __GFP_NOWARN);
if (!ttm->pages)
return -ENOMEM;
@@ -137,7 +139,8 @@ static int ttm_dma_tt_alloc_page_directory(struct ttm_tt *ttm)
static int ttm_sg_tt_alloc_page_directory(struct ttm_tt *ttm)
{
- ttm->dma_address = kvzalloc_objs(*ttm->dma_address, ttm->num_pages);
+ ttm->dma_address = kvzalloc_objs(*ttm->dma_address, ttm->num_pages,
+ GFP_KERNEL | __GFP_NOWARN);
if (!ttm->dma_address)
return -ENOMEM;
base-commit: 61df0d1929e7e99d38404a1be02c461a8f6a3f5a
--
2.43.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-11-21 9:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-21 9:57 [PATCH v2] drm/ttm: Don't warn on oversized page directory allocations Shuicheng Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®