* [PATCH 1/2] usb: uas: expose US_FL_NO_ATA_1X in sysfs as ata_passthrough_disabled
@ 2026-11-21 15:52 Mateusz Jończyk
2026-11-21 15:52 ` [PATCH 2/2] usb: mass storage: expose ata_passthrough_disabled in sysfs Mateusz Jończyk
0 siblings, 1 reply; 2+ messages in thread
From: Mateusz Jończyk @ 2026-11-21 15:52 UTC (permalink / raw)
To: Oliver Neukum, Alan Stern
Cc: James E.J. Bottomley, Martin K. Petersen, Greg Kroah-Hartman,
linux-usb, linux-scsi, usb-storage, linux-kernel,
Mateusz Jończyk
The uas driver blocks access to ATA passthrough commands for some
devices it considers buggy. However, it does not expose any meaningful
information whether the command was disabled by the driver or is
genuinly not supported by the hardware. This creates a problem for the
smartmontools program and makes it difficult for it to provide a useful
error message.
Link: https://www.smartmontools.org/wiki/SAT-with-UAS-Linux
Signed-off-by: Mateusz Jończyk <mat.jonczyk@o2.pl>
---
v2:
- rename the attribute to ata_passthrough_disabled (to match others),
- add a proper documentation,
- add the ABI documentation for scsi to MAINTAINERS as appropriate,
- add a second patch to expose the information also for the usb-storage
driver,
---
.../ABI/testing/sysfs-class-scsi_device | 10 ++++++++++
MAINTAINERS | 1 +
drivers/usb/storage/uas.c | 20 +++++++++++++++++++
3 files changed, 31 insertions(+)
create mode 100644 Documentation/ABI/testing/sysfs-class-scsi_device
diff --git a/Documentation/ABI/testing/sysfs-class-scsi_device b/Documentation/ABI/testing/sysfs-class-scsi_device
new file mode 100644
index 000000000000..4dc8645bf59b
--- /dev/null
+++ b/Documentation/ABI/testing/sysfs-class-scsi_device
@@ -0,0 +1,10 @@
+What: /sys/class/scsi_device/*/device/ata_passthrough_disabled
+Date: Nov, 2026
+KernelVersion: v7.5
+Contact: usb-storage@lists.one-eyed-alien.net
+Description: (RO) Indicates whether the driver blocks access from userspace
+ to ATA passthrough commands. Contains a value of '1' when such
+ commands are denied as the hardware is considered buggy and they
+ might interfere with a correct operation of the drive. Note that
+ a value of '0' does not necessarily mean that ATA passthrough is
+ available as it may not be supported by the hardware at all.
diff --git a/MAINTAINERS b/MAINTAINERS
index ccbcdc0799b9..d056984f4998 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -25293,6 +25293,7 @@ S: Maintained
Q: https://patchwork.kernel.org/project/linux-scsi/list/
T: git git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git
T: git git://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git
+F: Documentation/ABI/testing/sysfs-class-scsi_*
F: Documentation/devicetree/bindings/scsi/
F: drivers/scsi/
F: drivers/ufs/
diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c
index 8655edbd66b1..49481bfca34c 100644
--- a/drivers/usb/storage/uas.c
+++ b/drivers/usb/storage/uas.c
@@ -910,6 +910,25 @@ static int uas_sdev_configure(struct scsi_device *sdev,
return 0;
}
+/* Sysfs interface */
+static ssize_t ata_passthrough_disabled_show(struct device *dev, struct device_attribute *attr,
+ char *buf)
+{
+ struct scsi_device *sdev = to_scsi_device(dev);
+ struct uas_dev_info *devinfo = sdev->hostdata;
+
+ return sysfs_emit(buf, "%d\n", !!(devinfo->flags & US_FL_NO_ATA_1X));
+}
+
+static DEVICE_ATTR_RO(ata_passthrough_disabled);
+
+static struct attribute *uas_sdev_attrs[] = {
+ &dev_attr_ata_passthrough_disabled.attr,
+ NULL,
+};
+
+ATTRIBUTE_GROUPS(uas_sdev);
+
static const struct scsi_host_template uas_host_template = {
.module = THIS_MODULE,
.name = "uas",
@@ -929,6 +948,7 @@ static const struct scsi_host_template uas_host_template = {
.dma_alignment = 511,
.dma_boundary = PAGE_SIZE - 1,
.cmd_size = sizeof(struct uas_cmd_info),
+ .sdev_groups = uas_sdev_groups,
};
#define UNUSUAL_DEV(id_vendor, id_product, bcdDeviceMin, bcdDeviceMax, \
--
2.47.3
^ permalink raw reply [flat|nested] 2+ messages in thread* [PATCH 2/2] usb: mass storage: expose ata_passthrough_disabled in sysfs
2026-11-21 15:52 [PATCH 1/2] usb: uas: expose US_FL_NO_ATA_1X in sysfs as ata_passthrough_disabled Mateusz Jończyk
@ 2026-11-21 15:52 ` Mateusz Jończyk
0 siblings, 0 replies; 2+ messages in thread
From: Mateusz Jończyk @ 2026-11-21 15:52 UTC (permalink / raw)
To: Oliver Neukum, Alan Stern
Cc: James E.J. Bottomley, Martin K. Petersen, Greg Kroah-Hartman,
linux-usb, linux-scsi, usb-storage, linux-kernel,
Mateusz Jończyk
The mass storage driver blocks access to ATA passthrough commands for some
devices it considers buggy. As in the case of the uas driver, indicate
this in sysfs.
Signed-off-by: Mateusz Jończyk <mat.jonczyk@o2.pl>
---
v2:
- add this patch to the series
---
drivers/usb/storage/scsiglue.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/usb/storage/scsiglue.c b/drivers/usb/storage/scsiglue.c
index 97de28e85562..43198888449e 100644
--- a/drivers/usb/storage/scsiglue.c
+++ b/drivers/usb/storage/scsiglue.c
@@ -572,6 +572,18 @@ US_DO_ALL_FLAGS
* Sysfs interface
***********************************************************************/
+/* Output routine for the sysfs ata_passthrough_disabled file */
+static ssize_t ata_passthrough_disabled_show(struct device *dev, struct device_attribute *attr,
+ char *buf)
+{
+ struct scsi_device *sdev = to_scsi_device(dev);
+ struct us_data *us = host_to_us(sdev->host);
+
+ return sysfs_emit(buf, "%d\n", !!(us->fflags & US_FL_NO_ATA_1X));
+}
+
+static DEVICE_ATTR_RO(ata_passthrough_disabled);
+
/* Output routine for the sysfs max_sectors file */
static ssize_t max_sectors_show(struct device *dev, struct device_attribute *attr, char *buf)
{
@@ -602,6 +614,7 @@ static ssize_t max_sectors_store(struct device *dev, struct device_attribute *at
static DEVICE_ATTR_RW(max_sectors);
static struct attribute *usb_sdev_attrs[] = {
+ &dev_attr_ata_passthrough_disabled.attr,
&dev_attr_max_sectors.attr,
NULL,
};
--
2.47.3
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-21 15:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-21 15:52 [PATCH 1/2] usb: uas: expose US_FL_NO_ATA_1X in sysfs as ata_passthrough_disabled Mateusz Jończyk
2026-11-21 15:52 ` [PATCH 2/2] usb: mass storage: expose ata_passthrough_disabled in sysfs Mateusz Jończyk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®