* [PATCH] usb-storage: alauda: track media_initialized per port
@ 2026-11-21 17:19 Arbab Haider
0 siblings, 0 replies; 2+ messages in thread
From: Arbab Haider @ 2026-11-21 17:19 UTC (permalink / raw)
To: Alan Stern, Greg Kroah-Hartman
Cc: Shichao Lai, linux-usb, usb-storage, linux-kernel,
syzbot+dc208a8cf8d37cf3e5ac, stable, Arbab Haider
Commit 16637fea001a ("usb-storage: alauda: Check whether the media is
initialized") added a media_initialized flag to struct alauda_info to
prevent divide-by-zero errors when alauda_init_media() has not succeeded.
However, Alauda devices expose two LUNs (us->max_lun = 1) backed by
info->port[0] (xD) and info->port[1] (SmartMedia). Storing
media_initialized in struct alauda_info shares it across both ports: once
port 0 initializes, media_initialized becomes true, allowing port 1 to
skip alauda_init_media() when its media-change bit is clear and divide by
port[1].uzonesize == 0 in alauda_read_data() or alauda_write_lba():
Oops: divide error: 0000 [#1] SMP KASAN NOPTI
RIP: 0010:alauda_read_data drivers/usb/storage/alauda.c:953 [inline]
RIP: 0010:alauda_transport+0xe5a/0x35c0 drivers/usb/storage/alauda.c:1187
Additionally, alauda_check_media() never cleared media_initialized when
media was removed or before re-initializing on media change, leaving it
true if a subsequent re-initialization failed.
Move media_initialized into struct alauda_media_info so each port tracks
its own initialization state, and clear it when media is absent or before
re-initializing on media change.
Reported-by: syzbot+dc208a8cf8d37cf3e5ac@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=dc208a8cf8d37cf3e5ac
Fixes: 16637fea001a ("usb-storage: alauda: Check whether the media is initialized")
Cc: stable@vger.kernel.org
Signed-off-by: Arbab Haider <arbabhaider649@gmail.com>
---
drivers/usb/storage/alauda.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/storage/alauda.c b/drivers/usb/storage/alauda.c
index 5e7f99ba8..5493f25a7 100644
--- a/drivers/usb/storage/alauda.c
+++ b/drivers/usb/storage/alauda.c
@@ -96,6 +96,8 @@ struct alauda_media_info {
u16 **lba_to_pba; /* logical to physical block map */
u16 **pba_to_lba; /* physical to logical block map */
+
+ bool media_initialized;
};
struct alauda_info {
@@ -105,8 +107,6 @@ struct alauda_info {
unsigned char sense_key;
unsigned long sense_asc; /* additional sense code */
unsigned long sense_ascq; /* additional sense code qualifier */
-
- bool media_initialized;
};
#define short_pack(lsb,msb) ( ((u16)(lsb)) | ( ((u16)(msb))<<8 ) )
@@ -471,6 +471,7 @@ static int alauda_check_media(struct us_data *us)
|| ((status[1] & 0x01) == 0)) {
usb_stor_dbg(us, "No media, or door open\n");
alauda_free_maps(&MEDIA_INFO(us));
+ MEDIA_INFO(us).media_initialized = false;
info->sense_key = 0x02;
info->sense_asc = 0x3A;
info->sense_ascq = 0x00;
@@ -478,12 +479,13 @@ static int alauda_check_media(struct us_data *us)
}
/* Check for media change */
- if (status[0] & 0x08 || !info->media_initialized) {
+ if (status[0] & 0x08 || !MEDIA_INFO(us).media_initialized) {
usb_stor_dbg(us, "Media change detected\n");
alauda_free_maps(&MEDIA_INFO(us));
+ MEDIA_INFO(us).media_initialized = false;
rc = alauda_init_media(us);
if (rc == USB_STOR_TRANSPORT_GOOD)
- info->media_initialized = true;
+ MEDIA_INFO(us).media_initialized = true;
info->sense_key = UNIT_ATTENTION;
info->sense_asc = 0x28;
info->sense_ascq = 0x00;
--
2.53.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] usb-storage: alauda: Track media_initialized per port
@ 2026-08-28 8:45 syzbot
0 siblings, 0 replies; 2+ messages in thread
From: syzbot @ 2026-08-28 8:45 UTC (permalink / raw)
To: syzkaller-bugs, Aleksandr Nogikh, Greg Kroah-Hartman, linux-usb,
Alan Stern, usb-storage, Shichao Lai
Cc: linux-kernel, syzbot
From: Aleksandr Nogikh <nogikh@google.com>
Commit 16637fea001a ("usb-storage: alauda: Check whether the media is
initialized") added a `media_initialized` boolean to `struct alauda_info`
to prevent `uzonesize` from remaining 0 on initialization failure. However,
`media_initialized` is shared between both LUNs (XD and SM media ports)
supported by the Alauda driver.
When the kernel probes LUN 0, it successfully initializes the media and
sets `media_initialized = true`. When it subsequently probes LUN 1,
`alauda_check_media()` sees that `media_initialized` is already true, skips
the initialization for LUN 1, and leaves its `uzonesize` as 0. Later, when
a read/write command is issued to LUN 1, the driver attempts to divide by
`uzonesize` in `alauda_read_data()`, resulting in a divide-by-zero
exception:
Oops: divide error: 0000 [#1] SMP KASAN NOPTI
CPU: 1 UID: 0 PID: 5849 Comm: usb-storage Not tainted
RIP: 0010:alauda_read_data drivers/usb/storage/alauda.c:954 [inline]
RIP: 0010:alauda_transport+0xbd6/0x43a0 drivers/usb/storage/alauda.c:1187
Call Trace:
<TASK>
usb_stor_invoke_transport+0x115/0x1a40 drivers/usb/storage/transport.c:611
usb_stor_control_thread+0x44c/0x8f0 drivers/usb/storage/usb.c:462
kthread+0x388/0x470 kernel/kthread.c:436
ret_from_fork+0x514/0xb70 arch/x86/kernel/process.c:158
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245
</TASK>
To fix this, move the `media_initialized` boolean from `struct alauda_info`
to `struct alauda_media_info` so that each LUN tracks its initialization
state independently. Additionally, explicitly set `media_initialized =
false` when no media is present or before calling `alauda_init_media()`.
This ensures that if initialization fails halfway through, the driver won't
accidentally trust stale data from a previously inserted card.
Fixes: 16637fea001a ("usb-storage: alauda: Check whether the media is initialized")
Assisted-by: Gemini:gemini-3.7-flash Gemini:gemini-3.1-pro-preview syzbot
Reported-by: syzbot+dc208a8cf8d37cf3e5ac@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=dc208a8cf8d37cf3e5ac
Link: https://syzkaller.appspot.com/ai_job?id=87935d94-4387-493a-8061-bcb7752c517c
Signed-off-by: Aleksandr Nogikh <nogikh@google.com>
---
diff --git a/drivers/usb/storage/alauda.c b/drivers/usb/storage/alauda.c
index 691fe4700..807492f75 100644
--- a/drivers/usb/storage/alauda.c
+++ b/drivers/usb/storage/alauda.c
@@ -96,6 +96,8 @@ struct alauda_media_info {
u16 **lba_to_pba; /* logical to physical block map */
u16 **pba_to_lba; /* physical to logical block map */
+
+ bool media_initialized;
};
struct alauda_info {
@@ -105,8 +107,6 @@ struct alauda_info {
unsigned char sense_key;
unsigned long sense_asc; /* additional sense code */
unsigned long sense_ascq; /* additional sense code qualifier */
-
- bool media_initialized;
};
#define short_pack(lsb,msb) ( ((u16)(lsb)) | ( ((u16)(msb))<<8 ) )
@@ -471,6 +471,7 @@ static int alauda_check_media(struct us_data *us)
|| ((status[1] & 0x01) == 0)) {
usb_stor_dbg(us, "No media, or door open\n");
alauda_free_maps(&MEDIA_INFO(us));
+ MEDIA_INFO(us).media_initialized = false;
info->sense_key = 0x02;
info->sense_asc = 0x3A;
info->sense_ascq = 0x00;
@@ -478,12 +479,13 @@ static int alauda_check_media(struct us_data *us)
}
/* Check for media change */
- if (status[0] & 0x08 || !info->media_initialized) {
+ if (status[0] & 0x08 || !MEDIA_INFO(us).media_initialized) {
usb_stor_dbg(us, "Media change detected\n");
alauda_free_maps(&MEDIA_INFO(us));
+ MEDIA_INFO(us).media_initialized = false;
rc = alauda_init_media(us);
if (rc == USB_STOR_TRANSPORT_GOOD)
- info->media_initialized = true;
+ MEDIA_INFO(us).media_initialized = true;
info->sense_key = UNIT_ATTENTION;
info->sense_asc = 0x28;
info->sense_ascq = 0x00;
base-commit: 8d3ae59288f1e7d58d76558a6ee96d533bc5019f
--
See https://goo.gle/syzbot-ai-patches for information about AI-generated patches.
The person who has signed off on the patch is responsible for
addressing comments.
syzbot engineers can be reached at syzkaller@googlegroups.com.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-21 17:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-21 17:19 [PATCH] usb-storage: alauda: track media_initialized per port Arbab Haider
-- strict thread matches above, loose matches on Subject: below --
2026-08-28 8:45 [PATCH] usb-storage: alauda: Track " syzbot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®