From: Koichiro Den <den@valinux.co.jp>
To: Anup Patel <anup@brainfault.org>,
Atish Patra <atish.patra@linux.dev>,
Andrew Jones <andrew.jones@linux.dev>
Cc: Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Bingyu Xian <shanbeeyoo@gmail.com>,
kvm@vger.kernel.org, kvm-riscv@lists.infradead.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 3/3] RISC-V: KVM: Skip steal-time updates when run_delay is unchanged
Date: Sun, 22 Nov 2026 02:35:26 +0900 [thread overview]
Message-ID: <20261121173526.892344-4-den@valinux.co.jp> (raw)
In-Reply-To: <20261121173526.892344-1-den@valinux.co.jp>
Check run_delay against last_steal and skip the update if they match.
This avoids looking up the memslot, accessing the SBI STA shared
structure, and marking its page dirty on vCPU loads with no new steal
time to report.
Reviewed-by: Andrew Jones <andrew.jones@linux.dev>
Signed-off-by: Koichiro Den <den@valinux.co.jp>
---
Changes since v1:
- Check run_delay before looking up the memslot. (Andrew)
v1: https://lore.kernel.org/r/20261118062242.2914385-3-den@valinux.co.jp/
arch/riscv/kvm/vcpu_sbi_sta.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/riscv/kvm/vcpu_sbi_sta.c b/arch/riscv/kvm/vcpu_sbi_sta.c
index 68d54696dbae..ebdd1435abd4 100644
--- a/arch/riscv/kvm/vcpu_sbi_sta.c
+++ b/arch/riscv/kvm/vcpu_sbi_sta.c
@@ -30,11 +30,16 @@ void kvm_riscv_vcpu_record_steal_time(struct kvm_vcpu *vcpu)
struct sbi_sta_struct __user *st;
unsigned long hva;
bool updated = false;
+ u64 run_delay;
gfn_t gfn;
if (shmem == INVALID_GPA)
return;
+ run_delay = READ_ONCE(current->sched_info.run_delay);
+ if (run_delay == last_steal)
+ return;
+
/*
* shmem is 64-byte aligned (see the enforcement in
* kvm_sbi_sta_steal_time_set_shmem()) and the size of sbi_sta_struct
@@ -61,7 +66,7 @@ void kvm_riscv_vcpu_record_steal_time(struct kvm_vcpu *vcpu)
/* Publish the odd sequence before updating stolen time. */
smp_wmb();
unsafe_get_user(steal, &st->steal, finish_update);
- vcpu->arch.sta.last_steal = READ_ONCE(current->sched_info.run_delay);
+ vcpu->arch.sta.last_steal = run_delay;
le64_add_cpu(&steal, vcpu->arch.sta.last_steal - last_steal);
unsafe_put_user(steal, &st->steal, finish_update);
wrote_steal = true;
--
2.54.0
prev parent reply other threads:[~2026-11-21 17:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 17:35 [PATCH v2 0/3] RISC-V: KVM: Lessen steal time update overhead Koichiro Den
2026-11-21 17:35 ` [PATCH v2 1/3] RISC-V: KVM: Order writes to the SBI STA shared structure Koichiro Den
2026-11-21 17:35 ` [PATCH v2 2/3] RISC-V: KVM: Batch user accesses when updating steal time Koichiro Den
2026-11-21 17:35 ` Koichiro Den [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261121173526.892344-4-den@valinux.co.jp \
--to=den@valinux.co.jp \
--cc=alex@ghiti.fr \
--cc=andrew.jones@linux.dev \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@linux.dev \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=shanbeeyoo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®