* [PATCH net-next v5 0/3] selftests: net: veth: propagate check failures to exit status
@ 2026-11-21 18:22 Omokefe Emmanuel Onanaroghene
2026-11-21 18:22 ` [PATCH net-next v5 1/3] selftests: net: veth: derive invalid-tx test value from kernel max Omokefe Emmanuel Onanaroghene
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Omokefe Emmanuel Onanaroghene @ 2026-11-21 18:22 UTC (permalink / raw)
To: tianyi, hangbin.liu
Cc: kuba, netdev, linux-kselftest, linux-kernel, bpf, davem,
edumazet, pabeni, horms, shuah, ast, daniel, hawk,
john.fastabend, sdf, skhan, kernel-team, tianyi.gao,
Omokefe Emmanuel Onanaroghene
Four checks in tools/testing/selftests/net/veth.sh report failures
without setting ret, allowing the script to exit 0 even when a check
fails. Set ret=1 in chk_channels() and the three "bad setting"
negative tests identified by Tianyi during review of v2.
Patch 1 fixes the invalid TX channel test, which used nproc + 1
to determine an out-of-range value. However, nproc can be lower
than num_possible_cpus() when CPU affinity or cpusets restrict
a process, meaning the kernel may accept the requested queue count.
This could cause false failures on a correctly functioning
kernel once earlier patches propagated test failures.
Use the kernel-reported max_tx + 1 instead, ensuring the
attempted value always exceeds the device's supported maximum.
Spotted by Sashiko AI review of v2.
---
v5:
- Retarget to net-next and drop the Fixes tags
- Move the invalid-tx fix first, so no commit in the series can
report a false failure on a correct kernel.
- Fix the subject prefix on the invalid-tx patch, lost in v4's
send.
v4: https://lore.kernel.org/all/20261119003003.40482-1-emmaonana18@gmail.com/
- Patch 2: use if/else instead of "&& { ...; } ||" chains, keep
lines within 80 columns (thanks Tianyi for the review).
- Add patch 3 deriving the invalid tx value from the kernel maximum.
v3: https://lore.kernel.org/all/20261116084107.6675-1-emmaonana18@gmail.com/
- Add Tianyi Gao's Tested-by to patch 1.
- Add patch 2 fixing the remaining three checks.
v2: https://lore.kernel.org/all/20261115214702.50817-1-emmaonana18@gmail.com/
- Correct Fixes tag to 1ec2230fc721.
v1: https://lore.kernel.org/all/20261115212117.48496-1-emmaonana18@gmail.com/
- Initial posting.
Omokefe Emmanuel Onanaroghene (3):
selftests: net: veth: derive invalid-tx test value from kernel max
selftests: net: veth: propagate channel-check failures to exit status
selftests: net: veth: propagate bad-settings check failures to exit
status
tools/testing/selftests/net/veth.sh | 31 +++++++++++++++++++++--------
1 file changed, 23 insertions(+), 8 deletions(-)
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH net-next v5 1/3] selftests: net: veth: derive invalid-tx test value from kernel max
2026-11-21 18:22 [PATCH net-next v5 0/3] selftests: net: veth: propagate check failures to exit status Omokefe Emmanuel Onanaroghene
@ 2026-11-21 18:22 ` Omokefe Emmanuel Onanaroghene
2026-11-21 18:22 ` [PATCH net-next v5 2/3] selftests: net: veth: propagate channel-check failures to exit status Omokefe Emmanuel Onanaroghene
2026-11-21 18:22 ` [PATCH net-next v5 3/3] selftests: net: veth: propagate bad-settings check " Omokefe Emmanuel Onanaroghene
2 siblings, 0 replies; 4+ messages in thread
From: Omokefe Emmanuel Onanaroghene @ 2026-11-21 18:22 UTC (permalink / raw)
To: tianyi, hangbin.liu
Cc: kuba, netdev, linux-kselftest, linux-kernel, bpf, davem,
edumazet, pabeni, horms, shuah, ast, daniel, hawk,
john.fastabend, sdf, skhan, kernel-team, tianyi.gao,
Omokefe Emmanuel Onanaroghene
The "setting invalid channels nr" check treats CPUS+1 (CPUS=`nproc`)
as an invalid tx count, but the kernel allows up to max_tx, for veth
that is num_possible_cpus(). On hosts where nproc < num_possible_cpus
(taskset/cpuset confinement, QEMU maxcpus slots, hotplug firmware),
the ethtool -L call succeeds and chk_channels() reports a false
failure. With failure propagation fixed, this fails the whole script.
Query the kernel-reported maximum with ethtool -l (the same parsing
idiom chk_channels() uses, first match) and attempt max+1, which is
invalid on every host.
Signed-off-by: Omokefe Emmanuel Onanaroghene <emmaonana18@gmail.com>
---
tools/testing/selftests/net/veth.sh | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/veth.sh b/tools/testing/selftests/net/veth.sh
index 64c2a5a59821d..22246278e6049 100755
--- a/tools/testing/selftests/net/veth.sh
+++ b/tools/testing/selftests/net/veth.sh
@@ -463,7 +463,9 @@ fi
ip netns exec $NS_DST ethtool -L veth$DST combined 2 2>/dev/null
chk_channels "bad setting: combined channels" $DST $CUR_RX $CUR_TX
-ip netns exec $NS_DST ethtool -L veth$DST tx $((CPUS + 1)) 2>/dev/null
+MAX_TX=`ip netns exec $NS_DST ethtool -l veth$DST |\
+ grep TX: | head -n 1 | awk '{print $2}'`
+ip netns exec $NS_DST ethtool -L veth$DST tx $((MAX_TX + 1)) 2>/dev/null
chk_channels "setting invalid channels nr" $DST $CUR_RX $CUR_TX
if [ $CPUS -gt 1 ]; then
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH net-next v5 2/3] selftests: net: veth: propagate channel-check failures to exit status
2026-11-21 18:22 [PATCH net-next v5 0/3] selftests: net: veth: propagate check failures to exit status Omokefe Emmanuel Onanaroghene
2026-11-21 18:22 ` [PATCH net-next v5 1/3] selftests: net: veth: derive invalid-tx test value from kernel max Omokefe Emmanuel Onanaroghene
@ 2026-11-21 18:22 ` Omokefe Emmanuel Onanaroghene
2026-11-21 18:22 ` [PATCH net-next v5 3/3] selftests: net: veth: propagate bad-settings check " Omokefe Emmanuel Onanaroghene
2 siblings, 0 replies; 4+ messages in thread
From: Omokefe Emmanuel Onanaroghene @ 2026-11-21 18:22 UTC (permalink / raw)
To: tianyi, hangbin.liu
Cc: kuba, netdev, linux-kselftest, linux-kernel, bpf, davem,
edumazet, pabeni, horms, shuah, ast, daniel, hawk,
john.fastabend, sdf, skhan, kernel-team, tianyi.gao,
Omokefe Emmanuel Onanaroghene
chk_channels() reports mismatches with a "fail" line but never sets
ret, so the script exits 0 even when channel counts are wrong. Every
other check helper in the file (__chk_flag, chk_xdp_feature, chk_gro)
sets ret=1 on failure, and all chk_channels() call sites expect the
check to pass. Set ret=1 on mismatch.
Tested-by: Tianyi Gao <tianyi@cloudflare.com>
Signed-off-by: Omokefe Emmanuel Onanaroghene <emmaonana18@gmail.com>
---
tools/testing/selftests/net/veth.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/net/veth.sh b/tools/testing/selftests/net/veth.sh
index 22246278e6049..7a2bbed0263e7 100755
--- a/tools/testing/selftests/net/veth.sh
+++ b/tools/testing/selftests/net/veth.sh
@@ -130,6 +130,7 @@ chk_channels() {
echo " ok "
else
echo " fail rx:$rx:$cur_rx tx:$tx:$cur_tx combined:n/a:$cur_combined"
+ ret=1
fi
}
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH net-next v5 3/3] selftests: net: veth: propagate bad-settings check failures to exit status
2026-11-21 18:22 [PATCH net-next v5 0/3] selftests: net: veth: propagate check failures to exit status Omokefe Emmanuel Onanaroghene
2026-11-21 18:22 ` [PATCH net-next v5 1/3] selftests: net: veth: derive invalid-tx test value from kernel max Omokefe Emmanuel Onanaroghene
2026-11-21 18:22 ` [PATCH net-next v5 2/3] selftests: net: veth: propagate channel-check failures to exit status Omokefe Emmanuel Onanaroghene
@ 2026-11-21 18:22 ` Omokefe Emmanuel Onanaroghene
2 siblings, 0 replies; 4+ messages in thread
From: Omokefe Emmanuel Onanaroghene @ 2026-11-21 18:22 UTC (permalink / raw)
To: tianyi, hangbin.liu
Cc: kuba, netdev, linux-kselftest, linux-kernel, bpf, davem,
edumazet, pabeni, horms, shuah, ast, daniel, hawk,
john.fastabend, sdf, skhan, kernel-team, tianyi.gao,
Omokefe Emmanuel Onanaroghene
Three more checks in veth.sh print "fail - set operation successful
?!?" without setting ret: "bad setting: XDP with RX nr less than TX",
"bad setting: reducing RX nr below peer TX with XDP set", and "bad
setting: increasing peer TX nr above RX with XDP set". A kernel that
wrongly accepts any of these invalid operations would be reported yet
the script would still exit 0. Wrap each fail branch so it sets ret=1.
Reported-by: Tianyi Gao <tianyi@cloudflare.com>
Link: https://lore.kernel.org/all/CAG4wq-cd01i7YrcFPmma=BXUcwn_PK=wneKW=vyEBYzQ3Bn7QA@mail.gmail.com/
Signed-off-by: Omokefe Emmanuel Onanaroghene <emmaonana18@gmail.com>
---
tools/testing/selftests/net/veth.sh | 26 +++++++++++++++++++-------
1 file changed, 19 insertions(+), 7 deletions(-)
diff --git a/tools/testing/selftests/net/veth.sh b/tools/testing/selftests/net/veth.sh
index 7a2bbed0263e7..6eeb123aaf885 100755
--- a/tools/testing/selftests/net/veth.sh
+++ b/tools/testing/selftests/net/veth.sh
@@ -474,9 +474,13 @@ if [ $CPUS -gt 1 ]; then
ip netns exec $NS_DST ethtool -L veth$DST rx 1 tx 2 2>/dev/null
ip netns exec $NS_SRC ethtool -L veth$SRC rx 1 tx 2 2>/dev/null
printf "%-60s" "bad setting: XDP with RX nr less than TX"
- ip -n $NS_DST link set dev veth$DST xdp object ${BPF_FILE} \
- section xdp 2>/dev/null &&\
- echo "fail - set operation successful ?!?" || echo " ok "
+ if ip -n $NS_DST link set dev veth$DST xdp object ${BPF_FILE} \
+ section xdp 2>/dev/null; then
+ echo "fail - set operation successful ?!?"
+ ret=1
+ else
+ echo " ok "
+ fi
# the following tests will run with multiple channels active
ip netns exec $NS_SRC ethtool -L veth$SRC rx 2
@@ -484,16 +488,24 @@ if [ $CPUS -gt 1 ]; then
ip -n $NS_DST link set dev veth$DST xdp object ${BPF_FILE} \
section xdp 2>/dev/null
printf "%-60s" "bad setting: reducing RX nr below peer TX with XDP set"
- ip netns exec $NS_DST ethtool -L veth$DST rx 1 2>/dev/null &&\
- echo "fail - set operation successful ?!?" || echo " ok "
+ if ip netns exec $NS_DST ethtool -L veth$DST rx 1 2>/dev/null; then
+ echo "fail - set operation successful ?!?"
+ ret=1
+ else
+ echo " ok "
+ fi
CUR_RX=2
CUR_TX=2
fi
if [ $CPUS -gt 2 ]; then
printf "%-60s" "bad setting: increasing peer TX nr above RX with XDP set"
- ip netns exec $NS_SRC ethtool -L veth$SRC tx 3 2>/dev/null &&\
- echo "fail - set operation successful ?!?" || echo " ok "
+ if ip netns exec $NS_SRC ethtool -L veth$SRC tx 3 2>/dev/null; then
+ echo "fail - set operation successful ?!?"
+ ret=1
+ else
+ echo " ok "
+ fi
chk_channels "setting invalid channels nr" $DST 2 2
fi
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-11-21 18:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-21 18:22 [PATCH net-next v5 0/3] selftests: net: veth: propagate check failures to exit status Omokefe Emmanuel Onanaroghene
2026-11-21 18:22 ` [PATCH net-next v5 1/3] selftests: net: veth: derive invalid-tx test value from kernel max Omokefe Emmanuel Onanaroghene
2026-11-21 18:22 ` [PATCH net-next v5 2/3] selftests: net: veth: propagate channel-check failures to exit status Omokefe Emmanuel Onanaroghene
2026-11-21 18:22 ` [PATCH net-next v5 3/3] selftests: net: veth: propagate bad-settings check " Omokefe Emmanuel Onanaroghene
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®