* [PATCH v2] rust_binder: disallow binder fd transfers
[not found] <--in-reply-to=20261118112933.477541-1-aliceryhl@google.com>
@ 2026-11-21 18:28 ` Carlos Llamas
0 siblings, 0 replies; only message in thread
From: Carlos Llamas @ 2026-11-21 18:28 UTC (permalink / raw)
To: Greg Kroah-Hartman, Arve Hjønnevåg, Todd Kjos,
Christian Brauner, Carlos Llamas, Alice Ryhl
Cc: kernel-team, linux-kernel, rust-for-linux
Transferring a binder device fd via BINDER_TYPE_FD or BINDER_TYPE_FDA
has no valid use case and can create direct reference cycles that
prevent Process::release() from running when a queued transaction is
left unread. Moreover, a binder file is bound to the opening process's
task, credentials, and mmap state, so transferring it to another
process breaks binder's per-process ownership model.
Disallow binder device fd transfers by returning EINVAL in
Allocation::info_add_fd().
Signed-off-by: Carlos Llamas <cmllamas@google.com>
---
v2: switch to atomic_load instead of volatile as suggested by Alice.
v1:
https://lore.kernel.org/all/20261117231927.2200674-1-cmllamas@google.com/
drivers/android/binder/allocation.rs | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/android/binder/allocation.rs b/drivers/android/binder/allocation.rs
index 927bf47d5d20..f998744f075d 100644
--- a/drivers/android/binder/allocation.rs
+++ b/drivers/android/binder/allocation.rs
@@ -9,7 +9,11 @@
bindings,
fs::file::{File, FileDescriptorReservation},
prelude::*,
- sync::{aref::ARef, Arc},
+ sync::{
+ aref::ARef,
+ atomic::{atomic_load, Relaxed},
+ Arc,
+ },
transmute::{AsBytes, FromBytes},
uaccess::UserSliceReader,
uapi,
@@ -182,6 +186,13 @@ pub(crate) fn info_add_fd(
buffer_offset: usize,
close_on_free: bool,
) -> Result {
+ // SAFETY: `file` is valid and any concurrent `f_op` writes are atomic.
+ let f_op = unsafe { atomic_load(&raw mut (*file.as_ptr()).f_op, Relaxed) };
+ if core::ptr::eq(f_op, &crate::rust_binder_fops.0) {
+ // Binder FD transfers are not allowed.
+ return Err(EINVAL);
+ }
+
self.get_or_init_info().file_list.files_to_translate.push(
FileEntry {
file,
--
2.56.1.809.ga0b61035b5-goog
^ permalink raw reply [flat|nested] only message in thread