mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH net-next v3] net: mdio: handle broken-turn-around for non-PHY MDIO devices
@ 2026-11-21 19:36 Bastian Germann
  0 siblings, 0 replies; only message in thread
From: Bastian Germann @ 2026-11-21 19:36 UTC (permalink / raw)
  To: andrew
  Cc: hkallweit1, davem, edumazet, kuba, pabeni, linux, olteanv,
	netdev, linux-kernel, Signed-off-by: Bastian Germann

From: "Signed-off-by: Bastian Germann" <bage@debian.org>

The "broken-turn-around" property is documented in mdio.yaml for any
MDIO device, but the MDIO core currently parses it only for PHY devices
in fwnode_mdiobus_phy_device_register(). Non-PHY devices, such as DSA
switches, are registered through of_mdiobus_register_device(), where the
property is ignored, so MDIO bus drivers that rely on phy_ignore_ta_mask
still treat the turn-around/read failure as an error.

Parse the property once in __of_mdiobus_parse_phys(), before the PHY and
non-PHY registration paths diverge, and drop it from
fwnode_mdiobus_phy_device_register().

Signed-off-by: Bastian Germann <bage@debian.org>
---
 drivers/net/mdio/fwnode_mdio.c | 3 ---
 drivers/net/mdio/of_mdio.c     | 4 ++++
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/net/mdio/fwnode_mdio.c b/drivers/net/mdio/fwnode_mdio.c
index ba7091518265..129481e8a910 100644
--- a/drivers/net/mdio/fwnode_mdio.c
+++ b/drivers/net/mdio/fwnode_mdio.c
@@ -89,9 +89,6 @@ int fwnode_mdiobus_phy_device_register(struct mii_bus *mdio,
 		phy->irq = mdio->irq[addr];
 	}
 
-	if (fwnode_property_read_bool(child, "broken-turn-around"))
-		mdio->phy_ignore_ta_mask |= 1 << addr;
-
 	/* Associate the fwnode with the device structure so it
 	 * can be looked up later
 	 */
diff --git a/drivers/net/mdio/of_mdio.c b/drivers/net/mdio/of_mdio.c
index b8d298c04d3f..fe321fa16188 100644
--- a/drivers/net/mdio/of_mdio.c
+++ b/drivers/net/mdio/of_mdio.c
@@ -164,6 +164,10 @@ static int __of_mdiobus_parse_phys(struct mii_bus *mdio, struct device_node *np,
 			continue;
 		}
 
+		/* Common to PHYs and other MDIO devices */
+		if (of_property_read_bool(child, "broken-turn-around"))
+			mdio->phy_ignore_ta_mask |= BIT(addr);
+
 		if (of_mdiobus_child_is_phy(child))
 			rc = of_mdiobus_register_phy(mdio, child, addr);
 		else

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-11-21 19:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-21 19:36 [PATCH net-next v3] net: mdio: handle broken-turn-around for non-PHY MDIO devices Bastian Germann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®