* [PATCH 0/3] wifi: ath10k: firmware feature bits for WCN3990 on SDM660
@ 2026-11-21 19:49 Gianluca Boiano
2026-11-21 19:49 ` [PATCH 1/3] wifi: ath10k: add firmware feature bit to skip channel stats events Gianluca Boiano
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Gianluca Boiano @ 2026-11-21 19:49 UTC (permalink / raw)
To: jjohnson
Cc: loic.poulain, linux-wireless, ath10k, linux-kernel, Gianluca Boiano
The WCN3990 firmware shipped for SDM660 devices crashes on two WMI
requests that ath10k sends by default (scan channel stats events and
pdev quiet mode), and finds no 5 GHz BSS when 5 GHz channels are
scanned actively.
Rather than adding chip checks, add three firmware feature bits so the
affected firmware images opt in through firmware-N.bin. Nothing changes
for firmware that does not set them. The ath10k-fwencoder change in
qca-swiss-army-knife to set the new names will be sent separately.
Tested on SDM660 (WCN3990).
Gianluca Boiano (3):
wifi: ath10k: add firmware feature bit to skip channel stats events
wifi: ath10k: add firmware feature bit to skip quiet mode
wifi: ath10k: add firmware feature bit to force passive scan on 5 GHz
drivers/net/wireless/ath/ath10k/core.c | 3 +++
drivers/net/wireless/ath/ath10k/core.h | 13 +++++++++++++
drivers/net/wireless/ath/ath10k/mac.c | 5 +++++
drivers/net/wireless/ath/ath10k/thermal.c | 5 +++++
drivers/net/wireless/ath/ath10k/wmi.c | 4 +++-
5 files changed, 29 insertions(+), 1 deletion(-)
--
2.56.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/3] wifi: ath10k: add firmware feature bit to skip channel stats events
2026-11-21 19:49 [PATCH 0/3] wifi: ath10k: firmware feature bits for WCN3990 on SDM660 Gianluca Boiano
@ 2026-11-21 19:49 ` Gianluca Boiano
2026-11-21 19:49 ` [PATCH 2/3] wifi: ath10k: add firmware feature bit to skip quiet mode Gianluca Boiano
2026-11-21 19:49 ` [PATCH 3/3] wifi: ath10k: add firmware feature bit to force passive scan on 5 GHz Gianluca Boiano
2 siblings, 0 replies; 4+ messages in thread
From: Gianluca Boiano @ 2026-11-21 19:49 UTC (permalink / raw)
To: jjohnson
Cc: loic.poulain, linux-wireless, ath10k, linux-kernel, Gianluca Boiano
SDM660 WCN3990 firmware crashes during scan when the scan command
requests channel stats events (WMI_SCAN_CHAN_STAT_EVENT):
qcom-q6v5-mss 4080000.remoteproc: fatal error received:
err_qdi.c:459:EX:wlan_process:1:WLAN RT:2073:PC=b00a5d88
qcacld-3.0 only sets this flag when gEnableSNRMonitoring=1, which
defaults to 0 and is not set by the vendor WCNSS_qcom_cfg.ini, so the
vendor driver never exercises this path.
Add ATH10K_FW_FEATURE_NO_CHAN_STAT_EVENT so affected firmware images
can opt out via firmware-N.bin. With the bit set the firmware no longer
reports per-channel statistics during scan, so survey data is not
updated on these devices.
Tested on SDM660 (WCN3990).
Signed-off-by: Gianluca Boiano <morf3089@gmail.com>
---
drivers/net/wireless/ath/ath10k/core.c | 1 +
drivers/net/wireless/ath/ath10k/core.h | 3 +++
drivers/net/wireless/ath/ath10k/wmi.c | 4 +++-
3 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
index 2aa18adb3..d37add4cf 100644
--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -815,6 +815,7 @@ static const char *const ath10k_core_fw_feature_str[] = {
[ATH10K_FW_FEATURE_SINGLE_CHAN_INFO_PER_CHANNEL] = "single-chan-info-per-channel",
[ATH10K_FW_FEATURE_PEER_FIXED_RATE] = "peer-fixed-rate",
[ATH10K_FW_FEATURE_IRAM_RECOVERY] = "iram-recovery",
+ [ATH10K_FW_FEATURE_NO_CHAN_STAT_EVENT] = "no-chan-stat-event",
};
static unsigned int ath10k_core_get_fw_feature_str(char *buf,
diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
index dfee43261..29a4c0d74 100644
--- a/drivers/net/wireless/ath/ath10k/core.h
+++ b/drivers/net/wireless/ath/ath10k/core.h
@@ -838,6 +838,9 @@ enum ath10k_fw_features {
/* Firmware support IRAM recovery */
ATH10K_FW_FEATURE_IRAM_RECOVERY = 22,
+ /* Firmware crashes when asked for channel stats events during scan. */
+ ATH10K_FW_FEATURE_NO_CHAN_STAT_EVENT = 23,
+
/* keep last */
ATH10K_FW_FEATURE_COUNT,
};
diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c
index e57588c19..adaf3c80f 100644
--- a/drivers/net/wireless/ath/ath10k/wmi.c
+++ b/drivers/net/wireless/ath/ath10k/wmi.c
@@ -7095,7 +7095,9 @@ void ath10k_wmi_start_scan_init(struct ath10k *ar,
| WMI_SCAN_EVENT_FOREIGN_CHANNEL
| WMI_SCAN_EVENT_FOREIGN_CHANNEL_EXIT
| WMI_SCAN_EVENT_DEQUEUED;
- arg->scan_ctrl_flags |= WMI_SCAN_CHAN_STAT_EVENT;
+ if (!test_bit(ATH10K_FW_FEATURE_NO_CHAN_STAT_EVENT,
+ ar->running_fw->fw_file.fw_features))
+ arg->scan_ctrl_flags |= WMI_SCAN_CHAN_STAT_EVENT;
arg->n_bssids = 1;
arg->bssids[0].bssid = "\xFF\xFF\xFF\xFF\xFF\xFF";
}
--
2.56.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 2/3] wifi: ath10k: add firmware feature bit to skip quiet mode
2026-11-21 19:49 [PATCH 0/3] wifi: ath10k: firmware feature bits for WCN3990 on SDM660 Gianluca Boiano
2026-11-21 19:49 ` [PATCH 1/3] wifi: ath10k: add firmware feature bit to skip channel stats events Gianluca Boiano
@ 2026-11-21 19:49 ` Gianluca Boiano
2026-11-21 19:49 ` [PATCH 3/3] wifi: ath10k: add firmware feature bit to force passive scan on 5 GHz Gianluca Boiano
2 siblings, 0 replies; 4+ messages in thread
From: Gianluca Boiano @ 2026-11-21 19:49 UTC (permalink / raw)
To: jjohnson
Cc: loic.poulain, linux-wireless, ath10k, linux-kernel, Gianluca Boiano
WCN3990 firmware advertises WMI_SERVICE_THERM_THROT, so the existing
service-bit guard in ath10k_thermal_set_throttling() lets the pdev quiet
mode command through. The firmware crashes on it deterministically and
takes the modem down with it.
Rather than hardcoding a chip check, add ATH10K_FW_FEATURE_NO_QUIET_MODE
so affected firmware images can opt out via firmware-N.bin. With the bit
set, thermal throttling through the ath10k cooling device has no effect.
Tested on SDM660 (WCN3990).
Signed-off-by: Gianluca Boiano <morf3089@gmail.com>
---
drivers/net/wireless/ath/ath10k/core.c | 1 +
drivers/net/wireless/ath/ath10k/core.h | 5 +++++
drivers/net/wireless/ath/ath10k/thermal.c | 5 +++++
3 files changed, 11 insertions(+)
diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
index d37add4cf..6272e0f62 100644
--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -816,6 +816,7 @@ static const char *const ath10k_core_fw_feature_str[] = {
[ATH10K_FW_FEATURE_PEER_FIXED_RATE] = "peer-fixed-rate",
[ATH10K_FW_FEATURE_IRAM_RECOVERY] = "iram-recovery",
[ATH10K_FW_FEATURE_NO_CHAN_STAT_EVENT] = "no-chan-stat-event",
+ [ATH10K_FW_FEATURE_NO_QUIET_MODE] = "no-quiet-mode",
};
static unsigned int ath10k_core_get_fw_feature_str(char *buf,
diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
index 29a4c0d74..5dd21f063 100644
--- a/drivers/net/wireless/ath/ath10k/core.h
+++ b/drivers/net/wireless/ath/ath10k/core.h
@@ -841,6 +841,11 @@ enum ath10k_fw_features {
/* Firmware crashes when asked for channel stats events during scan. */
ATH10K_FW_FEATURE_NO_CHAN_STAT_EVENT = 23,
+ /* Firmware advertises WMI_SERVICE_THERM_THROT but crashes when it
+ * receives the pdev quiet mode command.
+ */
+ ATH10K_FW_FEATURE_NO_QUIET_MODE = 24,
+
/* keep last */
ATH10K_FW_FEATURE_COUNT,
};
diff --git a/drivers/net/wireless/ath/ath10k/thermal.c b/drivers/net/wireless/ath/ath10k/thermal.c
index 9bb486f8e..c558a9e7c 100644
--- a/drivers/net/wireless/ath/ath10k/thermal.c
+++ b/drivers/net/wireless/ath/ath10k/thermal.c
@@ -139,6 +139,11 @@ void ath10k_thermal_set_throttling(struct ath10k *ar)
if (ar->state != ATH10K_STATE_ON)
return;
+ /* running_fw is only valid once the device is up */
+ if (test_bit(ATH10K_FW_FEATURE_NO_QUIET_MODE,
+ ar->running_fw->fw_file.fw_features))
+ return;
+
period = ar->thermal.quiet_period;
duration = (period * ar->thermal.throttle_state) / 100;
enabled = duration ? 1 : 0;
--
2.56.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 3/3] wifi: ath10k: add firmware feature bit to force passive scan on 5 GHz
2026-11-21 19:49 [PATCH 0/3] wifi: ath10k: firmware feature bits for WCN3990 on SDM660 Gianluca Boiano
2026-11-21 19:49 ` [PATCH 1/3] wifi: ath10k: add firmware feature bit to skip channel stats events Gianluca Boiano
2026-11-21 19:49 ` [PATCH 2/3] wifi: ath10k: add firmware feature bit to skip quiet mode Gianluca Boiano
@ 2026-11-21 19:49 ` Gianluca Boiano
2 siblings, 0 replies; 4+ messages in thread
From: Gianluca Boiano @ 2026-11-21 19:49 UTC (permalink / raw)
To: jjohnson
Cc: loic.poulain, linux-wireless, ath10k, linux-kernel, Gianluca Boiano
On SDM660 (WCN3990), no 5 GHz BSS is ever found when 5 GHz channels
are scanned actively. Marking the channels passive makes them show up.
2.4 GHz is unaffected.
Add ATH10K_FW_FEATURE_PASSIVE_SCAN_5GHZ; when set by firmware-N.bin,
mark every 5 GHz channel passive in the WMI channel list. Since no
probe requests are sent on 5 GHz with the bit set, hidden 5 GHz
networks are not discovered, and the flag applies to the whole channel
list, so it should only be set for firmware used in station mode.
Tested on SDM660 (WCN3990).
Signed-off-by: Gianluca Boiano <morf3089@gmail.com>
---
drivers/net/wireless/ath/ath10k/core.c | 1 +
drivers/net/wireless/ath/ath10k/core.h | 5 +++++
drivers/net/wireless/ath/ath10k/mac.c | 5 +++++
3 files changed, 11 insertions(+)
diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
index 6272e0f62..6ce819e06 100644
--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -817,6 +817,7 @@ static const char *const ath10k_core_fw_feature_str[] = {
[ATH10K_FW_FEATURE_IRAM_RECOVERY] = "iram-recovery",
[ATH10K_FW_FEATURE_NO_CHAN_STAT_EVENT] = "no-chan-stat-event",
[ATH10K_FW_FEATURE_NO_QUIET_MODE] = "no-quiet-mode",
+ [ATH10K_FW_FEATURE_PASSIVE_SCAN_5GHZ] = "passive-scan-5ghz",
};
static unsigned int ath10k_core_get_fw_feature_str(char *buf,
diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
index 5dd21f063..482195d28 100644
--- a/drivers/net/wireless/ath/ath10k/core.h
+++ b/drivers/net/wireless/ath/ath10k/core.h
@@ -846,6 +846,11 @@ enum ath10k_fw_features {
*/
ATH10K_FW_FEATURE_NO_QUIET_MODE = 24,
+ /* Firmware does not tune the radio during active scan on 5 GHz
+ * channels, all 5 GHz channels must be scanned passively.
+ */
+ ATH10K_FW_FEATURE_PASSIVE_SCAN_5GHZ = 25,
+
/* keep last */
ATH10K_FW_FEATURE_COUNT,
};
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 8e604697d..7710310dd 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -3448,6 +3448,11 @@ static int ath10k_update_channel_list(struct ath10k *ar)
passive = channel->flags & IEEE80211_CHAN_NO_IR;
ch->passive = passive;
+ if (channel->band == NL80211_BAND_5GHZ &&
+ test_bit(ATH10K_FW_FEATURE_PASSIVE_SCAN_5GHZ,
+ ar->running_fw->fw_file.fw_features))
+ ch->passive = true;
+
/* the firmware is ignoring the "radar" flag of the
* channel and is scanning actively using Probe Requests
* on "Radar detection"/DFS channels which are not
--
2.56.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-11-21 19:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-21 19:49 [PATCH 0/3] wifi: ath10k: firmware feature bits for WCN3990 on SDM660 Gianluca Boiano
2026-11-21 19:49 ` [PATCH 1/3] wifi: ath10k: add firmware feature bit to skip channel stats events Gianluca Boiano
2026-11-21 19:49 ` [PATCH 2/3] wifi: ath10k: add firmware feature bit to skip quiet mode Gianluca Boiano
2026-11-21 19:49 ` [PATCH 3/3] wifi: ath10k: add firmware feature bit to force passive scan on 5 GHz Gianluca Boiano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®