From: Jonathan Cameron <jic23@kernel.org>
To: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Cc: "Andy Shevchenko" <andriy.shevchenko@intel.com>,
"Lee Jones" <lee@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Olivier Moysan" <olivier.moysan@foss.st.com>,
linux-iio@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 04/10] iio: adc: stm32-adc: Validate channel index before writing chan_name
Date: Sat, 21 Nov 2026 22:45:55 +0000 [thread overview]
Message-ID: <20261121224555.55cc8bba@jic23-hlaptop> (raw)
In-Reply-To: <11aa41f5-da69-40b0-9b8b-6c5abfbec5f9@foss.st.com>
On Fri, 20 Nov 2026 18:22:26 +0100
Fabrice Gasnier <fabrice.gasnier@foss.st.com> wrote:
> On 11/19/26 18:24, Andy Shevchenko wrote:
> > On Thu, Nov 19, 2026 at 03:30:37PM +0000, Lee Jones wrote:
> >> stm32_adc_generic_chan_init() reads the child node's reg property into a
> >> signed int and, when the optional label property is present, writes into
> >> adc->chan_name[val] and calls stm32_adc_populate_int_ch() before
> >> checking whether val exceeds adc_info->max_channels. Because val is
> >> signed, values with the top bit set also become negative and bypass the
> >> upper-bound check altogether.
> >>
> >> Store val as a u32, matching fwnode_property_read_u32(), and move the
> >> max_channels bounds check immediately after reading reg.
> >
> > ...
> >
> >> + if (val >= adc_info->max_channels)
> >> + return dev_err_probe(dev, -EINVAL,
> >
> > -ECHRNG
> >
> > However it seems in the original code like this.
>
> Hi Lee, Andy
>
> I've no strong opinion on this remark, whether to change the error code here, and if it belongs to
> this fix ?
>
> In all case,
>
> Acked-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Let us not over think it.
Applied. Given it's hardening against a bad DT, not rushing this one in.
It can wait for the next merge window.
Thanks,
Jonathan
>
> Best Regards,
> Thanks,
> Fabrice
> >
> >> + "Invalid channel %u\n", val);
> >> +
> >> ret = fwnode_property_read_string(child, "label", &name);
> >
>
>
next prev parent reply other threads:[~2026-11-21 22:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 15:30 [PATCH 00/10] iio: Fix memory corruption, teardown races and bounds checks Lee Jones
2026-11-19 15:30 ` [PATCH 01/10] iio: imu: adis: Clear pointers after freeing in adis_update_scan_mode() Lee Jones
2026-11-21 22:27 ` Jonathan Cameron
2026-11-19 15:30 ` [PATCH 02/10] iio: accel: adxl313: Prevent FIFO buffer overflow in adxl313_fifo_transfer() Lee Jones
2026-11-19 17:22 ` Andy Shevchenko
2026-11-21 22:32 ` Jonathan Cameron
2026-11-19 15:30 ` [PATCH 03/10] iio: accel: adxl313: Reject sub-base ODR codes in adxl313_read_raw() Lee Jones
2026-11-19 17:23 ` Andy Shevchenko
2026-11-19 15:30 ` [PATCH 04/10] iio: adc: stm32-adc: Validate channel index before writing chan_name Lee Jones
2026-11-19 17:24 ` Andy Shevchenko
2026-11-20 17:22 ` Fabrice Gasnier
2026-11-21 22:45 ` Jonathan Cameron [this message]
2026-11-19 15:30 ` [PATCH 05/10] iio: adc: stm32-adc: Detach chained IRQ handler before removing domain Lee Jones
2026-11-20 17:23 ` Fabrice Gasnier
2026-11-21 22:51 ` Jonathan Cameron
2026-11-19 15:30 ` [PATCH 06/10] iio: adc: pac1934: Fix custom attribute allocation and channel bounds Lee Jones
2026-11-19 17:27 ` Andy Shevchenko
2026-11-21 22:54 ` Jonathan Cameron
2026-11-19 15:30 ` [PATCH 07/10] iio: adc: qcom-spmi-adc5-gen3: Free TM auxiliary device wrapper in release callback Lee Jones
2026-11-19 17:30 ` Andy Shevchenko
2026-11-19 15:30 ` [PATCH 08/10] iio: adc: qcom-spmi-adc5-gen3: Reject empty reg property in probe Lee Jones
2026-11-19 17:31 ` Andy Shevchenko
2026-11-19 15:30 ` [PATCH 09/10] iio: proximity: isl29501: Fix division by zero and overflow in isl29501_set_freq() Lee Jones
2026-11-19 17:34 ` Andy Shevchenko
2026-11-19 15:30 ` [PATCH 10/10] iio: light: tsl2591: Prevent infinite recursion on threshold boundaries Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261121224555.55cc8bba@jic23-hlaptop \
--to=jic23@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®