mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Lee Jones" <lee@kernel.org>,
	"Marius Cristea" <marius.cristea@microchip.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Bogdan Bolocan" <bogdan.bolocan@microchip.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH 06/10] iio: adc: pac1934: Fix custom attribute allocation and channel bounds
Date: Sat, 21 Nov 2026 22:54:45 +0000	[thread overview]
Message-ID: <20261121225445.47f60e23@jic23-hlaptop> (raw)
In-Reply-To: <av8xnBRNUzEo4YdZ@ashevche-desk.local>

On Thu, 19 Nov 2026 19:27:56 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Thu, Nov 19, 2026 at 03:30:39PM +0000, Lee Jones wrote:
> > pac1934_prep_custom_attributes() sizes the pac1934_custom_attr pointer
> > array using sizeof(*pac1934_group) instead of
> > sizeof(*pac1934_custom_attr) and adds 1 byte rather than one pointer
> > element for the terminating NULL entry.  When active_channels_count is
> > zero, only a single byte is allocated and iio_device_register_sysfs()
> > reads past the allocation when scanning the attribute list.
> > 
> > In addition, active_channels_count is counted over info->phys_channels,
> > whereas the population steps unconditionally inspect all four entries of
> > info->active_channels[], which can write past the end of the array on
> > 1-, 2-, and 3-channel chip variants.
> > 
> > Allocate active_channels_count + 1 attribute pointers with
> > devm_kzalloc_objs() and bound the population loop by
> > info->phys_channels.  
> 
> ...
> 
> > -	int i, active_channels_count = 0;
> > +	int i, j, active_channels_count = 0;  
> 
> While at it, can we move to make it more like a reversed xmas tree order?
> But see below first.
> 
> ...
> 
> > +	j = 0;
> > +	for (i = 0; i < info->phys_channels; i++)
> > +		if (info->active_channels[i])
> > +			pac1934_custom_attr[j++] = pac1934_shunt_attrs[i];  
> 
> But i is not used outside of the loop, can we rather have
> 
> 	i = 0;
> 	for (int j = 0; j < info->phys_channels; j++)
> 		if (info->active_channels[j])
> 			pac1934_custom_attr[i++] = pac1934_shunt_attrs[j];
> 
> ? In such a case the above hunk won't be needed.
> 
This change seems reasonable but significant enough I'm not going to just
tweak it whilst applying.

So v2 on this one please.

Thanks,

J


  reply	other threads:[~2026-11-21 22:54 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 15:30 [PATCH 00/10] iio: Fix memory corruption, teardown races and bounds checks Lee Jones
2026-11-19 15:30 ` [PATCH 01/10] iio: imu: adis: Clear pointers after freeing in adis_update_scan_mode() Lee Jones
2026-11-21 22:27   ` Jonathan Cameron
2026-11-19 15:30 ` [PATCH 02/10] iio: accel: adxl313: Prevent FIFO buffer overflow in adxl313_fifo_transfer() Lee Jones
2026-11-19 17:22   ` Andy Shevchenko
2026-11-21 22:32     ` Jonathan Cameron
2026-11-19 15:30 ` [PATCH 03/10] iio: accel: adxl313: Reject sub-base ODR codes in adxl313_read_raw() Lee Jones
2026-11-19 17:23   ` Andy Shevchenko
2026-11-19 15:30 ` [PATCH 04/10] iio: adc: stm32-adc: Validate channel index before writing chan_name Lee Jones
2026-11-19 17:24   ` Andy Shevchenko
2026-11-20 17:22     ` Fabrice Gasnier
2026-11-21 22:45       ` Jonathan Cameron
2026-11-19 15:30 ` [PATCH 05/10] iio: adc: stm32-adc: Detach chained IRQ handler before removing domain Lee Jones
2026-11-20 17:23   ` Fabrice Gasnier
2026-11-21 22:51     ` Jonathan Cameron
2026-11-19 15:30 ` [PATCH 06/10] iio: adc: pac1934: Fix custom attribute allocation and channel bounds Lee Jones
2026-11-19 17:27   ` Andy Shevchenko
2026-11-21 22:54     ` Jonathan Cameron [this message]
2026-11-19 15:30 ` [PATCH 07/10] iio: adc: qcom-spmi-adc5-gen3: Free TM auxiliary device wrapper in release callback Lee Jones
2026-11-19 17:30   ` Andy Shevchenko
2026-11-21 23:08     ` Jonathan Cameron
2026-11-19 15:30 ` [PATCH 08/10] iio: adc: qcom-spmi-adc5-gen3: Reject empty reg property in probe Lee Jones
2026-11-19 17:31   ` Andy Shevchenko
2026-11-19 15:30 ` [PATCH 09/10] iio: proximity: isl29501: Fix division by zero and overflow in isl29501_set_freq() Lee Jones
2026-11-19 17:34   ` Andy Shevchenko
2026-11-19 15:30 ` [PATCH 10/10] iio: light: tsl2591: Prevent infinite recursion on threshold boundaries Lee Jones
2026-11-21 23:13   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261121225445.47f60e23@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=bogdan.bolocan@microchip.com \
    --cc=dlechner@baylibre.com \
    --cc=lee@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marius.cristea@microchip.com \
    --cc=nuno.sa@analog.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®