mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>
Cc: Sumit Gupta <sumitg@nvidia.com>,
	rafael@kernel.org,  viresh.kumar@linaro.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,  treding@nvidia.com,
	jonathanh@nvidia.com, linux-pm@vger.kernel.org,
	 linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org,  bbasu@nvidia.com
Subject: Re: [PATCH v3 0/9] cpufreq: tegra194: add Tegra264 support
Date: Sun, 22 Nov 2026 17:53:30 +0100	[thread overview]
Message-ID: <20261122-elfish-amusing-muskox-d6cdef@quoll> (raw)
In-Reply-To: <2698e091-17e9-4a1d-acf1-19981ee604da@oss.qualcomm.com>

On Thu, Nov 19, 2026 at 07:41:34PM +0800, Zhongqiu Han wrote:
> On 11/19/2026 7:12 PM, Sumit Gupta wrote:
> > This series adds cpufreq support for Tegra264, which joins the SoCs
> > already supported by the tegra194-cpufreq driver.
> > 
> > Tegra264 keeps the existing model, where BPMP provides the NDIV limits.
> > The driver derives the current frequency from the core clock and
> > reference counters.
> > 
> > The main differences are:
> >   - Frequency read: through system registers, as on Tegra194, but from
> >     the 64-bit architected AMU counters. The reference counter ticks at
> >     the system counter rate (CNTFRQ).
> > 
> >   - Frequency request: through MMIO, as on Tegra234. The driver writes
> >     NDIV to a core_freq_req register in the CCPLEX register space. Each
> >     register controls a clock shared by two single-CPU clusters, so both
> >     CPUs form one cpufreq policy.
> > 
> > The patches fall into four groups:
> >   - Fix (patch 1): read each CPU's MPIDR from a CPU hotplug callback
> >     instead of at probe. A CPU that is offline at probe then also gets
> >     valid cluster and core IDs.
> > 
> >   - Preparation (patches 2 to 5): cleanups, mostly of the counter code,
> >     to make room for a 64-bit counter and for an MMIO mapping without
> >     ACTMON counters.
> > 
> >   - Improvement (patches 6 and 7): group CPUs by the generic
> >     "performance-domains" property, which cluster-based grouping cannot
> >     express on Tegra264. Device trees without it keep the existing
> >     grouping.
> > 
> >   - Tegra264 support (patches 8 and 9): the driver support, followed by
> >     the device tree changes it relies on.
> > 
> > v2[2] -> v3:
> >   - Patch 8: read the AMU counters with interrupts disabled (Zhongqiu).
> >   - Add Reviewed-by from Zhongqiu to patches 1-7 and 9.
> 
> For patch 8/9:
> 
> Reviewed-by: Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>

Why you cannot respond to specific patch? Tags applied to cover letter
work completely different!

Best regards,
Krzysztof


  reply	other threads:[~2026-11-22 16:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 11:12 Sumit Gupta
2026-11-19 11:12 ` [PATCH v3 1/9] cpufreq: tegra194: move MPIDR read to CPU hotplug callback Sumit Gupta
2026-11-19 11:12 ` [PATCH v3 2/9] cpufreq: tegra194: remove duplicate counter sampling loops Sumit Gupta
2026-11-19 11:12 ` [PATCH v3 3/9] cpufreq: tegra194: add tegra_counter_delta helper Sumit Gupta
2026-11-19 11:12 ` [PATCH v3 4/9] cpufreq: tegra194: add per-SoC counter mask Sumit Gupta
2026-11-19 11:12 ` [PATCH v3 5/9] cpufreq: tegra194: split MMIO mapping from ACTMON offset Sumit Gupta
2026-11-19 11:12 ` [PATCH v3 6/9] dt-bindings: arm: nvidia: Document the Tegra264 CCPLEX cluster Sumit Gupta
2026-11-22 16:57   ` Krzysztof Kozlowski
2026-11-19 11:12 ` [PATCH v3 7/9] cpufreq: tegra194: derive frequency domain from device tree Sumit Gupta
2026-11-19 11:12 ` [PATCH v3 8/9] cpufreq: tegra194: Add support for Tegra264 Sumit Gupta
2026-11-19 11:12 ` [PATCH v3 9/9] arm64: tegra: Add CCPLEX cluster node " Sumit Gupta
2026-11-19 11:41 ` [PATCH v3 0/9] cpufreq: tegra194: add Tegra264 support Zhongqiu Han
2026-11-22 16:53   ` Krzysztof Kozlowski [this message]
2026-11-20  4:52 ` Viresh Kumar
2026-11-20  7:36   ` Sumit Gupta
2026-11-20  7:44     ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261122-elfish-amusing-muskox-d6cdef@quoll \
    --to=krzk@kernel.org \
    --cc=bbasu@nvidia.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=sumitg@nvidia.com \
    --cc=treding@nvidia.com \
    --cc=viresh.kumar@linaro.org \
    --cc=zhongqiu.han@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®