mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2 0/2] ALSA: firewire: Abort transactions on a bus reset
@ 2026-11-22 13:46 Suyuan Wang via B4 Relay
  2026-11-22 13:46 ` [PATCH v2 1/2] ALSA: firewire-lib: Abort the FCP transaction " Suyuan Wang via B4 Relay
  2026-11-22 13:46 ` [PATCH v2 2/2] ALSA: fireworks: Abort the " Suyuan Wang via B4 Relay
  0 siblings, 2 replies; 3+ messages in thread
From: Suyuan Wang via B4 Relay @ 2026-11-22 13:46 UTC (permalink / raw)
  To: o-takashi, clemens, tiwai; +Cc: stefanr, linux-sound, perex, linux-kernel

fcp_avc_transaction() and snd_efw_transaction_run() resend their
command after a bus reset but never move the transaction back to
STATE_PENDING, so both loops keep resending without a retry limit
until sending fails.

As Takashi suggested, v2 no longer resends: on a bus reset the
transaction is ended and -EAGAIN is returned, following the AV/C
general specification, which says that a target discards any
transaction in progress on a bus reset.

Found with a static analysis tool and checked by hand. Compile tested
only (x86_64, W=1); I don't have FireWire audio hardware.

Changes in v2:
- Abort the transaction and return -EAGAIN on a bus reset instead of
  rearming it and resending (Takashi).
- Drop ERROR_DELAY_MS (and <linux/delay.h> in fcp.c), now unused.

v1: https://lore.kernel.org/all/20261120-firewire-busreset-v1-0-8bb9079a2984@gmail.com/
---
Suyuan Wang (2):
      ALSA: firewire-lib: Abort the FCP transaction on a bus reset
      ALSA: fireworks: Abort the transaction on a bus reset

 sound/firewire/fcp.c                             | 5 ++---
 sound/firewire/fireworks/fireworks_transaction.c | 4 ++--
 2 files changed, 4 insertions(+), 5 deletions(-)



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-22 13:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-22 13:46 [PATCH v2 0/2] ALSA: firewire: Abort transactions on a bus reset Suyuan Wang via B4 Relay
2026-11-22 13:46 ` [PATCH v2 1/2] ALSA: firewire-lib: Abort the FCP transaction " Suyuan Wang via B4 Relay
2026-11-22 13:46 ` [PATCH v2 2/2] ALSA: fireworks: Abort the " Suyuan Wang via B4 Relay

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®