From: Krzysztof Kozlowski <krzk@kernel.org>
To: tze.yee.ng@altera.com
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Tanmay Kathpalia <tanmay.kathpalia@altera.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, Ulf Hansson <ulfh@kernel.org>
Subject: Re: [PATCH v4 0/3] mmc: sdhci-cadence: SD6HC DDR50/DDR52 read-path tuning and fixes
Date: Sun, 22 Nov 2026 17:03:17 +0100 [thread overview]
Message-ID: <20261122-vague-chestnut-peacock-cc8b69@quoll> (raw)
In-Reply-To: <20261119-sd_cadence_ddr50_v3-v4-0-95a94a0aaaf3@altera.com>
On Thu, Nov 19, 2026 at 05:45:32PM +0800, tze.yee.ng@altera.com wrote:
> From: Tze Yee Ng <tze.yee.ng@altera.com>
>
> This series enables the extended-read DDR modes - SD DDR50 and eMMC
> DDR52 - on the Cadence SD6HC (SD/eMMC v6) PHY. Neither mode runs a host
> tuning sequence (CMD19/CMD21), so the read path must be centred by
> static, board/SoC-characterised PHY settings. Bringing it up on Agilex5
> also exposed PHY issues affecting the existing tuned modes.
>
> - Patch 1: abort a failed tuning command on SD6HC. The software tuning
> loop never aborted a command that errored, so after a CMD21 command
> error the eMMC could stay in the Data state and time out the CMD6
> that HS400 selection issues next; mmc_send_abort_tuning() clears it
> (a no-op for SD). Limited to SD6HC since the path is shared with the
> untested SD4HC.
> - Patch 2: document two optional SD6HC read-path properties for the
> extended-read DDR modes (SD DDR50, eMMC DDR52).
> - Patch 3: program PHONY_DQS_TIMING, which was left 0 in all modes; in
> extended-read mode it must be the rebar pulse width in clk_phy
> cycles minus 1, else one DDR beat is duplicated. The width is now
> derived from the SDCLK/sdmclk divider rather than hard-coded. The
> same patch reads the new properties at probe and applies them in
> DDR50 and DDR52, and makes the DQS_TIMING update clear USE_LPBK_DQS
> before reprogramming it so the loopback/phony selection takes
> effect.
>
> The new cdns,ddr-* properties are unused in this series; they will be
> consumed by the socfpga_agilex5_socdk and socfpga_agilex5_socdk_emmc
> device trees, submitted as a separate series.
>
> Tested on Agilex5 SoCDK: SD DDR50, eMMC DDR52 and eMMC HS400.
>
> Signed-off-by: Tze Yee Ng <tze.yee.ng@altera.com>
> ---
> Changes in v4:
> - Merged v3 2/4 (PHONY_DQS_TIMING) and v3 4/4 (read DDR tuning from
> device tree) into a single driver patch, now 3/3, and moved it after
> the binding patch. The series is now 3 patches. (Tanmay Kathpalia)
> - Patch 1: limited the abort to SD6HC (host->version >= SDHCI_SPEC_420)
> because sdhci_cdns_execute_tuning() is shared with SD4HC, which has
> not been tested; reworded the commit message accordingly. Added Tanmay's
> Reviewed-by.
> - Patch 2: dropped the cdns,ddr-phony-dqs-timing property; the phony DQS
> timing is always derived by the driver. (Tanmay Kathpalia)
> - Patch 2: dropped Krzysztof's Reviewed-by since property set changed. The
> two remaining properties are unchanged from v3; Krzysztof, happy to
> carry your tag again if the reduced binding looks fine.
Not a reason to drop the tag, really. Why would less custom properties
be something needing to be re-reviewed.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-11-22 16:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 9:45 tze.yee.ng
2026-11-19 9:45 ` [PATCH v4 1/3] mmc: sdhci-cadence: abort failed tuning command on SD6HC tze.yee.ng
2026-11-19 9:45 ` [PATCH v4 2/3] dt-bindings: mmc: cdns,sd6hc: add SD6HC DDR50 read-path tuning tze.yee.ng
2026-11-22 16:03 ` Krzysztof Kozlowski
2026-11-22 19:05 ` Kathpalia, Tanmay
2026-11-19 9:45 ` [PATCH v4 3/3] mmc: sdhci-cadence6: tune SD6HC DDR50/DDR52 read path tze.yee.ng
2026-11-22 19:06 ` Kathpalia, Tanmay
2026-11-22 16:03 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261122-vague-chestnut-peacock-cc8b69@quoll \
--to=krzk@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tanmay.kathpalia@altera.com \
--cc=tze.yee.ng@altera.com \
--cc=ulfh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®