mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Kathpalia, Tanmay" <tanmay.kathpalia@altera.com>
To: tze.yee.ng@altera.com, Adrian Hunter <adrian.hunter@intel.com>,
	linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, Ulf Hansson <ulfh@kernel.org>
Subject: Re: [PATCH v4 2/3] dt-bindings: mmc: cdns,sd6hc: add SD6HC DDR50 read-path tuning
Date: Mon, 23 Nov 2026 00:35:46 +0530	[thread overview]
Message-ID: <5de1ad0d-ef89-49e4-9195-195be48d57bf@altera.com> (raw)
In-Reply-To: <20261119-sd_cadence_ddr50_v3-v4-2-95a94a0aaaf3@altera.com>


On 19-11-2026 15:15, tze.yee.ng@altera.com wrote:
> From: Tze Yee Ng <tze.yee.ng@altera.com>
>
> DDR50 has no CMD19 tuning, so the SD6HC read path must be centred by
> static, board/SoC-characterised PHY settings. Add two optional SD6HC
> properties for the extended-read DDR modes (SD DDR50 and eMMC DDR52):
>

I went through the Cadence SD/eMMC DLL PHY IP user guide (IP6185,
rev 1.03) to understand how the delay applies to each of the read
strobes, so that is why this comes up on v4.

The guide marks phony DQS "not used for SD/eMMC" (Fig 2.1), lists
use_lpbk_dqs and use_ext_lpbk_dqs as "Mandatory setting for SD/eMMC",
and says external loopback needs no 1/4 cycle delay on the slave DLL.

Either strobe can capture a DDR read if its edge lands inside the
card's valid data window, but the delay has to be chosen for that
strobe. The delay is what moves the edge into the window, and the two
strobes should not take the same value.

External loopback goes out through the pads and the board and comes
back, so most of the round-trip delay is already in the strobe. It
should need little or no extra delay.

Phony DQS is generated inside the PHY, so none of that round trip is
in it. It likely needs a larger delay to meet data that did travel
through the pads, the board and the card.

Questions:
1. Do DDR50 and DDR52 work with the defaults (loopback DQS, read
    delay 0)? If not, what fails?
2. Did you sweep the read DQS delay with loopback selected?


  parent reply	other threads:[~2026-11-22 19:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  9:45 [PATCH v4 0/3] mmc: sdhci-cadence: SD6HC DDR50/DDR52 read-path tuning and fixes tze.yee.ng
2026-11-19  9:45 ` [PATCH v4 1/3] mmc: sdhci-cadence: abort failed tuning command on SD6HC tze.yee.ng
2026-11-19  9:45 ` [PATCH v4 2/3] dt-bindings: mmc: cdns,sd6hc: add SD6HC DDR50 read-path tuning tze.yee.ng
2026-11-22 16:03   ` Krzysztof Kozlowski
2026-11-22 19:05   ` Kathpalia, Tanmay [this message]
2026-11-19  9:45 ` [PATCH v4 3/3] mmc: sdhci-cadence6: tune SD6HC DDR50/DDR52 read path tze.yee.ng
2026-11-22 19:06   ` Kathpalia, Tanmay
2026-11-22 16:03 ` [PATCH v4 0/3] mmc: sdhci-cadence: SD6HC DDR50/DDR52 read-path tuning and fixes Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5de1ad0d-ef89-49e4-9195-195be48d57bf@altera.com \
    --to=tanmay.kathpalia@altera.com \
    --cc=adrian.hunter@intel.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=tze.yee.ng@altera.com \
    --cc=ulfh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®