* [PATCH v3 0/2] modernize and fix mc13xxx-led driver
@ 2026-11-22 17:06 Alexander Kurz
2026-11-22 17:06 ` [PATCH v3 1/2] leds: mc13783: Use unified device property API Alexander Kurz
2026-11-22 17:06 ` [PATCH v3 2/2] leds: leds-mc13783: enable driver for deferred probe Alexander Kurz
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Kurz @ 2026-11-22 17:06 UTC (permalink / raw)
To: Lee Jones, Pavel Machek, Griffin Kroah-Hartman
Cc: Ilpo Järvinen, Bjorn Helgaas, linux-leds, linux-kernel,
Alexander Kurz
Main goal of this series is a fix enabling deferred probing of the
mc13xxx-led driver. The previous implementation has been dependent
on the MFD instance being present first and which has been changed
by commit 78efa53e715e ("leds: Init leds class earlier"), breaking
functionality. While working on it, replace the OF-specific API
with the newerunified device property API.
Signed-off-by: Alexander Kurz <akurz@blala.de>
---
Changes in v3:
- use dev_fwnode() to check parent availability, replacing dev_of_node().
(Sashiko)
- drop CONFIG_OF guard around mc13xxx_led_probe_dt() as all used. (Sashiko)
implementations should be safe for compilation with CONFIG_OF=n now.
- Link to v2: https://lore.kernel.org/all/20261122073235.26707-1-akurz@blala.de/
Changes in v2:
- removed unintended change of property "led-control" (Sashiko)
- Link to v1: https://lore.kernel.org/all/20261121074239.8745-1-akurz@blala.de/
Alexander Kurz (2):
leds: mc13783: Use unified device property API
leds: leds-mc13783: enable driver for deferred probe
drivers/leds/leds-mc13783.c | 37 +++++++++++++++----------------------
1 file changed, 15 insertions(+), 22 deletions(-)
--
2.39.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v3 1/2] leds: mc13783: Use unified device property API
2026-11-22 17:06 [PATCH v3 0/2] modernize and fix mc13xxx-led driver Alexander Kurz
@ 2026-11-22 17:06 ` Alexander Kurz
2026-11-22 17:06 ` [PATCH v3 2/2] leds: leds-mc13783: enable driver for deferred probe Alexander Kurz
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Kurz @ 2026-11-22 17:06 UTC (permalink / raw)
To: Lee Jones, Pavel Machek, Griffin Kroah-Hartman
Cc: Ilpo Järvinen, Bjorn Helgaas, linux-leds, linux-kernel,
Alexander Kurz
Replace OF-specific API calls with the unified device property variants
and drop the CONFIG_OF-guard around mc13xxx_led_probe_dt() since all used
implementations should be safe for !CONFIG_OF compilation now.
Signed-off-by: Alexander Kurz <akurz@blala.de>
---
drivers/leds/leds-mc13783.c | 30 +++++++++++-------------------
1 file changed, 11 insertions(+), 19 deletions(-)
diff --git a/drivers/leds/leds-mc13783.c b/drivers/leds/leds-mc13783.c
index 19c1b51475db..0882c7f6b649 100644
--- a/drivers/leds/leds-mc13783.c
+++ b/drivers/leds/leds-mc13783.c
@@ -16,8 +16,8 @@
#include <linux/module.h>
#include <linux/kernel.h>
#include <linux/platform_device.h>
+#include <linux/property.h>
#include <linux/leds.h>
-#include <linux/of.h>
#include <linux/mfd/mc13xxx.h>
struct mc13xxx_led_devtype {
@@ -108,13 +108,12 @@ static int mc13xxx_led_set(struct led_classdev *led_cdev,
value << shift);
}
-#ifdef CONFIG_OF
static struct mc13xxx_leds_platform_data __init *mc13xxx_led_probe_dt(
struct platform_device *pdev)
{
struct mc13xxx_leds *leds = platform_get_drvdata(pdev);
struct mc13xxx_leds_platform_data *pdata;
- struct device_node *child;
+ struct fwnode_handle *child;
struct device *dev = &pdev->dev;
int i = 0, ret = -ENODATA;
@@ -122,34 +121,34 @@ static struct mc13xxx_leds_platform_data __init *mc13xxx_led_probe_dt(
if (!pdata)
return ERR_PTR(-ENOMEM);
- struct device_node *parent __free(device_node) =
- of_get_child_by_name(dev_of_node(dev->parent), "leds");
+ struct fwnode_handle *parent __free(fwnode_handle) =
+ device_get_named_child_node(dev->parent, "leds");
if (!parent)
return ERR_PTR(-ENODATA);
- ret = of_property_read_u32_array(parent, "led-control",
+ ret = fwnode_property_read_u32_array(parent, "led-control",
pdata->led_control,
leds->devtype->num_regs);
if (ret)
return ERR_PTR(ret);
- pdata->num_leds = of_get_available_child_count(parent);
+ pdata->num_leds = fwnode_get_child_node_count(parent);
pdata->led = devm_kzalloc_objs(dev, *pdata->led, pdata->num_leds);
if (!pdata->led)
return ERR_PTR(-ENOMEM);
- for_each_available_child_of_node(parent, child) {
+ fwnode_for_each_child_node(parent, child) {
const char *str;
u32 tmp;
- if (of_property_read_u32(child, "reg", &tmp))
+ if (fwnode_property_read_u32(child, "reg", &tmp))
continue;
pdata->led[i].id = leds->devtype->led_min + tmp;
- if (!of_property_read_string(child, "label", &str))
+ if (!fwnode_property_read_string(child, "label", &str))
pdata->led[i].name = str;
- if (!of_property_read_string(child, "linux,default-trigger",
+ if (!fwnode_property_read_string(child, "linux,default-trigger",
&str))
pdata->led[i].default_trigger = str;
@@ -162,13 +161,6 @@ static struct mc13xxx_leds_platform_data __init *mc13xxx_led_probe_dt(
return pdata;
}
-#else
-static inline struct mc13xxx_leds_platform_data __init *mc13xxx_led_probe_dt(
- struct platform_device *pdev)
-{
- return ERR_PTR(-ENOSYS);
-}
-#endif
static int __init mc13xxx_led_probe(struct platform_device *pdev)
{
@@ -189,7 +181,7 @@ static int __init mc13xxx_led_probe(struct platform_device *pdev)
leds->master = mcdev;
platform_set_drvdata(pdev, leds);
- if (dev_of_node(dev->parent)) {
+ if (dev_fwnode(dev->parent)) {
pdata = mc13xxx_led_probe_dt(pdev);
if (IS_ERR(pdata))
return PTR_ERR(pdata);
--
2.39.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v3 2/2] leds: leds-mc13783: enable driver for deferred probe
2026-11-22 17:06 [PATCH v3 0/2] modernize and fix mc13xxx-led driver Alexander Kurz
2026-11-22 17:06 ` [PATCH v3 1/2] leds: mc13783: Use unified device property API Alexander Kurz
@ 2026-11-22 17:06 ` Alexander Kurz
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Kurz @ 2026-11-22 17:06 UTC (permalink / raw)
To: Lee Jones, Pavel Machek, Griffin Kroah-Hartman
Cc: Ilpo Järvinen, Bjorn Helgaas, linux-leds, linux-kernel,
Alexander Kurz
The probe order between mfd and leds has been changed with commit
78efa53e715e ("leds: Init leds class earlier") so that mc13xxx-led
driver was not registered any more due to the missing mfd instance.
Use module_platform_driver() to replace module_platform_driver_probe().
The former utilizes platform_driver_register(), which allows the driver
to defer probing when it doesn't acquire the necessary resources from
the mfd device due to probe order.
Fixes: 78efa53e715e ("leds: Init leds class earlier")
Signed-off-by: Alexander Kurz <akurz@blala.de>
---
drivers/leds/leds-mc13783.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/leds-mc13783.c b/drivers/leds/leds-mc13783.c
index 0882c7f6b649..538f5794410a 100644
--- a/drivers/leds/leds-mc13783.c
+++ b/drivers/leds/leds-mc13783.c
@@ -108,7 +108,7 @@ static int mc13xxx_led_set(struct led_classdev *led_cdev,
value << shift);
}
-static struct mc13xxx_leds_platform_data __init *mc13xxx_led_probe_dt(
+static struct mc13xxx_leds_platform_data *mc13xxx_led_probe_dt(
struct platform_device *pdev)
{
struct mc13xxx_leds *leds = platform_get_drvdata(pdev);
@@ -162,7 +162,7 @@ static struct mc13xxx_leds_platform_data __init *mc13xxx_led_probe_dt(
return pdata;
}
-static int __init mc13xxx_led_probe(struct platform_device *pdev)
+static int mc13xxx_led_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
struct mc13xxx_leds_platform_data *pdata = dev_get_platdata(dev);
@@ -288,13 +288,14 @@ static const struct platform_device_id mc13xxx_led_id_table[] = {
MODULE_DEVICE_TABLE(platform, mc13xxx_led_id_table);
static struct platform_driver mc13xxx_led_driver = {
+ .probe = mc13xxx_led_probe,
.driver = {
.name = "mc13xxx-led",
},
.remove = mc13xxx_led_remove,
.id_table = mc13xxx_led_id_table,
};
-module_platform_driver_probe(mc13xxx_led_driver, mc13xxx_led_probe);
+module_platform_driver(mc13xxx_led_driver);
MODULE_DESCRIPTION("LEDs driver for Freescale MC13XXX PMIC");
MODULE_AUTHOR("Philippe Retornaz <philippe.retornaz@epfl.ch>");
--
2.39.5
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-22 17:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-22 17:06 [PATCH v3 0/2] modernize and fix mc13xxx-led driver Alexander Kurz
2026-11-22 17:06 ` [PATCH v3 1/2] leds: mc13783: Use unified device property API Alexander Kurz
2026-11-22 17:06 ` [PATCH v3 2/2] leds: leds-mc13783: enable driver for deferred probe Alexander Kurz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®