* [PATCH v2 1/2] media: em28xx: defer media_device cleanup and free to em28xx_free_device()
@ 2026-11-22 22:23 Arbab Haider
2026-11-22 22:23 ` [PATCH v2 2/2] media: em28xx: avoid dereferencing dev->intf after disconnect in em28xx_v4l2_close() Arbab Haider
0 siblings, 1 reply; 2+ messages in thread
From: Arbab Haider @ 2026-11-22 22:23 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: linux-media, linux-kernel, stable, Arbab Haider
When a USB em28xx device is disconnected while a V4L2 device node
(e.g. /dev/video0) is still open, em28xx_usb_disconnect() calls
em28xx_release_resources() -> em28xx_unregister_media_device(), which
calls media_device_cleanup() and kfree(dev->media_dev) immediately.
However, struct em28xx_v4l2 remains alive until the last open file
handle is closed, and v4l2->v4l2_dev.mdev still points to the freed
media_device. When userspace subsequently closes /dev/video0,
v4l2_release() calls v4l2_device_supports_requests(vdev->v4l2_dev),
dereferencing vdev->v4l2_dev->mdev->ops and triggering a KASAN
slab-use-after-free:
BUG: KASAN: slab-use-after-free in v4l2_release+0x325/0x380
Read of size 8 at addr ffff88800787a260 by task test_em28xx_uaf/53
...
Freed by task 30:
kfree+0x162/0x410
em28xx_unregister_media_device+0xa4/0xe0
em28xx_release_resources+0x70/0x170
em28xx_usb_disconnect.cold+0x107/0x2a3
Split em28xx_unregister_media_device() so it only calls
media_device_unregister(dev->media_dev) on disconnect, and move
media_device_cleanup() and kfree(dev->media_dev) into a new
em28xx_cleanup_media_device() helper called from em28xx_free_device()
(once the last dev->ref reference, including em28xx_free_v4l2(), has
been dropped) and from em28xx_init_dev()'s error path.
Tested locally in QEMU (x86_64, KASAN+UBSAN) using dummy_hcd and
raw-gadget emulating an EM2820 device across open->disconnect->close,
repeated disconnect, dual-fd open->disconnect->close, and normal
open->close->disconnect scenarios (8/8 passed, 0 KASAN reports).
Fixes: 37ecc7b1278f ("[media] em28xx: add media controller support")
Cc: stable@vger.kernel.org
Signed-off-by: Arbab Haider <arbabhaider649@gmail.com>
---
Changes in v2:
- Add Fixes: tag as requested by Media CI.
drivers/media/usb/em28xx/em28xx-cards.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/media/usb/em28xx/em28xx-cards.c b/drivers/media/usb/em28xx/em28xx-cards.c
index 1d4f30cba..d8f2e40b7 100644
--- a/drivers/media/usb/em28xx/em28xx-cards.c
+++ b/drivers/media/usb/em28xx/em28xx-cards.c
@@ -3773,8 +3773,15 @@ static int em28xx_media_device_init(struct em28xx *dev,
static void em28xx_unregister_media_device(struct em28xx *dev)
{
#ifdef CONFIG_MEDIA_CONTROLLER
- if (dev->media_dev) {
+ if (dev->media_dev)
media_device_unregister(dev->media_dev);
+#endif
+}
+
+static void em28xx_cleanup_media_device(struct em28xx *dev)
+{
+#ifdef CONFIG_MEDIA_CONTROLLER
+ if (dev->media_dev) {
media_device_cleanup(dev->media_dev);
kfree(dev->media_dev);
dev->media_dev = NULL;
@@ -3826,6 +3833,8 @@ void em28xx_free_device(struct kref *ref)
if (!dev->disconnected)
em28xx_release_resources(dev);
+ em28xx_cleanup_media_device(dev);
+
if (dev->ts == PRIMARY_TS)
kfree(dev->alt_max_pkt_size_isoc);
@@ -3997,6 +4006,7 @@ static int em28xx_init_dev(struct em28xx *dev, struct usb_device *udev,
em28xx_i2c_unregister(dev, 0);
err_deinit_media:
em28xx_unregister_media_device(dev);
+ em28xx_cleanup_media_device(dev);
return retval;
}
--
2.53.0
^ permalink raw reply [flat|nested] 2+ messages in thread* [PATCH v2 2/2] media: em28xx: avoid dereferencing dev->intf after disconnect in em28xx_v4l2_close()
2026-11-22 22:23 [PATCH v2 1/2] media: em28xx: defer media_device cleanup and free to em28xx_free_device() Arbab Haider
@ 2026-11-22 22:23 ` Arbab Haider
0 siblings, 0 replies; 2+ messages in thread
From: Arbab Haider @ 2026-11-22 22:23 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: linux-media, linux-kernel, stable, Arbab Haider
em28xx_v4l2_close() unconditionally evaluates
interface_to_usbdev(dev->intf) at function entry, before acquiring
dev->lock and checking dev->disconnected.
If the USB device was disconnected while /dev/video0 was still open,
struct usb_interface (dev->intf) has already been freed by
usb_disable_device() -> device_release(), so closing the file handle
triggers a KASAN slab-use-after-free:
BUG: KASAN: slab-use-after-free in em28xx_v4l2_close+0x37c/0x3a0
Read of size 8 at addr ffff888007245890 by task test_em28xx_uaf/71
...
Freed by task 10:
kfree+0x162/0x410
device_release+0xca/0x250
kobject_put+0x152/0x2f0
usb_disable_device+0x324/0x570
usb_disconnect+0x271/0x950
Move the interface_to_usbdev(dev->intf) lookup after the
dev->disconnected check under dev->lock, right before its only user
usb_set_interface().
Tested locally in QEMU (x86_64, KASAN+UBSAN) using dummy_hcd and
raw-gadget emulating an EM2820 device across open->disconnect->close,
repeated disconnect, dual-fd open->disconnect->close, and normal
open->close->disconnect scenarios (8/8 passed, 0 KASAN reports).
Fixes: c6d48134cb26 ("[media] em28xx: don't store usb_device at struct em28xx")
Cc: stable@vger.kernel.org
Signed-off-by: Arbab Haider <arbabhaider649@gmail.com>
---
Changes in v2:
- Add Fixes: tag as requested by Media CI.
drivers/media/usb/em28xx/em28xx-video.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/usb/em28xx/em28xx-video.c b/drivers/media/usb/em28xx/em28xx-video.c
index 84424284d..854fcc897 100644
--- a/drivers/media/usb/em28xx/em28xx-video.c
+++ b/drivers/media/usb/em28xx/em28xx-video.c
@@ -2503,7 +2503,6 @@ static int em28xx_v4l2_close(struct file *filp)
struct video_device *vdev = video_devdata(filp);
struct em28xx *dev = video_drvdata(filp);
struct em28xx_v4l2 *v4l2 = dev->v4l2;
- struct usb_device *udev = interface_to_usbdev(dev->intf);
int err;
bool last_user;
@@ -2512,6 +2511,8 @@ static int em28xx_v4l2_close(struct file *filp)
_vb2_fop_release(filp, vdev->queue->lock);
if (last_user) {
+ struct usb_device *udev;
+
/* No sense to try to write to the device */
if (dev->disconnected)
goto exit;
@@ -2525,6 +2526,7 @@ static int em28xx_v4l2_close(struct file *filp)
/* set alternate 0 */
dev->alt = 0;
em28xx_videodbg("setting alternate 0\n");
+ udev = interface_to_usbdev(dev->intf);
err = usb_set_interface(udev, 0, 0);
if (err < 0) {
dev_err(&dev->intf->dev,
--
2.53.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-22 22:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-22 22:23 [PATCH v2 1/2] media: em28xx: defer media_device cleanup and free to em28xx_free_device() Arbab Haider
2026-11-22 22:23 ` [PATCH v2 2/2] media: em28xx: avoid dereferencing dev->intf after disconnect in em28xx_v4l2_close() Arbab Haider
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®