From: David Howells <dhowells@redhat.com>
To: Eric Snowberg <eric.snowberg@oracle.com>
Cc: dhowells@redhat.com, rdunlap@infradead.org, dwmw2@infradead.org,
keyrings@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] certs: Fix wrong kconfig option used for x509_revocation_list
Date: Wed, 03 Mar 2021 09:24:41 +0000 [thread overview]
Message-ID: <2033457.1614763481@warthog.procyon.org.uk> (raw)
In-Reply-To: <20210303034418.106762-1-eric.snowberg@oracle.com>
Eric Snowberg <eric.snowberg@oracle.com> wrote:
> +ifeq ($(CONFIG_SYSTEM_REVOCATION_LIST),y)
> +obj-$(CONFIG_SYSTEM_BLACKLIST_KEYRING) += revocation_certificates.o
> +endif
Should the ifeq be referring to CONFIG_SYSTEM_REVOCATION_KEYS rather than
CONFIG_SYSTEM_REVOCATION_LIST? In fact, since S_R_K depends indirectly on
S_B_K, you should be able to just do:
+obj-$(CONFIG_SYSTEM_REVOCATION_KEYS) += revocation_certificates.o
> +#ifdef CONFIG_SYSTEM_REVOCATION_LIST
Here also?
> + hostprogs-always-$(CONFIG_SYSTEM_BLACKLIST_KEYRING) += extract-cert
And here too?
(As an aside, I wonder if SYSTEM_REVOCATION_CERTS would be a better name, but
I'm okay with leaving it as-is for now).
David
next prev parent reply other threads:[~2021-03-03 15:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 3:44 Eric Snowberg
2021-03-03 9:24 ` David Howells [this message]
2021-03-04 2:45 ` Eric Snowberg
2021-03-04 15:25 ` David Howells
2021-03-04 4:38 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2033457.1614763481@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=eric.snowberg@oracle.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®