mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] arm64: dts: qcom: sdm845: move WCD9340 codec to separate file
Date: Mon, 16 Jan 2023 08:58:20 +0100	[thread overview]
Message-ID: <20385103-2217-a5d0-6355-802bc87ec888@linaro.org> (raw)
In-Reply-To: <CAA8EJpr+0fnhy+aHwmdKQA_xk2Qkse0L5u8JdCJNDZqqdYwhrg@mail.gmail.com>

On 16/01/2023 06:55, Dmitry Baryshkov wrote:
> On Sun, 15 Jan 2023 at 13:21, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 14/01/2023 21:33, Konrad Dybcio wrote:
>>>
>>>
>>> On 13.01.2023 17:22, Krzysztof Kozlowski wrote:
>>>> WCD9340 codec node is not a property of the SoC, but board.  Move it to
>>>> separate file and include it in the specific boards.  On all others,
>>>> keep the Slimbus node disabled as it is empty.
>>>>
>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>> ---
>>> Generally this should be SoC-independent, for example some newer
>>> MSM8998 devices shipped with the 9340 codec that most 845 devices
>>> used, but earlier ones used the WCD9335 found on MSM8996
>>
>> OK, but I don't get if you expect me to change anything?
> 
> Maybe it might make sense to name new include file just 'wcd9340.dtsi'
> rather than 'sdm845-somthing.dtsi'? Same applies to the wcd9335 codec
> found in msm8996.dtsi, if you are going to extract it too.

Ah, then I vote against, because it is not only codec, but also it's bus
attachment. It cannot be re-used on other devices.

Same approach with sc7280 audios - not re-usable for other SoCs.

Best regards,
Krzysztof


  reply	other threads:[~2023-01-16  7:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-13 16:22 [PATCH 1/6] arm64: dts: qcom: sm8250: drop unused clock-frequency from rx-macro Krzysztof Kozlowski
2023-01-13 16:22 ` [PATCH 2/6] arm64: dts: qcom: sdm845: move WCD9340 codec to separate file Krzysztof Kozlowski
2023-01-14 20:33   ` Konrad Dybcio
2023-01-15 11:21     ` Krzysztof Kozlowski
2023-01-16  5:55       ` Dmitry Baryshkov
2023-01-16  7:58         ` Krzysztof Kozlowski [this message]
2023-01-16  8:56           ` Konrad Dybcio
2023-01-16  8:54         ` Konrad Dybcio
2023-01-17  3:56   ` Bjorn Andersson
2023-01-17  7:51     ` Krzysztof Kozlowski
2023-01-13 16:22 ` [PATCH 3/6] arm64: dts: qcom: sdm845-audio-wcd9340: commonize pinctrl Krzysztof Kozlowski
2023-01-14 20:33   ` Konrad Dybcio
2023-01-13 16:22 ` [PATCH 4/6] arm64: dts: qcom: sdm845-audio-wcd9340: commonize clocks Krzysztof Kozlowski
2023-01-14 20:34   ` Konrad Dybcio
2023-01-13 16:22 ` [PATCH 5/6] arm64: dts: qcom: sc8280xp: drop bogus clock-controller property Krzysztof Kozlowski
2023-01-13 16:22 ` [PATCH 6/6] arm64: dts: qcom: sc8280xp: drop unused properties from tx-macro Krzysztof Kozlowski
2023-01-14 20:34   ` Konrad Dybcio
2023-01-14 20:32 ` [PATCH 1/6] arm64: dts: qcom: sm8250: drop unused clock-frequency from rx-macro Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20385103-2217-a5d0-6355-802bc87ec888@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®