From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] arm64: dts: qcom: sdm845: move WCD9340 codec to separate file
Date: Tue, 17 Jan 2023 08:51:41 +0100 [thread overview]
Message-ID: <948d6fec-12e3-f4e6-8024-d444e5a41df5@linaro.org> (raw)
In-Reply-To: <20230117035631.cgi6fjdrpz5eppca@builder.lan>
On 17/01/2023 04:56, Bjorn Andersson wrote:
> On Fri, Jan 13, 2023 at 05:22:41PM +0100, Krzysztof Kozlowski wrote:
>> WCD9340 codec node is not a property of the SoC, but board. Move it to
>> separate file and include it in the specific boards. On all others,
>> keep the Slimbus node disabled as it is empty.
>>
>
> I think this seems like a reasonable idea. But without clearly
> documenting your intentions/guidelines we will soon have
> sdm845-display.dtsi, sdm845-pcie.dtsi etc.
>
> So please start there.
You said like this started the process but it is already there for
sc7280. Where do you want to store such documentation? In commit msg?
>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> .../boot/dts/qcom/sdm845-audio-wcd9340.dtsi | 69 +++++++++++++++++++
>> arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 1 +
>> .../qcom/sdm845-xiaomi-beryllium-common.dtsi | 1 +
>> .../boot/dts/qcom/sdm845-xiaomi-polaris.dts | 1 +
>> arch/arm64/boot/dts/qcom/sdm845.dtsi | 60 +---------------
>> .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 1 +
>> .../boot/dts/qcom/sdm850-samsung-w737.dts | 1 +
>> 7 files changed, 75 insertions(+), 59 deletions(-)
>> create mode 100644 arch/arm64/boot/dts/qcom/sdm845-audio-wcd9340.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-audio-wcd9340.dtsi b/arch/arm64/boot/dts/qcom/sdm845-audio-wcd9340.dtsi
>> new file mode 100644
>> index 000000000000..5bcce7d0d709
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-audio-wcd9340.dtsi
>
> Why does this include the substring "audio"?
To indicate it covers entire audio, which points me to the fact that
probably I can also move there sound node.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-17 7:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 16:22 [PATCH 1/6] arm64: dts: qcom: sm8250: drop unused clock-frequency from rx-macro Krzysztof Kozlowski
2023-01-13 16:22 ` [PATCH 2/6] arm64: dts: qcom: sdm845: move WCD9340 codec to separate file Krzysztof Kozlowski
2023-01-14 20:33 ` Konrad Dybcio
2023-01-15 11:21 ` Krzysztof Kozlowski
2023-01-16 5:55 ` Dmitry Baryshkov
2023-01-16 7:58 ` Krzysztof Kozlowski
2023-01-16 8:56 ` Konrad Dybcio
2023-01-16 8:54 ` Konrad Dybcio
2023-01-17 3:56 ` Bjorn Andersson
2023-01-17 7:51 ` Krzysztof Kozlowski [this message]
2023-01-13 16:22 ` [PATCH 3/6] arm64: dts: qcom: sdm845-audio-wcd9340: commonize pinctrl Krzysztof Kozlowski
2023-01-14 20:33 ` Konrad Dybcio
2023-01-13 16:22 ` [PATCH 4/6] arm64: dts: qcom: sdm845-audio-wcd9340: commonize clocks Krzysztof Kozlowski
2023-01-14 20:34 ` Konrad Dybcio
2023-01-13 16:22 ` [PATCH 5/6] arm64: dts: qcom: sc8280xp: drop bogus clock-controller property Krzysztof Kozlowski
2023-01-13 16:22 ` [PATCH 6/6] arm64: dts: qcom: sc8280xp: drop unused properties from tx-macro Krzysztof Kozlowski
2023-01-14 20:34 ` Konrad Dybcio
2023-01-14 20:32 ` [PATCH 1/6] arm64: dts: qcom: sm8250: drop unused clock-frequency from rx-macro Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=948d6fec-12e3-f4e6-8024-d444e5a41df5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®