mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] scsi: ufs: Move UFS trace events to private header
@ 2024-08-20  3:58 Avri Altman
  2024-08-20  6:30 ` Johannes Thumshirn
  2024-08-20 21:45 ` Bart Van Assche
  0 siblings, 2 replies; 4+ messages in thread
From: Avri Altman @ 2024-08-20  3:58 UTC (permalink / raw)
  To: Martin K . Petersen; +Cc: linux-scsi, linux-kernel, Avri Altman

ufs trace events are called exclusively from the ufs core drivers.  Make
those events privet to the core driver.

The MAINTAINERS file does not need updating as the maintainership
remains the same and the relevant directory is already covered.

Signed-off-by: Avri Altman <avri.altman@wdc.com>
---
 include/trace/events/ufs.h => drivers/ufs/core/ufs_trace.h | 6 ++++++
 drivers/ufs/core/ufshcd.c                                  | 2 +-
 include/ufs/ufs.h                                          | 4 ++--
 3 files changed, 9 insertions(+), 3 deletions(-)
 rename include/trace/events/ufs.h => drivers/ufs/core/ufs_trace.h (98%)

diff --git a/include/trace/events/ufs.h b/drivers/ufs/core/ufs_trace.h
similarity index 98%
rename from include/trace/events/ufs.h
rename to drivers/ufs/core/ufs_trace.h
index c4e209fbdfbb..84deca2b841d 100644
--- a/include/trace/events/ufs.h
+++ b/drivers/ufs/core/ufs_trace.h
@@ -9,6 +9,7 @@
 #if !defined(_TRACE_UFS_H) || defined(TRACE_HEADER_MULTI_READ)
 #define _TRACE_UFS_H
 
+#include <ufs/ufs.h>
 #include <linux/tracepoint.h>
 
 #define str_opcode(opcode)						\
@@ -395,5 +396,10 @@ TRACE_EVENT(ufshcd_exception_event,
 
 #endif /* if !defined(_TRACE_UFS_H) || defined(TRACE_HEADER_MULTI_READ) */
 
+#undef TRACE_INCLUDE_PATH
+#define TRACE_INCLUDE_PATH ../../drivers/ufs/core
+#undef TRACE_INCLUDE_FILE
+#define TRACE_INCLUDE_FILE ufs_trace
+
 /* This part must be outside protection */
 #include <trace/define_trace.h>
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 0dd26059f5d7..db30d0c4d91e 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -39,7 +39,7 @@
 #include <asm/unaligned.h>
 
 #define CREATE_TRACE_POINTS
-#include <trace/events/ufs.h>
+#include "ufs_trace.h"
 
 #define UFSHCD_ENABLE_INTRS	(UTP_TRANSFER_REQ_COMPL |\
 				 UTP_TASK_REQ_COMPL |\
diff --git a/include/ufs/ufs.h b/include/ufs/ufs.h
index 853e95957c31..e594abe5d05f 100644
--- a/include/ufs/ufs.h
+++ b/include/ufs/ufs.h
@@ -597,7 +597,7 @@ struct ufs_dev_info {
 };
 
 /*
- * This enum is used in string mapping in include/trace/events/ufs.h.
+ * This enum is used in string mapping in ufs_trace.h.
  */
 enum ufs_trace_str_t {
 	UFS_CMD_SEND, UFS_CMD_COMP, UFS_DEV_COMP,
@@ -607,7 +607,7 @@ enum ufs_trace_str_t {
 
 /*
  * Transaction Specific Fields (TSF) type in the UPIU package, this enum is
- * used in include/trace/events/ufs.h for UFS command trace.
+ * used in ufs_trace.h for UFS command trace.
  */
 enum ufs_trace_tsf_t {
 	UFS_TSF_CDB, UFS_TSF_OSF, UFS_TSF_TM_INPUT, UFS_TSF_TM_OUTPUT
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] scsi: ufs: Move UFS trace events to private header
  2024-08-20  3:58 [PATCH] scsi: ufs: Move UFS trace events to private header Avri Altman
@ 2024-08-20  6:30 ` Johannes Thumshirn
  2024-08-20  9:10   ` Avri Altman
  2024-08-20 21:45 ` Bart Van Assche
  1 sibling, 1 reply; 4+ messages in thread
From: Johannes Thumshirn @ 2024-08-20  6:30 UTC (permalink / raw)
  To: Avri Altman, Martin K . Petersen; +Cc: linux-scsi, linux-kernel

On 20.08.24 06:01, Avri Altman wrote:
> ufs trace events are called exclusively from the ufs core drivers.  Make
> those events privet to the core driver.
private


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH] scsi: ufs: Move UFS trace events to private header
  2024-08-20  6:30 ` Johannes Thumshirn
@ 2024-08-20  9:10   ` Avri Altman
  0 siblings, 0 replies; 4+ messages in thread
From: Avri Altman @ 2024-08-20  9:10 UTC (permalink / raw)
  To: Johannes Thumshirn, Martin K . Petersen; +Cc: linux-scsi, linux-kernel

> On 20.08.24 06:01, Avri Altman wrote:
> > ufs trace events are called exclusively from the ufs core drivers.
> > Make those events privet to the core driver.
> private
Thanks.  Done.

Thanks,
Avri

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] scsi: ufs: Move UFS trace events to private header
  2024-08-20  3:58 [PATCH] scsi: ufs: Move UFS trace events to private header Avri Altman
  2024-08-20  6:30 ` Johannes Thumshirn
@ 2024-08-20 21:45 ` Bart Van Assche
  1 sibling, 0 replies; 4+ messages in thread
From: Bart Van Assche @ 2024-08-20 21:45 UTC (permalink / raw)
  To: Avri Altman, Martin K . Petersen; +Cc: linux-scsi, linux-kernel

On 8/19/24 8:58 PM, Avri Altman wrote:
> ufs trace events are called exclusively from the ufs core drivers.  Make
> those events privet to the core driver.

Once the spelling of "private" is corrected, feel free to add:

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-08-20 21:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-20  3:58 [PATCH] scsi: ufs: Move UFS trace events to private header Avri Altman
2024-08-20  6:30 ` Johannes Thumshirn
2024-08-20  9:10   ` Avri Altman
2024-08-20 21:45 ` Bart Van Assche

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®