[PATCH] platform/x86/amd/pmc: Add spurious_8042 to ASUS ROG Flow Z13 GZ302EA

[PATCH] platform/x86/amd/pmc: Add spurious_8042 to ASUS ROG Flow Z13 GZ302EA

[Matthew Schwartz]

The ASUS ROG Flow Z13 (GZ302EA/GZ302EAC) wakes up from suspend-to-idle
without any user input. With PM debug messages enabled, each unexpected
wakeup shows the EC raising IRQ1 at the same time as the ACPI SCI:

  PM: Triggering wakeup from IRQ 9
  PM: Triggering wakeup from IRQ 1
  ACPI: EC: Query(0xa3) started
  ACPI: PM: Wakeup after ACPI Notify sync

EC query 0xa3 only notifies the battery of a status change, which
happens when it transitions between Charging and Full while on AC.
The ACPI core correctly treats that as a non-wakeup event and cancels
the SCI wakeup, but the IRQ1 wakeup remains pending and resumes the
system. i8042 debugging confirms that the keyboard controller has no
data at that point ("Interrupt 1, without any data").

The detachable keyboard on this device is a USB device, so disabling
the i8042 wakeup source does not result in any functional loss. With
serio0 wakeup disabled, the same battery event is processed during
suspend-to-idle and the system stays asleep.

Add the spurious_8042 quirk for it. The GZ302EAC reports sys_vendor
"ASUS" while the GZ302EA reports "ASUSTeK COMPUTER INC.", so match on
"ASUS" and on the "GZ302EA" board name to cover both models.

Signed-off-by: Matthew Schwartz <matthew.schwartz@linux.dev>
---
 drivers/platform/x86/amd/pmc/pmc-quirks.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/platform/x86/amd/pmc/pmc-quirks.c b/drivers/platform/x86/amd/pmc/pmc-quirks.c
index 09a30f333759..ff5c90510c0c 100644
--- a/drivers/platform/x86/amd/pmc/pmc-quirks.c
+++ b/drivers/platform/x86/amd/pmc/pmc-quirks.c
@@ -143,6 +143,14 @@ static const struct dmi_system_id fwbug_list[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "RC73YA"),
 		}
 	},
+	{
+		.ident = "ASUS ROG Flow Z13 GZ302EA",
+		.driver_data = &quirk_spurious_8042,
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUS"),
+			DMI_MATCH(DMI_BOARD_NAME, "GZ302EA"),
+		}
+	},
 	/* https://bugzilla.kernel.org/show_bug.cgi?id=218024 */
 	{
 		.ident = "V14 G4 AMN",
-- 
2.55.0

Re: [PATCH] platform/x86/amd/pmc: Add spurious_8042 to ASUS ROG Flow Z13 GZ302EA

[Mario Limonciello]

On 9/29/26 13:16, Matthew Schwartz wrote:
> The ASUS ROG Flow Z13 (GZ302EA/GZ302EAC) wakes up from suspend-to-idle
> without any user input. With PM debug messages enabled, each unexpected
> wakeup shows the EC raising IRQ1 at the same time as the ACPI SCI:
> 
>    PM: Triggering wakeup from IRQ 9
>    PM: Triggering wakeup from IRQ 1
>    ACPI: EC: Query(0xa3) started
>    ACPI: PM: Wakeup after ACPI Notify sync
> 
> EC query 0xa3 only notifies the battery of a status change, which
> happens when it transitions between Charging and Full while on AC.
> The ACPI core correctly treats that as a non-wakeup event and cancels
> the SCI wakeup, but the IRQ1 wakeup remains pending and resumes the
> system. i8042 debugging confirms that the keyboard controller has no
> data at that point ("Interrupt 1, without any data").
> 
> The detachable keyboard on this device is a USB device, so disabling
> the i8042 wakeup source does not result in any functional loss. With
> serio0 wakeup disabled, the same battery event is processed during
> suspend-to-idle and the system stays asleep.
> 
> Add the spurious_8042 quirk for it. The GZ302EAC reports sys_vendor
> "ASUS" while the GZ302EA reports "ASUSTeK COMPUTER INC.", so match on
> "ASUS" and on the "GZ302EA" board name to cover both models.
> 
> Signed-off-by: Matthew Schwartz <matthew.schwartz@linux.dev>

Good analysis of this issue.  It sounds like the right direction for 
this problem.

Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>

> ---
>   drivers/platform/x86/amd/pmc/pmc-quirks.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/platform/x86/amd/pmc/pmc-quirks.c b/drivers/platform/x86/amd/pmc/pmc-quirks.c
> index 09a30f333759..ff5c90510c0c 100644
> --- a/drivers/platform/x86/amd/pmc/pmc-quirks.c
> +++ b/drivers/platform/x86/amd/pmc/pmc-quirks.c
> @@ -143,6 +143,14 @@ static const struct dmi_system_id fwbug_list[] = {
>   			DMI_MATCH(DMI_BOARD_NAME, "RC73YA"),
>   		}
>   	},
> +	{
> +		.ident = "ASUS ROG Flow Z13 GZ302EA",
> +		.driver_data = &quirk_spurious_8042,
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "ASUS"),
> +			DMI_MATCH(DMI_BOARD_NAME, "GZ302EA"),
> +		}
> +	},
>   	/* https://bugzilla.kernel.org/show_bug.cgi?id=218024 */
>   	{
>   		.ident = "V14 G4 AMN",