From: Markus Elfring <Markus.Elfring@web.de>
To: Corey Minyard <cminyard@mvista.com>,
Jing Xiangfeng <jingxiangfeng@huawei.com>,
openipmi-developer@lists.sourceforge.net
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>, Corey Minyard <minyard@acm.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] ipmi: Remove duplicate code in __ipmi_bmc_register()
Date: Mon, 20 Jul 2020 14:07:50 +0200 [thread overview]
Message-ID: <2084072d-e16c-d47c-6eed-f47e8f149c44@web.de> (raw)
> > __ipmi_bmc_register() jumps to the label 'out_free_my_dev_name' in an
> > error path. So we can remove duplicate code in the if (rv).
>
> Looks correct, queued for next release.
1. Can an imperative wording be preferred for the change description?
2. Will the tag “Fixes” become helpful for the commit message?
3. Did you avoid a typo in the patch subject?
Regards,
Markus
next reply other threads:[~2020-07-20 12:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 12:07 Markus Elfring [this message]
2020-07-20 12:47 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2084072d-e16c-d47c-6eed-f47e8f149c44@web.de \
--to=markus.elfring@web.de \
--cc=arnd@arndb.de \
--cc=cminyard@mvista.com \
--cc=gregkh@linuxfoundation.org \
--cc=jingxiangfeng@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®