mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Corey Minyard <cminyard@mvista.com>,
	Jing Xiangfeng <jingxiangfeng@huawei.com>,
	openipmi-developer@lists.sourceforge.net,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	Arnd Bergmann <arnd@arndb.de>, Corey Minyard <minyard@acm.org>
Subject: Re: [PATCH] ipmi: Remove duplicate code in __ipmi_bmc_register()
Date: Mon, 20 Jul 2020 14:47:24 +0200	[thread overview]
Message-ID: <20200720124724.GA4085046@kroah.com> (raw)
In-Reply-To: <2084072d-e16c-d47c-6eed-f47e8f149c44@web.de>

On Mon, Jul 20, 2020 at 02:07:50PM +0200, Markus Elfring wrote:
> > > __ipmi_bmc_register() jumps to the label 'out_free_my_dev_name' in an
> > > error path. So we can remove duplicate code in the if (rv).
> >
> > Looks correct, queued for next release.
> 
> 1. Can an imperative wording be preferred for the change description?
> 
> 2. Will the tag “Fixes” become helpful for the commit message?
> 
> 3. Did you avoid a typo in the patch subject?
> 
> Regards,
> Markus

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot

      reply	other threads:[~2020-07-20 12:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-20 12:07 Markus Elfring
2020-07-20 12:47 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200720124724.GA4085046@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Markus.Elfring@web.de \
    --cc=arnd@arndb.de \
    --cc=cminyard@mvista.com \
    --cc=jingxiangfeng@huawei.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minyard@acm.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome