mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] cast arguments to pr_debug() properly
@ 2006-02-06  2:56 Michael Richardson
  0 siblings, 0 replies; only message in thread
From: Michael Richardson @ 2006-02-06  2:56 UTC (permalink / raw)
  To: alan; +Cc: linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1114 bytes --]


This does not show up unless you #define DEBUG in the file, which most
people wouldn't do. On PPC405, at least, "sector_t" is unsigned long,
which doesn't match %llx/%llu. Since sector# may well be >32 bits,
promote the value to match the format.

Signed-off-by: Michael Richardson <mcr@xelerance.com>

diff --git a/drivers/ide/ide-disk.c b/drivers/ide/ide-disk.c
index 449522f..0e1e0dd 100644
--- a/drivers/ide/ide-disk.c
+++ b/drivers/ide/ide-disk.c
@@ -190,7 +190,7 @@ static ide_startstop_t __ide_do_rw_disk(
 		if (lba48) {
 			task_ioreg_t tasklets[10];
 
-			pr_debug("%s: LBA=0x%012llx\n", drive->name, block);
+			pr_debug("%s: LBA=0x%012llx\n", drive->name, (unsigned long long)block);
 
 			tasklets[0] = 0;
 			tasklets[1] = 0;
@@ -317,7 +317,7 @@ static ide_startstop_t ide_do_rw_disk (i
 
 	pr_debug("%s: %sing: block=%llu, sectors=%lu, buffer=0x%08lx\n",
 		 drive->name, rq_data_dir(rq) == READ ? "read" : "writ",
-		 block, rq->nr_sectors, (unsigned long)rq->buffer);
+		 (unsigned long long)block, rq->nr_sectors, (unsigned long)rq->buffer);
 
 	if (hwif->rw_disk)
 		hwif->rw_disk(drive, rq);


[-- Attachment #2: Type: application/pgp-signature, Size: 480 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-02-06  2:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-02-06  2:56 [PATCH] cast arguments to pr_debug() properly Michael Richardson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®