Re: [PATCH] ledtrig-cpu: use spin_lock to replace mutex lock

["Rafael J. Wysocki" <rjw@sisk.pl>]

On Monday 22 of October 2012 11:59:19 Bryan Wu wrote:
> Hiya,
> 
> Can I get some Acked or Tested-by from Rafael or Miles before I put it
> in my linux-leds tree?

Well, I just explained why the current code didn't work. :-)

Anyway, please feel free to add

Acked-by: Rafael J. Wysocki <rjw@sisk.pl>

to the patch (assuming that the performance impact is negligible).

Thanks,
Rafael


> On Thu, Oct 18, 2012 at 12:34 PM, Bryan Wu <cooloney@gmail.com> wrote:
> > On Thu, Oct 18, 2012 at 11:35 AM, Linus Walleij
> > <linus.walleij@linaro.org> wrote:
> >> On Thu, Oct 18, 2012 at 8:18 PM, Bryan Wu <cooloney@gmail.com> wrote:
> >>
> >>> Mutex lock is not safe in atomic context like the bug reported by
> >>> Miles Lane:
> >> (...)
> >>> This patch replace mutex lock with spin lock which is safe for this case.
> >>>
> >>> Reported-by: Miles Lane <miles.lane@gmail.com>
> >>> Reported-by: Rafael J. Wysocki <rjw@sisk.pl>
> >>> Cc: Linus Walleij <linus.walleij@linaro.org>
> >>> Signed-off-by: Bryan Wu <cooloney@gmail.com>
> >>
> >> Looks correct to me:
> >> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> >>
> >
> > Thanks, Linus.
> >
> > Miles, could you please help to try this patch on your testing system?
> > I really appreciate it.
> >
> > -Bryan
> 
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.