From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Bryan Wu <cooloney@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Miles Lane <miles.lane@gmail.com>,
akpm <akpm@linux-foundation.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ledtrig-cpu: use spin_lock to replace mutex lock
Date: Tue, 23 Oct 2012 02:27:08 +0200 [thread overview]
Message-ID: <3676680.un0SjMjRh0@vostro.rjw.lan> (raw)
In-Reply-To: <CAK5ve-L=sRNGYxsEjuJZrPYszLAgBXEfPfkLnLdHmxfnyCRnDA@mail.gmail.com>
On Monday 22 of October 2012 16:15:58 Bryan Wu wrote:
> On Mon, Oct 22, 2012 at 3:38 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > On Monday 22 of October 2012 11:59:19 Bryan Wu wrote:
> >> Hiya,
> >>
> >> Can I get some Acked or Tested-by from Rafael or Miles before I put it
> >> in my linux-leds tree?
> >
> > Well, I just explained why the current code didn't work. :-)
> >
> > Anyway, please feel free to add
> >
> > Acked-by: Rafael J. Wysocki <rjw@sisk.pl>
> >
>
> I was just reminded by Nathan Lynch <ntl@pobox.com> most of
> led-trigger API like register/unregister/event are potentially sleep.
> They should not be used in atomic context. Any suggestion to fix it?
Well, design ledtrig_cpu_syscore_suspend() so that it can be called from
atomic context? You can use the observation that no locking is necessary
in that routine to simplify it, perhaps.
Thanks,
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2012-10-23 0:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 18:18 Bryan Wu
2012-10-18 18:22 ` Bryan Wu
2012-10-18 18:35 ` Linus Walleij
2012-10-18 19:34 ` Bryan Wu
2012-10-22 18:59 ` Bryan Wu
2012-10-22 22:38 ` Rafael J. Wysocki
2012-10-22 23:15 ` Bryan Wu
2012-10-23 0:27 ` Rafael J. Wysocki [this message]
2012-10-22 22:28 ` Nathan Lynch
2012-10-22 23:12 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3676680.un0SjMjRh0@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=akpm@linux-foundation.org \
--cc=cooloney@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=miles.lane@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®