mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: CK Hu <ck.hu@mediatek.com>
To: Bo-Chen Chen <rex-bc.chen@mediatek.com>,
	<chunkuang.hu@kernel.org>, <p.zabel@pengutronix.de>,
	<daniel@ffwll.ch>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <matthias.bgg@gmail.com>,
	<airlied@linux.ie>
Cc: <msp@baylibre.com>, <granquet@baylibre.com>,
	<jitao.shi@mediatek.com>, <wenst@chromium.org>,
	<angelogioacchino.delregno@collabora.com>,
	<xinlei.lee@mediatek.com>, <liangxu.xu@mediatek.com>,
	<dri-devel@lists.freedesktop.org>,
	<linux-mediatek@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH v15 04/16] drm/mediatek: dpi: Remove output format of YUV
Date: Tue, 5 Jul 2022 11:48:31 +0800	[thread overview]
Message-ID: <20a5ac6a0e089a11f82f2d6eaa303a775b11e3a3.camel@mediatek.com> (raw)
In-Reply-To: <20220701035845.16458-5-rex-bc.chen@mediatek.com>

Hi, Bo-Chen:

On Fri, 2022-07-01 at 11:58 +0800, Bo-Chen Chen wrote:
> DPI is not support output format as YUV, but there is the setting of
> configuring output YUV. Therefore, remove them in this patch.

Applied to mediatek-drm-next [1], thanks.

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next

Regards,
CK

> 
> Fixes: 9e629c17aa8d ("drm/mediatek: Add DPI sub driver")
> Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_dpi.c | 31 ++++++--------------------
> ----
>  1 file changed, 6 insertions(+), 25 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index f66a121ba0c9..3473ee18ad97 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -54,13 +54,7 @@ enum mtk_dpi_out_channel_swap {
>  };
>  
>  enum mtk_dpi_out_color_format {
> -	MTK_DPI_COLOR_FORMAT_RGB,
> -	MTK_DPI_COLOR_FORMAT_RGB_FULL,
> -	MTK_DPI_COLOR_FORMAT_YCBCR_444,
> -	MTK_DPI_COLOR_FORMAT_YCBCR_422,
> -	MTK_DPI_COLOR_FORMAT_XV_YCC,
> -	MTK_DPI_COLOR_FORMAT_YCBCR_444_FULL,
> -	MTK_DPI_COLOR_FORMAT_YCBCR_422_FULL
> +	MTK_DPI_COLOR_FORMAT_RGB
>  };
>  
>  struct mtk_dpi {
> @@ -373,24 +367,11 @@ static void mtk_dpi_config_disable_edge(struct
> mtk_dpi *dpi)
>  static void mtk_dpi_config_color_format(struct mtk_dpi *dpi,
>  					enum mtk_dpi_out_color_format
> format)
>  {
> -	if ((format == MTK_DPI_COLOR_FORMAT_YCBCR_444) ||
> -	    (format == MTK_DPI_COLOR_FORMAT_YCBCR_444_FULL)) {
> -		mtk_dpi_config_yuv422_enable(dpi, false);
> -		mtk_dpi_config_csc_enable(dpi, true);
> -		mtk_dpi_config_swap_input(dpi, false);
> -		mtk_dpi_config_channel_swap(dpi,
> MTK_DPI_OUT_CHANNEL_SWAP_BGR);
> -	} else if ((format == MTK_DPI_COLOR_FORMAT_YCBCR_422) ||
> -		   (format == MTK_DPI_COLOR_FORMAT_YCBCR_422_FULL)) {
> -		mtk_dpi_config_yuv422_enable(dpi, true);
> -		mtk_dpi_config_csc_enable(dpi, true);
> -		mtk_dpi_config_swap_input(dpi, true);
> -		mtk_dpi_config_channel_swap(dpi,
> MTK_DPI_OUT_CHANNEL_SWAP_RGB);
> -	} else {
> -		mtk_dpi_config_yuv422_enable(dpi, false);
> -		mtk_dpi_config_csc_enable(dpi, false);
> -		mtk_dpi_config_swap_input(dpi, false);
> -		mtk_dpi_config_channel_swap(dpi,
> MTK_DPI_OUT_CHANNEL_SWAP_RGB);
> -	}
> +	/* only support RGB888 */
> +	mtk_dpi_config_yuv422_enable(dpi, false);
> +	mtk_dpi_config_csc_enable(dpi, false);
> +	mtk_dpi_config_swap_input(dpi, false);
> +	mtk_dpi_config_channel_swap(dpi, MTK_DPI_OUT_CHANNEL_SWAP_RGB);
>  }
>  
>  static void mtk_dpi_dual_edge(struct mtk_dpi *dpi)


  reply	other threads:[~2022-07-05  3:48 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-01  3:58 [PATCH v15 00/16] drm/mediatek: Add MT8195 dp_intf driver Bo-Chen Chen
2022-07-01  3:58 ` [PATCH v15 01/16] dt-bindings: mediatek,dpi: Add DP_INTF compatible Bo-Chen Chen
2022-07-05  3:42   ` CK Hu
2022-07-01  3:58 ` [PATCH v15 02/16] dt-bindings: mediatek,dpi: Revise mediatek strings to correct format Bo-Chen Chen
2022-07-05  3:43   ` CK Hu
2022-07-01  3:58 ` [PATCH v15 03/16] drm/mediatek: dpi: Add kernel document for struct mtk_dpi_conf Bo-Chen Chen
2022-07-05  3:44   ` CK Hu
2022-07-01  3:58 ` [PATCH v15 04/16] drm/mediatek: dpi: Remove output format of YUV Bo-Chen Chen
2022-07-05  3:48   ` CK Hu [this message]
2022-07-01  3:58 ` [PATCH v15 05/16] drm/mediatek: dpi: Add support for quantization range Bo-Chen Chen
2022-07-05  3:49   ` CK Hu
2022-07-01  3:58 ` [PATCH v15 06/16] drm/mediatek: dpi: implement a CK/DE pol toggle in SoC config Bo-Chen Chen
2022-07-05  3:50   ` CK Hu
2022-07-01  3:58 ` [PATCH v15 07/16] drm/mediatek: dpi: implement a swap_input " Bo-Chen Chen
2022-07-05  3:51   ` CK Hu
2022-07-01  3:58 ` [PATCH v15 08/16] drm/mediatek: dpi: move dimension mask to " Bo-Chen Chen
2022-07-05  3:52   ` CK Hu
2022-07-01  3:58 ` [PATCH v15 09/16] drm/mediatek: dpi: move hvsize_mask " Bo-Chen Chen
2022-07-05  3:53   ` CK Hu
2022-07-01  3:58 ` [PATCH v15 10/16] drm/mediatek: dpi: move swap_shift " Bo-Chen Chen
2022-07-05  3:53   ` CK Hu
2022-07-01  3:58 ` [PATCH v15 11/16] drm/mediatek: dpi: move the yuv422_en_bit " Bo-Chen Chen
2022-07-05  3:54   ` CK Hu
2022-07-01  3:58 ` [PATCH v15 12/16] drm/mediatek: dpi: move the csc_enable bit " Bo-Chen Chen
2022-07-05  3:55   ` CK Hu
2022-07-01  3:58 ` [PATCH v15 13/16] drm/mediatek: dpi: Add YUV422 output support Bo-Chen Chen
2022-07-05  5:21   ` CK Hu
2022-07-05  8:39     ` Rex-BC Chen
2022-07-05  8:51       ` Rex-BC Chen
2022-07-01  3:58 ` [PATCH v15 14/16] drm/mediatek: dpi: add config to support direct connection to dpi panels Bo-Chen Chen
2022-07-05  5:24   ` CK Hu
2022-07-01  3:58 ` [PATCH v15 15/16] drm/mediatek: dpi: Only enable dpi after the bridge is enabled Bo-Chen Chen
2022-07-05  3:56   ` CK Hu
2022-07-01  3:58 ` [PATCH v15 16/16] drm/mediatek: dpi: Add dp_intf support Bo-Chen Chen
2022-07-05  5:29   ` CK Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20a5ac6a0e089a11f82f2d6eaa303a775b11e3a3.camel@mediatek.com \
    --to=ck.hu@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=airlied@linux.ie \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=granquet@baylibre.com \
    --cc=jitao.shi@mediatek.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=liangxu.xu@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=msp@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=rex-bc.chen@mediatek.com \
    --cc=robh+dt@kernel.org \
    --cc=wenst@chromium.org \
    --cc=xinlei.lee@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®