From: Viacheslav Dubeyko <slava@dubeyko.com>
To: Max Kellermann <max.kellermann@ionos.com>,
idryomov@gmail.com, amarkuze@redhat.com,
ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/12] fs/ceph/super.h: convert ceph_cap_snap.writing fields to `bool`
Date: Tue, 30 Jun 2026 09:11:27 -0700 [thread overview]
Message-ID: <20ac85bf97c98688671cb64e609b6e142d85136a.camel@dubeyko.com> (raw)
In-Reply-To: <20260612165204.86137-6-max.kellermann@ionos.com>
On Fri, 2026-06-12 at 18:51 +0200, Max Kellermann wrote:
> This will allow better struct packing.
>
> Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
> ---
> fs/ceph/caps.c | 2 +-
> fs/ceph/snap.c | 4 ++--
> fs/ceph/super.h | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c
> index cf9916608dc2..e50bcb393c8f 100644
> --- a/fs/ceph/caps.c
> +++ b/fs/ceph/caps.c
> @@ -3288,7 +3288,7 @@ static void __ceph_put_cap_refs(struct
> ceph_inode_info *ci, int had,
> struct ceph_cap_snap,
> ci_item);
>
> - capsnap->writing = 0;
> + capsnap->writing = false;
> if (ceph_try_drop_cap_snap(ci, capsnap))
> /* put the ref held by ceph_queue_cap_snap()
> */
> put++;
> diff --git a/fs/ceph/snap.c b/fs/ceph/snap.c
> index 52b4c2684f92..6dbc7859ff49 100644
> --- a/fs/ceph/snap.c
> +++ b/fs/ceph/snap.c
> @@ -521,7 +521,7 @@ static bool has_new_snaps(struct
> ceph_snap_context *o,
> * However, if a (sync) write is currently in-progress when we apply
> * the snapshot, we have to wait until the write succeeds or fails
> * (and a final size/mtime is known). In this case the
> - * cap_snap->writing = 1, and is said to be "pending." When the
> write
> + * cap_snap->writing = true, and is said to be "pending." When the
> write
> * finishes, we __ceph_finish_cap_snap().
> *
> * Caller must hold snap_rwsem for read (i.e., the realm topology
> won't
> @@ -627,7 +627,7 @@ static void ceph_queue_cap_snap(struct
> ceph_inode_info *ci,
> doutc(cl, "%p %llx.%llx cap_snap %p snapc %p seq
> %llu used WR,"
> " now pending\n", inode, ceph_vinop(inode),
> capsnap,
> old_snapc, old_snapc->seq);
> - capsnap->writing = 1;
> + capsnap->writing = true;
> } else {
> /* note mtime, size NOW. */
> __ceph_finish_cap_snap(ci, capsnap);
> diff --git a/fs/ceph/super.h b/fs/ceph/super.h
> index 18960a9e735a..505a1552f355 100644
> --- a/fs/ceph/super.h
> +++ b/fs/ceph/super.h
> @@ -269,7 +269,7 @@ struct ceph_cap_snap {
> u64 time_warp_seq;
> u64 truncate_size;
> u32 truncate_seq;
> - int writing; /* a sync write is still in progress */
> + bool writing; /* a sync write is still in progress */
> int dirty_pages; /* dirty pages awaiting writeback */
> bool inline_data;
> bool need_flush;
Looks good.
Reviewed-by: Viacheslav Dubeyko <slava@dubeyko.com>
Thanks,
Slava.
next prev parent reply other threads:[~2026-06-30 16:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-12 16:51 [PATCH 00/12] fs/ceph: optimize struct layouts Max Kellermann
2026-06-12 16:51 ` [PATCH 01/12] fs/ceph/super: remove unused field `i_cap_migration_resv` Max Kellermann
2026-06-30 15:46 ` Viacheslav Dubeyko
2026-06-12 16:51 ` [PATCH 02/12] fs/ceph/super: make field `i_truncate_pagecache_size` optional Max Kellermann
2026-06-30 16:01 ` Viacheslav Dubeyko
2026-06-30 16:10 ` Max Kellermann
2026-06-12 16:51 ` [PATCH 03/12] include/ceph/ceph_fs.h: convert `pool_id` to u32 Max Kellermann
2026-06-30 16:05 ` Viacheslav Dubeyko
2026-06-30 16:12 ` Max Kellermann
2026-06-12 16:51 ` [PATCH 04/12] fs/ceph/super.h: convert ceph_inode_xattr fields to `bool` Max Kellermann
2026-06-30 16:08 ` Viacheslav Dubeyko
2026-06-12 16:51 ` [PATCH 05/12] fs/ceph/super.h: convert ceph_cap_snap.writing " Max Kellermann
2026-06-30 16:11 ` Viacheslav Dubeyko [this message]
2026-06-12 16:51 ` [PATCH 06/12] fs/ceph: consistently use `u32` for `time_warp_seq` Max Kellermann
2026-06-30 16:16 ` Viacheslav Dubeyko
2026-06-12 16:51 ` [PATCH 07/12] fs/ceph/super: reorder fields to eliminate padding holes Max Kellermann
2026-06-12 16:52 ` [PATCH 08/12] fs/ceph: remove i_truncate_mutex, use i_fragtree_mutex for both Max Kellermann
2026-06-12 16:52 ` [PATCH 09/12] fs/ceph/super.h: add `const` to helpers Max Kellermann
2026-06-12 16:52 ` [PATCH 10/12] fs/ceph/super.h: add helper ceph_in_snap() Max Kellermann
2026-06-12 16:52 ` [PATCH 11/12] fs/ceph: use ceph_vino() etc. instead of accessing i_vino directly Max Kellermann
2026-06-12 16:52 ` [PATCH 12/12] fs/ceph: remove redundant inode number from ceph_inode_info Max Kellermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20ac85bf97c98688671cb64e609b6e142d85136a.camel@dubeyko.com \
--to=slava@dubeyko.com \
--cc=amarkuze@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=max.kellermann@ionos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®