From: Viacheslav Dubeyko <slava@dubeyko.com>
To: Max Kellermann <max.kellermann@ionos.com>,
idryomov@gmail.com, amarkuze@redhat.com,
ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/12] fs/ceph: consistently use `u32` for `time_warp_seq`
Date: Tue, 30 Jun 2026 09:16:28 -0700 [thread overview]
Message-ID: <3f7204ad1911795899e20a84ae8b86da537d8672.camel@dubeyko.com> (raw)
In-Reply-To: <20260612165204.86137-7-max.kellermann@ionos.com>
On Fri, 2026-06-12 at 18:51 +0200, Max Kellermann wrote:
> Previously, both `u32` and `u64` was used with implicit casts. All
> this does is add useless overhead.
>
> This will allow better struct packing in `struct ceph_cap_snap`.
>
> Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
> ---
> fs/ceph/inode.c | 6 +++---
> fs/ceph/super.h | 4 ++--
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c
> index c26217ed2034..17df694fe978 100644
> --- a/fs/ceph/inode.c
> +++ b/fs/ceph/inode.c
> @@ -915,7 +915,7 @@ void ceph_inode_set_subvolume(struct inode
> *inode, u64 subvolume_id)
> }
>
> void ceph_fill_file_time(struct inode *inode, int issued,
> - u64 time_warp_seq, struct timespec64
> *ctime,
> + u32 time_warp_seq, struct timespec64
> *ctime,
> struct timespec64 *mtime, struct timespec64
> *atime)
> {
> struct ceph_client *cl = ceph_inode_to_client(inode);
> @@ -939,7 +939,7 @@ void ceph_fill_file_time(struct inode *inode, int
> issued,
> ceph_seq_cmp(time_warp_seq, ci->i_time_warp_seq)
> > 0) {
> /* the MDS did a utimes() */
> doutc(cl, "mtime %ptSp -> %ptSp tw %d ->
> %d\n", &imtime, mtime,
> - ci->i_time_warp_seq,
> (int)time_warp_seq);
> + ci->i_time_warp_seq, time_warp_seq);
>
> inode_set_mtime_to_ts(inode, *mtime);
> inode_set_atime_to_ts(inode, *atime);
> @@ -971,7 +971,7 @@ void ceph_fill_file_time(struct inode *inode, int
> issued,
> }
> }
> if (warn) /* time_warp_seq shouldn't go backwards */
> - doutc(cl, "%p mds time_warp_seq %llu < %u\n", inode,
> + doutc(cl, "%p mds time_warp_seq %u < %u\n", inode,
> time_warp_seq, ci->i_time_warp_seq);
> }
>
> diff --git a/fs/ceph/super.h b/fs/ceph/super.h
> index 505a1552f355..9b5119b1d0a9 100644
> --- a/fs/ceph/super.h
> +++ b/fs/ceph/super.h
> @@ -266,7 +266,7 @@ struct ceph_cap_snap {
> u64 size;
> u64 change_attr;
> struct timespec64 mtime, atime, ctime, btime;
> - u64 time_warp_seq;
> + u32 time_warp_seq;
> u64 truncate_size;
> u32 truncate_seq;
> bool writing; /* a sync write is still in progress */
> @@ -1091,7 +1091,7 @@ extern int ceph_fill_file_size(struct inode
> *inode, int issued,
> u32 truncate_seq, u64 truncate_size,
> u64 size);
> extern void ceph_inode_set_subvolume(struct inode *inode, u64
> subvolume_id);
> extern void ceph_fill_file_time(struct inode *inode, int issued,
> - u64 time_warp_seq, struct timespec64
> *ctime,
> + u32 time_warp_seq, struct timespec64
> *ctime,
> struct timespec64 *mtime,
> struct timespec64 *atime);
> extern int ceph_fill_inode(struct inode *inode, struct page
> *locked_page,
Makes sense.
Reviewed-by: Viacheslav Dubeyko <slava@dubeyko.com>
Thanks,
Slava.
next prev parent reply other threads:[~2026-06-30 16:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-12 16:51 [PATCH 00/12] fs/ceph: optimize struct layouts Max Kellermann
2026-06-12 16:51 ` [PATCH 01/12] fs/ceph/super: remove unused field `i_cap_migration_resv` Max Kellermann
2026-06-30 15:46 ` Viacheslav Dubeyko
2026-06-12 16:51 ` [PATCH 02/12] fs/ceph/super: make field `i_truncate_pagecache_size` optional Max Kellermann
2026-06-30 16:01 ` Viacheslav Dubeyko
2026-06-30 16:10 ` Max Kellermann
2026-06-12 16:51 ` [PATCH 03/12] include/ceph/ceph_fs.h: convert `pool_id` to u32 Max Kellermann
2026-06-30 16:05 ` Viacheslav Dubeyko
2026-06-30 16:12 ` Max Kellermann
2026-06-12 16:51 ` [PATCH 04/12] fs/ceph/super.h: convert ceph_inode_xattr fields to `bool` Max Kellermann
2026-06-30 16:08 ` Viacheslav Dubeyko
2026-06-12 16:51 ` [PATCH 05/12] fs/ceph/super.h: convert ceph_cap_snap.writing " Max Kellermann
2026-06-30 16:11 ` Viacheslav Dubeyko
2026-06-12 16:51 ` [PATCH 06/12] fs/ceph: consistently use `u32` for `time_warp_seq` Max Kellermann
2026-06-30 16:16 ` Viacheslav Dubeyko [this message]
2026-06-12 16:51 ` [PATCH 07/12] fs/ceph/super: reorder fields to eliminate padding holes Max Kellermann
2026-06-12 16:52 ` [PATCH 08/12] fs/ceph: remove i_truncate_mutex, use i_fragtree_mutex for both Max Kellermann
2026-06-12 16:52 ` [PATCH 09/12] fs/ceph/super.h: add `const` to helpers Max Kellermann
2026-06-12 16:52 ` [PATCH 10/12] fs/ceph/super.h: add helper ceph_in_snap() Max Kellermann
2026-06-12 16:52 ` [PATCH 11/12] fs/ceph: use ceph_vino() etc. instead of accessing i_vino directly Max Kellermann
2026-06-12 16:52 ` [PATCH 12/12] fs/ceph: remove redundant inode number from ceph_inode_info Max Kellermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f7204ad1911795899e20a84ae8b86da537d8672.camel@dubeyko.com \
--to=slava@dubeyko.com \
--cc=amarkuze@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=max.kellermann@ionos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®