mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Ajye Huang <ajye_huang@compal.corp-partner.google.com>,
	linux-kernel@vger.kernel.org
Cc: Mark Brown <broonie@kernel.org>,
	Cezary Rojewski <cezary.rojewski@intel.com>,
	Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
	Bard Liao <yung-chuan.liao@linux.intel.com>,
	Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
	Kai Vehmanen <kai.vehmanen@linux.intel.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Brent Lu <brent.lu@intel.com>, Yong Zhi <yong.zhi@intel.com>,
	Mac Chiang <mac.chiang@intel.com>,
	ye xingchen <ye.xingchen@zte.com.cn>,
	Vamshi Krishna <vamshi.krishna.gopal@intel.com>,
	Muralidhar Reddy <muralidhar.reddy@intel.com>,
	Libin Yang <libin.yang@intel.com>, David Lin <CTLIN0@nuvoton.com>,
	alsa-devel@alsa-project.org
Subject: Re: [PATCH v1 0/2] Adds the combination of headset codec ALC5682I-VD + amp rt1019p
Date: Mon, 14 Nov 2022 10:11:34 -0600	[thread overview]
Message-ID: <20d36e6d-0c4b-f903-8940-841ac1b65d98@linux.intel.com> (raw)
In-Reply-To: <20221108042716.2930255-1-ajye_huang@compal.corp-partner.google.com>



On 11/7/22 22:27, Ajye Huang wrote:
> v1:
> - machine driver: 
>   - Adds the combination of headset codec ALC5682I-VD + amp rt1019p.
>   - Remove the duplicate code in machine driver.
> 
> Ajye Huang (2):
>   ASoC: Intel: sof_rt5682: add support for ALC5682I-VD with amp rt1019p
>   ASoC: Intel: sof rt5682: remove the duplicate codes

Nice catch on the second patch, this sort of duplicates are hard to
detect in code reviews.

For the series:

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>


> 
>  sound/soc/intel/boards/sof_rt5682.c               | 7 +------
>  sound/soc/intel/common/soc-acpi-intel-adl-match.c | 4 ++--
>  2 files changed, 3 insertions(+), 8 deletions(-)
> 

  parent reply	other threads:[~2022-11-14 16:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-08  4:27 Ajye Huang
2022-11-08  4:27 ` [PATCH v1 1/2] ASoC: Intel: sof_rt5682: add support for ALC5682I-VD with " Ajye Huang
2022-11-14  7:36   ` Chiang, Mac
2022-11-16  2:56     ` Ajye Huang
2022-11-08  4:27 ` [PATCH v1 2/2] ASoC: Intel: sof rt5682: remove the duplicate codes Ajye Huang
2022-11-14 16:11 ` Pierre-Louis Bossart [this message]
2022-11-16 13:13 ` [PATCH v1 0/2] Adds the combination of headset codec ALC5682I-VD + amp rt1019p Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20d36e6d-0c4b-f903-8940-841ac1b65d98@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=CTLIN0@nuvoton.com \
    --cc=ajye_huang@compal.corp-partner.google.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=brent.lu@intel.com \
    --cc=broonie@kernel.org \
    --cc=cezary.rojewski@intel.com \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=libin.yang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mac.chiang@intel.com \
    --cc=muralidhar.reddy@intel.com \
    --cc=perex@perex.cz \
    --cc=peter.ujfalusi@linux.intel.com \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=tiwai@suse.com \
    --cc=vamshi.krishna.gopal@intel.com \
    --cc=ye.xingchen@zte.com.cn \
    --cc=yong.zhi@intel.com \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®