From: SF Markus Elfring <elfring@users.sourceforge.net>
To: David Daney <ddaney@caviumnetworks.com>,
David Daney <david.daney@cavium.com>,
linux-i2c@vger.kernel.org
Cc: Jan Glauber <jglauber@cavium.com>,
Wolfram Sang <wsa@the-dreams.de>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: I2C-Octeon: Use common error handling code in octeon_i2c_probe()
Date: Thu, 26 Oct 2017 07:00:36 +0200 [thread overview]
Message-ID: <20e16385-afab-1d3d-b682-04589568850e@users.sourceforge.net> (raw)
In-Reply-To: <77df0e64-bf30-b6d0-b28b-ddb3c0574dfe@caviumnetworks.com>
> NAK. We don't need any more Markus Elfring spam.
Why do you not like another update suggestion for this use case?
>> Add a jump target so that a specific error message is stored only once
>> at the end of this function implementation.
>
> Please read C standard about duplicate literal strings to see
> why this is a completely misleading and false statement.
* I proposed to adjust the position for one function call, didn't I?
* Do you care for a bit of code reduction?
* Do you prefer to use an optimisation option like “-fmerge-constants”
(instead of integrating the shown small change)?
Regards,
Markus
prev parent reply other threads:[~2017-10-26 5:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 9:52 [PATCH] " SF Markus Elfring
2017-10-25 15:52 ` David Daney
2017-10-26 5:00 ` SF Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20e16385-afab-1d3d-b682-04589568850e@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=david.daney@cavium.com \
--cc=ddaney@caviumnetworks.com \
--cc=jglauber@cavium.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®