From: Dave Hansen <dave.hansen@intel.com>
To: Sohil Mehta <sohil.mehta@intel.com>, Jon Kohler <jon@nutanix.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>, Borislav Petkov <bp@alien8.de>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
Nikolay Borisov <nik.borisov@suse.com>,
Alex Murray <alex.murray@canonical.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Old microcode CPU matching issue - x86/microcode/intel: Refresh the revisions that determine old_microcode
Date: Thu, 20 Nov 2025 16:39:24 -0800 [thread overview]
Message-ID: <20e43176-f7e6-40aa-86f1-d709269b4787@intel.com> (raw)
In-Reply-To: <68c8db8e-4420-4cf4-9b30-4ce19e39a280@intel.com>
On 11/20/25 11:27, Dave Hansen wrote:
> On 11/20/25 11:13, Sohil Mehta wrote:
>> The early loading probably gets affected because intel_get_platform_id()
>> relies on boot_cpu_data which isn't initialized when load_ucode_bsp() is
>> called very early.
> Good point, and thanks for finding those bugs!
>
> We can probably just move back to building the vfm value from CPUID
> directly as opposed to reading it from boot_cpu_data.
OK, here's a theoretically fixed up series. I actually booted this on
real hardware and made sure I didn't break microcode loading in general:
https://git.kernel.org/pub/scm/linux/kernel/git/daveh/devel.git/log/?h=old-ucode-platform
The actual hardware I tested on was this one:
{ .flags = X86_CPU_ID_FLAG_ENTRY_VALID, .vendor = X86_VENDOR_INTEL, .family = 0x6, .model = 0x7a, .steppings = 0x0002, .platform_mask = 0x01, .driver_data = 0x42 },
For testing, I added a 100% made up but matching CPU
model/family/stepping that has (made up) later microcode and a
(made up) higher platform ID that I added to the ucode-defs.h file:
{ .flags = X86_CPU_ID_FLAG_ENTRY_VALID, .vendor = X86_VENDOR_INTEL, .family = 0x6, .model = 0x7a, .steppings = 0x0002, .platform_mask = 0x02, .driver_data = 0x43 },
Everything seemed to work OK for me in my limited but nonzero
amount of testing.
Any additional testing or eyeballs on the code would be appreciated.
I'll post it for real in a day or two if it all looks OK.
next prev parent reply other threads:[~2025-11-21 0:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-18 19:01 [PATCH 0/2] x86/intel: Refresh the old ucode revisions with a script Sohil Mehta
2025-08-18 19:01 ` [PATCH 1/2] x86/microcode/intel: Refresh the revisions that determine old_microcode Sohil Mehta
2025-08-19 5:19 ` Pawan Gupta
2025-08-19 11:18 ` Andrew Cooper
2025-08-19 16:13 ` Sohil Mehta
2025-08-19 18:31 ` Pawan Gupta
2025-08-19 18:28 ` Pawan Gupta
2025-08-19 19:07 ` Dave Hansen
2025-08-19 20:21 ` Andrew Cooper
2025-10-22 17:14 ` Old microcode CPU matching issue - " Jon Kohler
2025-10-22 17:53 ` Dave Hansen
2025-11-14 20:34 ` Dave Hansen
2025-11-20 16:35 ` Jon Kohler
2025-11-20 17:29 ` Sohil Mehta
2025-11-20 19:13 ` Sohil Mehta
2025-11-20 19:27 ` Dave Hansen
2025-11-21 0:39 ` Dave Hansen [this message]
2025-11-21 20:26 ` Sohil Mehta
2025-11-26 3:00 ` Jon Kohler
2025-08-18 19:01 ` [PATCH 2/2] scripts/x86: Add a script to update minimum Intel ucode revisions Sohil Mehta
2025-08-19 17:14 ` Dave Hansen
2025-08-19 20:41 ` Sohil Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20e43176-f7e6-40aa-86f1-d709269b4787@intel.com \
--to=dave.hansen@intel.com \
--cc=alex.murray@canonical.com \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jon@nutanix.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nik.borisov@suse.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=peterz@infradead.org \
--cc=sohil.mehta@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®