From: Andrew Lunn <andrew@lunn.ch>
To: Romain Gantois <romain.gantois@bootlin.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 4/6] net: phy: dp83869: Support 1000Base-X and 100Base-FX SFP modules
Date: Mon, 1 Jul 2024 18:49:25 +0200 [thread overview]
Message-ID: <21081e48-0f96-463f-a01a-959eb71bdb40@lunn.ch> (raw)
In-Reply-To: <20240701-b4-dp83869-sfp-v1-4-a71d6d0ad5f8@bootlin.com>
> + dev_info(&phydev->mdio.dev, "%s SFP compatible link mode: %s\n", __func__,
> + phy_modes(interface));
Maybe phydev_debug().
> +
> + dp83869 = phydev->priv;
> +
> + switch (interface) {
> + case PHY_INTERFACE_MODE_100BASEX:
> + dp83869->mode = DP83869_RGMII_100_BASE;
> + phydev->port = PORT_FIBRE;
> + break;
> + case PHY_INTERFACE_MODE_1000BASEX:
> + dp83869->mode = DP83869_RGMII_1000_BASE;
> + phydev->port = PORT_FIBRE;
> + break;
> + default:
> + dev_err(&phydev->mdio.dev,
> + "incompatible PHY-to-SFP module link mode %s!\n",
> + phy_modes(interface));
phydev_err()?
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2024-07-01 16:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 8:51 [PATCH net-next 0/6] net: phy: dp83869: Add support for downstream SFP cages Romain Gantois
2024-07-01 8:51 ` [PATCH net-next 1/6] net: phy: dp83869: Disable autonegotiation in RGMII/1000Base-X mode Romain Gantois
2024-07-01 16:40 ` Andrew Lunn
2024-07-02 8:44 ` Romain Gantois
2024-07-02 9:24 ` Russell King (Oracle)
2024-07-02 9:42 ` Romain Gantois
2024-07-02 10:15 ` Russell King (Oracle)
2024-07-02 13:01 ` Romain Gantois
2024-07-01 8:51 ` [PATCH net-next 2/6] net: phy: dp83869: Perform software restart after configuring op mode Romain Gantois
2024-07-01 16:44 ` Andrew Lunn
2024-07-02 8:45 ` Romain Gantois
2024-07-01 8:51 ` [PATCH net-next 3/6] net: phy: dp83869: Ensure that the FORCE_LINK_GOOD bit is cleared Romain Gantois
2024-07-01 8:51 ` [PATCH net-next 4/6] net: phy: dp83869: Support 1000Base-X and 100Base-FX SFP modules Romain Gantois
2024-07-01 16:49 ` Andrew Lunn [this message]
2024-07-01 8:51 ` [PATCH net-next 5/6] net: phy: dp83869: Support SGMII " Romain Gantois
2024-07-01 17:00 ` Andrew Lunn
2024-07-02 8:11 ` Romain Gantois
2024-07-02 13:21 ` Andrew Lunn
2024-07-02 14:56 ` Maxime Chevallier
2024-07-02 18:13 ` Russell King (Oracle)
2024-07-02 19:55 ` Andrew Lunn
2024-07-02 15:18 ` Russell King (Oracle)
2024-07-01 8:51 ` [PATCH net-next 6/6] net: phy: dp83869: Fix link up reporting in SGMII bridge mode Romain Gantois
2024-07-01 17:09 ` Andrew Lunn
2024-07-02 9:04 ` Romain Gantois
2024-07-02 9:28 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21081e48-0f96-463f-a01a-959eb71bdb40@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=romain.gantois@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®