From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Linus Walleij <linus.walleij@linaro.org>, linux-gpio@vger.kernel.org
Cc: Sebastian Reichel <sebastian.reichel@collabora.co.uk>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [3/3] pinctrl: mcp23s08: Combine two function calls in mcp23s08_dbg_show()
Date: Wed, 29 Nov 2017 15:04:31 +0100 [thread overview]
Message-ID: <2132d281-c4da-81b0-6dc7-4b42807cebf0@users.sourceforge.net> (raw)
In-Reply-To: <CACRpkdaoUad0i3Kddyp0aJRJ46frHMY9_57mwM3iXAhqL5V3aA@mail.gmail.com>
>> * Print a line break together with other data in a single function call.
>>
>> * Adjust indentation.
…
>
> This does not apply.
> Possibly depends on 2/3.
Partly, yes.
How do you think about the following possibilities?
* Omit two context lines at the end from this update step.
or
* Refer to the jump label “done” (instead of renaming it to “unlock” before).
Would you try once more to integrate the shown small change?
Regards,
Markus
next prev parent reply other threads:[~2017-11-29 14:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 15:45 [PATCH 0/3] pinctrl-mcp23s08: Fine-tuning for two function implementations SF Markus Elfring
2017-10-30 15:46 ` [PATCH 1/3] pinctrl: mcp23s08: Improve unlocking of a mutex in mcp23s08_irq() SF Markus Elfring
2017-11-29 12:51 ` Linus Walleij
2017-10-30 15:47 ` [PATCH 2/3] pinctrl: mcp23s08: Use common error handling code in mcp23s08_dbg_show() SF Markus Elfring
2017-11-29 12:55 ` Linus Walleij
2017-10-30 15:49 ` [PATCH 3/3] pinctrl: mcp23s08: Combine two function calls " SF Markus Elfring
2017-11-29 12:56 ` Linus Walleij
2017-11-29 14:04 ` SF Markus Elfring [this message]
2018-01-06 19:52 ` [PATCH v2] pinctrl: mcp23s08: Combine two function calls into one " SF Markus Elfring
2018-01-09 14:10 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2132d281-c4da-81b0-6dc7-4b42807cebf0@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.reichel@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome