* [PATCH RFC] [media] s5p-fimc: fix sleep in atomic in flite_hw_reset
@ 2024-05-21 7:36 Anastasia Belova
2024-05-23 9:27 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Anastasia Belova @ 2024-05-21 7:36 UTC (permalink / raw)
To: Sylwester Nawrocki
Cc: Anastasia Belova, Mauro Carvalho Chehab, Krzysztof Kozlowski,
Alim Akhtar, Kyungmin Park, linux-media, linux-arm-kernel,
linux-samsung-soc, linux-kernel
flite_hw_reset is called in fimc_lite_resume with spinlock
acquired that is forbidden. Replace usleep_range with udelay.
Fixes: 2b511edb986f ("[media] s5p-fimc: Add FIMC-LITE register definitions")
Signed-off-by: Anastasia Belova <abelova@astralinux.ru>
---
drivers/media/platform/samsung/exynos4-is/fimc-lite-reg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/samsung/exynos4-is/fimc-lite-reg.c b/drivers/media/platform/samsung/exynos4-is/fimc-lite-reg.c
index 2483277a6cb0..f1e7375c9a5f 100644
--- a/drivers/media/platform/samsung/exynos4-is/fimc-lite-reg.c
+++ b/drivers/media/platform/samsung/exynos4-is/fimc-lite-reg.c
@@ -30,7 +30,7 @@ void flite_hw_reset(struct fimc_lite *dev)
cfg = readl(dev->regs + FLITE_REG_CIGCTRL);
if (cfg & FLITE_REG_CIGCTRL_SWRST_RDY)
break;
- usleep_range(1000, 5000);
+ udelay(1000);
}
cfg |= FLITE_REG_CIGCTRL_SWRST;
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH RFC] [media] s5p-fimc: fix sleep in atomic in flite_hw_reset
2024-05-21 7:36 [PATCH RFC] [media] s5p-fimc: fix sleep in atomic in flite_hw_reset Anastasia Belova
@ 2024-05-23 9:27 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2024-05-23 9:27 UTC (permalink / raw)
To: Anastasia Belova, Sylwester Nawrocki
Cc: Mauro Carvalho Chehab, Alim Akhtar, Kyungmin Park, linux-media,
linux-arm-kernel, linux-samsung-soc, linux-kernel
On 21/05/2024 09:36, Anastasia Belova wrote:
> flite_hw_reset is called in fimc_lite_resume with spinlock
> acquired that is forbidden. Replace usleep_range with udelay.
>
> Fixes: 2b511edb986f ("[media] s5p-fimc: Add FIMC-LITE register definitions")
> Signed-off-by: Anastasia Belova <abelova@astralinux.ru>
> ---
> drivers/media/platform/samsung/exynos4-is/fimc-lite-reg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/samsung/exynos4-is/fimc-lite-reg.c b/drivers/media/platform/samsung/exynos4-is/fimc-lite-reg.c
> index 2483277a6cb0..f1e7375c9a5f 100644
> --- a/drivers/media/platform/samsung/exynos4-is/fimc-lite-reg.c
> +++ b/drivers/media/platform/samsung/exynos4-is/fimc-lite-reg.c
> @@ -30,7 +30,7 @@ void flite_hw_reset(struct fimc_lite *dev)
> cfg = readl(dev->regs + FLITE_REG_CIGCTRL);
> if (cfg & FLITE_REG_CIGCTRL_SWRST_RDY)
> break;
> - usleep_range(1000, 5000);
> + udelay(1000);
I think the code is rather wrong in fimc_lite_resume() - this should be
called outside of spinlock, thus usleep is ok.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-23 9:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-21 7:36 [PATCH RFC] [media] s5p-fimc: fix sleep in atomic in flite_hw_reset Anastasia Belova
2024-05-23 9:27 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®