From: Yunfeng Ye <yeyunfeng@huawei.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
<bvanassche@acm.org>, <bhelgaas@google.com>, <dsterba@suse.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
<alexander.h.duyck@linux.intel.com>,
<sakari.ailus@linux.intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] async: Let kfree() out of the critical area of the lock
Date: Wed, 25 Sep 2019 20:52:26 +0800 [thread overview]
Message-ID: <216356b1-38c1-8477-c4e8-03f497dd6ac8@huawei.com> (raw)
It's not necessary to put kfree() in the critical area of the lock, so
let it out.
Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
---
kernel/async.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/async.c b/kernel/async.c
index 4f9c1d6..1de270d 100644
--- a/kernel/async.c
+++ b/kernel/async.c
@@ -135,12 +135,12 @@ static void async_run_entry_fn(struct work_struct *work)
list_del_init(&entry->domain_list);
list_del_init(&entry->global_list);
- /* 3) free the entry */
- kfree(entry);
atomic_dec(&entry_count);
-
spin_unlock_irqrestore(&async_lock, flags);
+ /* 3) free the entry */
+ kfree(entry);
+
/* 4) wake up any waiters */
wake_up(&async_done);
}
--
2.7.4
next reply other threads:[~2019-09-25 12:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 12:52 Yunfeng Ye [this message]
2019-09-25 13:38 ` gregkh
2019-09-25 13:45 ` Yunfeng Ye
2019-09-25 15:20 ` Alexander Duyck
2019-09-26 7:58 ` Yunfeng Ye
2019-09-26 11:06 ` David Sterba
2019-09-26 15:18 ` Bart Van Assche
2019-09-27 1:00 ` Yunfeng Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=216356b1-38c1-8477-c4e8-03f497dd6ac8@huawei.com \
--to=yeyunfeng@huawei.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=bvanassche@acm.org \
--cc=dsterba@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®